gossi\codegen\generator\builder\parts\RoutineBuilderPart

Complexity

Total Complexity

8

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
	generate()	0	1	?
A	writeFunctionStatement()	0	12	2
A	writeParameters()	0	11	3
A	writeFunctionReturnType()	0	6	2
A	writeBody()	0	5	1

<?php
namespace gossi\codegen\generator\builder\parts;

use gossi\codegen\model\AbstractModel;
use gossi\codegen\model\RoutineInterface;

Trait RoutineBuilderPart {
	
	use TypeBuilderPart;
	
	protected abstract function generate(AbstractModel $model);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

	
	protected function writeFunctionStatement(RoutineInterface $model) {
		$this->writer->write('function ');

The property writer does not exist. Did you maybe forget to declare it?

		
		if ($model->isReferenceReturned()) {
			$this->writer->write('& ');
		}
		
		$this->writer->write($model->getName() . '(');
		$this->writeParameters($model);
		$this->writer->write(')');
		$this->writeFunctionReturnType($model);
	}
	
	protected function writeParameters(RoutineInterface $model) {
		$first = true;
		foreach ($model->getParameters() as $parameter) {
			if (!$first) {
				$this->writer->write(', ');
			}
			$first = false;
	
			$this->generate($parameter);
		}
	}
	
	protected function writeFunctionReturnType(RoutineInterface $model) {
		$type = $this->getType($model, $this->config->getGenerateReturnTypeHints());

The property config does not exist. Did you maybe forget to declare it?

$model is of type object<gossi\codegen\model\RoutineInterface>, but the function expects a object<gossi\codegen\model\AbstractModel>.

		if ($type !== null) {
			$this->writer->write(': ')->write($type);
		}
	}
	
	protected function writeBody(RoutineInterface $model) {
		$this->writer->writeln(' {')->indent();
		$this->writer->writeln(trim($model->getBody()));
		$this->writer->outdent()->rtrim()->writeln("}");

The string literal } does not require double quotes, as per coding-style, please use single quotes.

	}
}