Issues in Cache.php (master) - Issues in master - gjerokrsteski/pimf-framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (27)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

core/Pimf/Cache.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Pimf
 *
 * @copyright Copyright (c)  Gjero Krsteski (http://krsteski.de)
 * @license   http://opensource.org/licenses/MIT MIT License
 */

namespace Pimf;

use Pimf\Util\Character as Str, Pimf\Cache\Storages as CS;

/**
 * Cache usage
 *
 * <code>
 *    // Get the default cache storage instance
 *    $storage = Cache::storage();
 *
 *    // Get a specific cache storage instance by name
 *    $storage = Cache::storage('memcached');
 *
 *    // Call the "get" method on the default cache storage
 *    $name = Cache::get('name');
 *
 *    // Call the "put" method on the default cache storage
 *    Cache::put('name', 'Robin', 15);
 * </code>
 *
 * @package Pimf
 * @author  Gjero Krsteski <[email protected]>
 */
class Cache
{
    /**
     * All of the active cache storages.
     *
     * @var \Pimf\Cache\Storages\Storage[]
     */
    public static $storages = array();

    /**
     * Get a cache storage instance.
     *
     * @param string $storage
     *
     * @return CS\Apc|CS\Dba|CS\File|CS\Memcached|CS\Memory|CS\Pdo|CS\Redis|CS\WinCache
     */
    public static function storage($storage = null)
    {
        if ($storage === null) {
            $storage = Config::get('cache.storage') ?: 'memory';
        }

        if (!isset(static::$storages[$storage])) {
            static::$storages[$storage] = static::factory($storage);
        }

        return static::$storages[$storage];
    }

    /**
     * Create a new cache storage instance.
     *
     * @param string $storage
     *
     * @return CS\Apc|CS\Dba|CS\File|CS\Memcached|CS\Memory|CS\Pdo|CS\Redis|CS\WinCache
     * @throws \RuntimeException
     */
    protected static function factory($storage)
    {
        $cache = Config::get('cache');

        switch ($storage) {
            case 'apc':
                return new CS\Apc($cache['key']);

            case 'file':
                return new CS\File($cache['storage_path']);

            case 'pdo':
                return new CS\Pdo(Pdo\Factory::get($cache['database']), $cache['key']);

            case 'memcached':
                return new CS\Memcached(Memcached::connection(), $cache['key']);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

            case 'memory':
                return new CS\Memory();

            case 'redis':
                return new CS\Redis(Redis::database());

            case 'wincache':
                return new CS\WinCache($cache['key']);

            case 'dba':
                return new CS\Dba(Str::ensureTrailing('/', $cache['storage_path']) . $cache['key']);

            default:
                throw new \RuntimeException("Cache storage {$storage} is not supported.");
        }
    }

    /**
     * Magic Method for calling the methods on the default cache storage.
     *
     * @param $method
     * @param $parameters
     *
     * @return mixed
     */
    public static function __callStatic($method, $parameters)
    {
        return call_user_func_array(
            array(static::storage(Config::get('cache.storage')), $method), $parameters
        );
    }
}


1			<?php
2			/**
3			* Pimf
4			*
5			* @copyright Copyright (c) Gjero Krsteski (http://krsteski.de)
6			* @license http://opensource.org/licenses/MIT MIT License
7			*/
8
9			namespace Pimf;
10
11			use Pimf\Util\Character as Str, Pimf\Cache\Storages as CS;
12
13			/**
14			* Cache usage
15			*
16			* <code>
17			* // Get the default cache storage instance
18			* $storage = Cache::storage();
19			*
20			* // Get a specific cache storage instance by name
21			* $storage = Cache::storage('memcached');
22			*
23			* // Call the "get" method on the default cache storage
24			* $name = Cache::get('name');
25			*
26			* // Call the "put" method on the default cache storage
27			* Cache::put('name', 'Robin', 15);
28			* </code>
29			*
30			* @package Pimf
31			* @author Gjero Krsteski <[email protected]>
32			*/
33			class Cache
34			{
35			/**
36			* All of the active cache storages.
37			*
38			* @var \Pimf\Cache\Storages\Storage[]
39			*/
40			public static $storages = array();
41
42			/**
43			* Get a cache storage instance.
44			*
45			* @param string $storage
46			*
47			* @return CS\Apc\|CS\Dba\|CS\File\|CS\Memcached\|CS\Memory\|CS\Pdo\|CS\Redis\|CS\WinCache
48			*/
49			public static function storage($storage = null)
50			{
51			if ($storage === null) {
52			$storage = Config::get('cache.storage') ?: 'memory';
53			}
54
55			if (!isset(static::$storages[$storage])) {
56			static::$storages[$storage] = static::factory($storage);
57			}
58
59			return static::$storages[$storage];
60			}
61
62			/**
63			* Create a new cache storage instance.
64			*
65			* @param string $storage
66			*
67			* @return CS\Apc\|CS\Dba\|CS\File\|CS\Memcached\|CS\Memory\|CS\Pdo\|CS\Redis\|CS\WinCache
68			* @throws \RuntimeException
69			*/
70			protected static function factory($storage)
71			{
72			$cache = Config::get('cache');
73
74			switch ($storage) {
75			case 'apc':
76			return new CS\Apc($cache['key']);
77
78			case 'file':
79			return new CS\File($cache['storage_path']);
80
81			case 'pdo':
82			return new CS\Pdo(Pdo\Factory::get($cache['database']), $cache['key']);
83
84			case 'memcached':
85			return new CS\Memcached(Memcached::connection(), $cache['key']);
			0 ignored issues – show Bug introduced 2016-09-13 11:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\Pimf\Memcached::connection()` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
86
87			case 'memory':
88			return new CS\Memory();
89
90			case 'redis':
91			return new CS\Redis(Redis::database());
92
93			case 'wincache':
94			return new CS\WinCache($cache['key']);
95
96			case 'dba':
97			return new CS\Dba(Str::ensureTrailing('/', $cache['storage_path']) . $cache['key']);
98
99			default:
100			throw new \RuntimeException("Cache storage {$storage} is not supported.");
101			}
102			}
103
104			/**
105			* Magic Method for calling the methods on the default cache storage.
106			*
107			* @param $method
108			* @param $parameters
109			*
110			* @return mixed
111			*/
112			public static function __callStatic($method, $parameters)
113			{
114			return call_user_func_array(
115			array(static::storage(Config::get('cache.storage')), $method), $parameters
116			);
117			}
118			}
119

GitHub Access Token became invalid

Issues (27)

Security Analysis not enabled

core/Pimf/Cache.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

gjerokrsteski / pimf-framework

GitHub Access Token became invalid

Issues (27)

Security Analysis not enabled

core/Pimf/Cache.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like