forkcms / forkcms

src/Backend/Core/Engine/DataGridDatabase.php

<?php

namespace Backend\Core\Engine;

use Backend\Core\Engine\Model as BackendModel;

/**
 * A datagrid with a database-connection as source
 */
class DataGridDatabase extends DataGrid
{
    /**
     * @param string $query The query to retrieve the data.
     * @param array $parameters The parameters to be used inside the query.
     * @param string $resultsQuery The optional count query, used to calculate the number of results.
     * @param array $resultsParameters The parameters to be used inside the results query.
     */
    public function __construct(
        string $query,
        array $parameters = [],
        string $resultsQuery = null,
        array $resultsParameters = []
    ) {
        parent::__construct(
            new \SpoonDatagridSourceDB(
                BackendModel::get('database'),

It seems like Backend\Core\Engine\Model::get('database') can also be of type null; however, parameter $dbConnection of SpoonDatagridSourceDB::__construct() does only seem to accept SpoonDatabase, maybe add an additional type check?

                [$query, $parameters],
                $resultsQuery === null ? null : [$resultsQuery, $resultsParameters]

It seems like $resultsQuery === null ? null : array($resultsQuery, $resultsParameters) can also be of type array<integer,array|string>; however, parameter $numResultsQuery of SpoonDatagridSourceDB::__construct() does only seem to accept string, maybe add an additional type check?

            )
        );
    }
}