flack / openpsa

src/midcom/datamanager/storage/blobs.php

Spacing +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
     protected function save_attachment_list() : bool
     {
         if (!empty($this->config['widget_config']['sortable'])) {
-            uasort($this->map, function ($a, $b) {
+            uasort($this->map, function($a, $b) {
                 if ($a->metadata->score == $b->metadata->score) {
                     return strnatcasecmp($a->name, $b->name);
                 }

Braces +4 added lines, -2 removed lines

@@ -40,7 +40,8 @@ 
         foreach ($items as $identifier => $guid) {
             try {
                 $results[$identifier] = new midcom_db_attachment($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }
@@ -193,7 +194,8 @@ 
         foreach (self::load_map($object, $field) as $identifier => $guid) {
             try {
                 $attachments[$identifier] = midcom_db_attachment::get_cached($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
             }
         }

lib/midcom/services/indexer/main.php

Braces +12 added lines, -6 removed lines

@@ -131,7 +131,8 @@ 
         try {
             $this->_backend->index($documents);
             return true;
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             if ($batch) {
                 throw $e;
             }
@@ -160,7 +161,8 @@ 
         try {
             $this->_backend->delete($RIs);
             return true;
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             debug_add("Deleting error: " . $e->getMessage(), MIDCOM_LOG_ERROR);
             return false;
         }
@@ -182,7 +184,8 @@ 
         try {
             $this->_backend->delete_all($constraint);
             return true;
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             debug_add("Deleting error: " . $e->getMessage(), MIDCOM_LOG_ERROR);
             return false;
         }
@@ -216,7 +219,8 @@ 
 
         try {
             $result_raw = $this->_backend->query($query, $filter, $options);
-        } catch (Exception $e) {
+        }
+        catch (Exception $e) {
             debug_add("Query error: " . $e->getMessage(), MIDCOM_LOG_ERROR);
             return $result;
         }
@@ -237,7 +241,8 @@ 
             if (!empty($document->topic_guid)) {
                 try {
                     midcom_db_topic::get_cached($document->topic_guid);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     // Skip document, the object is hidden.
                     debug_add("Skipping the generic document {$document->title}, its topic seems to be invisible, we cannot proceed.");
                     continue;
@@ -250,7 +255,8 @@ 
                 // Strip language code from end of RI if it looks like "<GUID>_<LANG>"
                 try {
                     midcom::get()->dbfactory->get_object_by_guid(preg_replace('/^([0-9a-f]{32,80})_[a-z]{2}$/', '\\1', $document->RI));
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     // Skip document, the object is hidden, deleted or otherwise unavailable.
                     //@todo Maybe nonexistent objects should be removed from index?
                     continue;

lib/net/nehmer/comments/comment.php

Braces +2 added lines, -1 removed lines

@@ -409,7 +409,8 @@
         //Get the parent object
         try {
             $parent = midcom::get()->dbfactory->get_object_by_guid($this->objectguid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return;
         }

Spacing +3 added lines, -3 removed lines

@@ -218,8 +218,8 @@ 
     {
         $config = midcom_baseclasses_components_configuration::get('net.nehmer.comments', 'config');
 
-        if (   $config->get('ratings_enable')
-            && (    $config->get('ratings_cache_to_object')
+        if ($config->get('ratings_enable')
+            && ($config->get('ratings_cache_to_object')
                  || $config->get('comment_count_cache_to_object'))) {
             // Handle ratings
             $comments = self::list_by_objectguid($this->objectguid);
@@ -268,7 +268,7 @@ 
 
     private function _send_notifications()
     {
-        if (   empty($this->title)
+        if (empty($this->title)
             && empty($this->content)) {
             // No need to send notifications about empty rating entries
             return;

lib/net/nehmer/blog/viewer.php

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
             net_nemein_rss_manage::add_toolbar_buttons($this->_node_toolbar, $this->_topic->can_do('midgard:create'));
         }
 
-        if (   $this->_topic->can_do('midgard:update')
+        if ($this->_topic->can_do('midgard:update')
             && $this->_topic->can_do('midcom:component_config')) {
             $buttons[] = $workflow->get_button('config/', [
                 MIDCOM_TOOLBAR_LABEL => $this->_l10n_midcom->get('component configuration'),
@@ -114,7 +114,7 @@ 
             $this->_request_data['categories'] = explode(',', $this->_config->get('categories'));
 
             foreach ($this->_request_data['schemadb']->all() as $schema) {
-                if (   $schema->has_field('categories')
+                if ($schema->has_field('categories')
                     && $schema->get_field('categories')['type'] == 'select') {
                     // TODO: Merge schema local and component config categories?
                     $options = array_combine($this->_request_data['categories'], $this->_request_data['categories']);

lib/org/openpsa/invoices/billing/data.php

Indentation +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
     {
         if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
-               // check if the customerContact is set and has invoice_data
+                // check if the customerContact is set and has invoice_data
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
             $bd = new self();
             $due = midcom_baseclasses_components_configuration::get('org.openpsa.invoices', 'config')->get('default_due_days');

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
      */
     public static function get_by_object(org_openpsa_invoices_interfaces_customer $object) : self
     {
-        if (   !($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
+        if (!($bd = self::get_billing_data(org_openpsa_contacts_group_dba::class, $object->customer))
                // check if the customerContact is set and has invoice_data
             && !($bd = self::get_billing_data(org_openpsa_contacts_person_dba::class, $object->customerContact))) {
             $bd = new self();

Braces +6 added lines, -3 removed lines

@@ -96,7 +96,8 @@ 
             // if the property useContactAddress is set
             $billing_data[0]->set_address();
             return $billing_data[0];
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return null;
         }
@@ -141,10 +142,12 @@ 
     {
         try {
             return new org_openpsa_contacts_person_dba($this->linkGuid);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             try {
                 return new org_openpsa_contacts_group_dba($this->linkGuid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("Failed to load contact with GUID: " . $this->linkGuid . " - last error:" . $e->getMessage(), MIDCOM_LOG_ERROR);
                 return false;
             }

lib/midcom/baseclasses/components/handler/rest.php

Braces +2 added lines, -1 removed lines

@@ -197,7 +197,8 @@
             if ($this->_response === null) {
                 $this->_stop('Could not handle request, unknown method', 405);
             }
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $this->_responseStatus = $e->getCode();
             return $this->_send_response($e->getMessage());
         }

lib/net/nehmer/static/handler/admin.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
     private function load_controller() : controller
     {
-        if (    $this->_config->get('simple_name_handling')
+        if ($this->_config->get('simple_name_handling')
              && !midcom::get()->auth->admin) {
             foreach ($this->_request_data['schemadb']->all() as $schema) {
                 $schema->get_field('name')['readonly'] = true;

lib/midcom/services/toolbars.php

Spacing +1 added lines, -1 removed lines

@@ -314,7 +314,7 @@
 
     private function add_head_elements(bool $centralized = false) : bool
     {
-        if (   !midcom::get()->auth->user
+        if (!midcom::get()->auth->user
             || !midcom::get()->config->get('toolbars_enable_centralized')
             || !midcom::get()->auth->can_user_do('midcom:centralized_toolbar', null, __CLASS__)) {
             return false;

lib/midcom/services/metadata.php

Spacing +4 added lines, -4 removed lines

@@ -109,20 +109,20 @@ 
         }
 
         // Approval attributes
-        if (   midcom::get()->config->get('metadata_approval')
+        if (midcom::get()->config->get('metadata_approval')
             && !$object->metadata->is_approved()) {
             $css_classes[] = 'unapproved';
         }
 
         // Hiding and scheduling attributes
-        if (   (   !midcom::get()->config->get('show_hidden_objects')
+        if ((!midcom::get()->config->get('show_hidden_objects')
                 || midcom::get()->config->get('metadata_scheduling'))
             && !$object->metadata->is_visible()) {
             $css_classes[] = 'hidden';
         }
 
         // Folder's class
-        if (   $object instanceof midcom_db_topic
+        if ($object instanceof midcom_db_topic
             && $page_class = $object->get_parameter('midcom.services.metadata', 'page_class')) {
             $css_classes[] = $page_class;
         }
@@ -193,7 +193,7 @@ 
     private function _add_opengraph_metadata(midcom_helper_metadata $view_metadata)
     {
         $opengraph_type = $view_metadata->object->get_parameter('midcom.helper.metadata', 'opengraph_type');
-        if (   $opengraph_type
+        if ($opengraph_type
             && $opengraph_type != 'none') {
             $request_metadata = $this->get_request_metadata();