flack / openpsa

lib/org/openpsa/documents/midcom/interfaces.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
     public function resolve_object_link(midcom_db_topic $topic, midcom_core_dbaobject $object) : ?string
     {
-        if (   $object instanceof org_openpsa_documents_document_dba
+        if ($object instanceof org_openpsa_documents_document_dba
             && $object->topic == $topic->id) {
             return "document/{$object->guid}/";
         }

lib/net/nemein/wiki/style/view-wikipage-raw.php

Spacing +1 added lines, -1 removed lines

@@ -6,6 +6,6 @@
     &(view["content"]:h);
     <?php
 } else {
-    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub')."</p>";
+    echo "<p class=\"stub\">" . $data['l10n']->get('this page is stub') . "</p>";
 }
 ?>
\ No newline at end of file

lib/org/openpsa/invoices/style/admin-read.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
     <?php } ?>
 
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
     <div class="description value">&(view['description']:h);</div></div>
 
     <?php

Braces +2 added lines, -1 removed lines

@@ -8,7 +8,8 @@
     if ($customer->orgOpenpsaObtype < org_openpsa_contacts_group_dba::ORGANIZATION) {
         $customer = false;
     }
-} catch (midcom_error) {
+}
+catch (midcom_error) {
     $customer = false;
 }
 

lib/org/openpsa/relatedto/style/show_entries_html.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
             <?php
             //index is needed for sorting
             echo "'index_name',";
-            echo "'" . $data['l10n']->get('entry title') ."',";
+            echo "'" . $data['l10n']->get('entry title') . "',";
             echo "'" . $data['l10n']->get('entry text') . "',";
             echo "'" . $data['l10n']->get('entry created') . "',";
             echo "'index_creator', '" . $data['l10n_midcom']->get('creator') . "',";

Braces +2 added lines, -1 removed lines

@@ -25,7 +25,8 @@
             $row['creator_index'] = $creator->rname;
             $creator_card = org_openpsa_widgets_contact::get($entry->metadata->creator);
             $row['creator'] = $creator_card->show_inline();
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             $row['creator_index'] = '';
             $row['creator'] = '';
         }

lib/midgard/admin/asgard/handler/object/attachments.php

Spacing +3 added lines, -3 removed lines

@@ -98,13 +98,13 @@ 
         }
 
         $mimetype = $request->request->get('midgard_admin_asgard_mimetype');
-        if (   !empty($mimetype)
+        if (!empty($mimetype)
             && $local_file->mimetype != $mimetype) {
             $local_file->mimetype = $mimetype;
             $needs_update = true;
         }
 
-        if (   $needs_update
+        if ($needs_update
             && !$local_file->update()) {
             return null;
         }
@@ -234,7 +234,7 @@ 
         $this->bind_view_to_object($this->_file);
 
         $filename = $this->_process_form($request);
-        if (   $filename
+        if ($filename
             && $filename != $data['filename']) {
             return $this->relocate_to_file($filename);
         }

lib/org/openpsa/slideshow/image.php

Braces +4 added lines, -2 removed lines

@@ -48,7 +48,8 @@ 
 
         try {
             $folder = midcom_db_topic::get_cached($this->topic);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
         }
         $folder->delete_attachment(self::FOLDER_THUMBNAIL);
@@ -58,7 +59,8 @@ 
     {
         try {
             return new midcom_db_attachment($this->$type);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $e->log();
             return null;
         }

lib/org/openpsa/relatedto/plugin.php

Braces +2 added lines, -1 removed lines

@@ -104,7 +104,8 @@
     {
         $ret = ['org_openpsa_relatedto' => []];
         foreach ($array as $rel) {
-            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) { //Matches also 'org_openpsa_relatedto'
+            if (!midcom::get()->dbfactory->is_a($rel, org_openpsa_relatedto_dba::class)) {
+//Matches also 'org_openpsa_relatedto'
                 //Wrong type of object found in array, cruelly abort the whole procedure
                 return null;
             }

lib/midcom/services/indexer/document.php

Spacing +1 added lines, -1 removed lines

@@ -405,7 +405,7 @@
     {
         // Complete fields
         $this->indexed = time();
-        if (   $this->author == ''
+        if ($this->author == ''
             && isset($this->creator->name)) {
             $this->author = $this->creator->name;
         }

Braces +2 added lines, -1 removed lines

@@ -510,7 +510,8 @@
     {
         try {
             return midcom_db_person::get_cached($guid);
-        } catch (midcom_error) {
+        }
+        catch (midcom_error) {
             return null;
         }
     }

lib/org/openpsa/contacts/duplicates/merge.php

Spacing +4 added lines, -4 removed lines

@@ -88,7 +88,7 @@ 
                             $dup = $this->check_duplicate($results, $result, $conf['duplicate_check']);
 
                             if ($dup !== true) {
-                                if (   !is_object($dup)
+                                if (!is_object($dup)
                                     || !array_key_exists($dup->id, $todelete)) {
                                     $todelete[$result->id] = $result;
                                 }
@@ -97,7 +97,7 @@ 
                         }
                     }
                 }
-                if (   $needs_update
+                if ($needs_update
                     && !$result->update()) {
                     throw new midcom_error("Failed to update {$classname} #{$result->id}, errstr: " . midcom_connection::get_error_string());
                 }
@@ -145,7 +145,7 @@ 
         }
 
         foreach ($results as $result) {
-            if (   $result->$field === $object->$field
+            if ($result->$field === $object->$field
                 && $result->id !== $object->id) {
                 return $result;
             }
@@ -163,7 +163,7 @@ 
         $changed = false;
         foreach ($person2 as $property => $value) {
             // Copy only simple properties not marked to be skipped missing from person1
-            if (   !empty($person2->$property)
+            if (!empty($person2->$property)
                 && empty($person1->$property)
                 && !isset($skip_properties[$property])
                 && is_scalar($value)) {