@@ -66,7 +66,8 @@ discard block |
||
| 66 | 66 | try { |
| 67 | 67 | $person1 = new org_openpsa_contacts_person_dba($param->parentguid); |
| 68 | 68 | $person2 = new org_openpsa_contacts_person_dba($param->name); |
| 69 | - } catch (midcom_error $e) { |
|
| 69 | + } |
|
| 70 | + catch (midcom_error $e) { |
|
| 70 | 71 | $i++; |
| 71 | 72 | continue; |
| 72 | 73 | } |
@@ -137,7 +138,8 @@ discard block |
||
| 137 | 138 | try { |
| 138 | 139 | $merger = new org_openpsa_contacts_duplicates_merge('person', $this->_config); |
| 139 | 140 | $merger->merge_delete($person1, $person2); |
| 140 | - } catch (midcom_error $e) { |
|
| 141 | + } |
|
| 142 | + catch (midcom_error $e) { |
|
| 141 | 143 | // TODO: Localize |
| 142 | 144 | midcom::get()->uimessages->add($this->_l10n->get('org.openpsa.contacts'), 'Merge failed, errstr: ' . $e->getMessage(), 'error'); |
| 143 | 145 | } |
@@ -82,7 +82,8 @@ discard block |
||
| 82 | 82 | $file = $this->stat($test); |
| 83 | 83 | $this->clearcache(); |
| 84 | 84 | |
| 85 | - if ($file && $file['name'] === $name) { // file exists and check filename for item ID based filesystem |
|
| 85 | + if ($file && $file['name'] === $name) { |
|
| 86 | +// file exists and check filename for item ID based filesystem |
|
| 86 | 87 | // check POST data `overwrite` for 3rd party uploader |
| 87 | 88 | $overwrite = isset($_POST['overwrite'])? (bool)$_POST['overwrite'] : $this->options['uploadOverwrite']; |
| 88 | 89 | if ($overwrite) { |
@@ -135,11 +136,13 @@ discard block |
||
| 135 | 136 | { |
| 136 | 137 | try { |
| 137 | 138 | return org_openpsa_documents_document_dba::get_cached($path); |
| 138 | - } catch (midcom_error $e) { |
|
| 139 | + } |
|
| 140 | + catch (midcom_error $e) { |
|
| 139 | 141 | $e->log(); |
| 140 | 142 | try { |
| 141 | 143 | return org_openpsa_documents_directory::get_cached($path); |
| 142 | - } catch (midcom_error $e) { |
|
| 144 | + } |
|
| 145 | + catch (midcom_error $e) { |
|
| 143 | 146 | $e->log(); |
| 144 | 147 | } |
| 145 | 148 | } |
@@ -275,7 +278,8 @@ discard block |
||
| 275 | 278 | $object = midcom::get()->dbfactory->get_object_by_guid($path); |
| 276 | 279 | try { |
| 277 | 280 | $parentdir = org_openpsa_documents_directory::get_cached($parent); |
| 278 | - } catch (midcom_error $e) { |
|
| 281 | + } |
|
| 282 | + catch (midcom_error $e) { |
|
| 279 | 283 | $e->log(); |
| 280 | 284 | return false; |
| 281 | 285 | } |
@@ -571,7 +575,8 @@ discard block |
||
| 571 | 575 | try { |
| 572 | 576 | $doc = new org_openpsa_documents_document_dba($path); |
| 573 | 577 | return $doc->delete(); |
| 574 | - } catch (midcom_error $e) { |
|
| 578 | + } |
|
| 579 | + catch (midcom_error $e) { |
|
| 575 | 580 | return false; |
| 576 | 581 | } |
| 577 | 582 | } |
@@ -32,7 +32,8 @@ discard block |
||
| 32 | 32 | } |
| 33 | 33 | try { |
| 34 | 34 | $date = new DateTime($requested_time); |
| 35 | - } catch (Exception $e) { |
|
| 35 | + } |
|
| 36 | + catch (Exception $e) { |
|
| 36 | 37 | return false; |
| 37 | 38 | } |
| 38 | 39 | $offset = $date->format('N') - 1; |
@@ -119,7 +120,8 @@ discard block |
||
| 119 | 120 | foreach ($hours as $guid => $row) { |
| 120 | 121 | try { |
| 121 | 122 | $task = org_openpsa_projects_task_dba::get_cached($row['task']); |
| 122 | - } catch (midcom_error $e) { |
|
| 123 | + } |
|
| 124 | + catch (midcom_error $e) { |
|
| 123 | 125 | // Task couldn't be loaded, probably because of ACL |
| 124 | 126 | continue; |
| 125 | 127 | } |
@@ -132,7 +134,8 @@ discard block |
||
| 132 | 134 | $person_object = org_openpsa_contacts_person_dba::get_cached($row['person']); |
| 133 | 135 | $person_label = $this->_get_list_link($person_object->name, null, null, $row['person']); |
| 134 | 136 | $person_name = $person_object->name; |
| 135 | - } catch (midcom_error $e) { |
|
| 137 | + } |
|
| 138 | + catch (midcom_error $e) { |
|
| 136 | 139 | $person_label = $this->_l10n->get('no person'); |
| 137 | 140 | $person_name = ''; |
| 138 | 141 | } |
@@ -196,7 +196,8 @@ discard block |
||
| 196 | 196 | try { |
| 197 | 197 | $event = new org_openpsa_calendar_event_dba($member->event); |
| 198 | 198 | $set_as_modified = true; |
| 199 | - } catch (midcom_error $e) { |
|
| 199 | + } |
|
| 200 | + catch (midcom_error $e) { |
|
| 200 | 201 | debug_add("event_resource #{$member->id} links ot bogus event #{$member->event}, skipping and removing", MIDCOM_LOG_WARN); |
| 201 | 202 | $member->delete(); |
| 202 | 203 | return; |
@@ -224,7 +225,8 @@ discard block |
||
| 224 | 225 | |
| 225 | 226 | try { |
| 226 | 227 | $event = new org_openpsa_calendar_event_dba($member->eid); |
| 227 | - } catch (midcom_error $e) { |
|
| 228 | + } |
|
| 229 | + catch (midcom_error $e) { |
|
| 228 | 230 | debug_add("eventmember #{$member->id} links to bogus event #{$member->eid}, skipping and removing", MIDCOM_LOG_WARN); |
| 229 | 231 | $member->delete(); |
| 230 | 232 | return; |
@@ -380,7 +380,8 @@ discard block |
||
| 380 | 380 | try { |
| 381 | 381 | $cmd = midcom::get()->config->get('utility_imagemagick_base') . "identify " . escapeshellarg($filename); |
| 382 | 382 | $this->_run_command($cmd); |
| 383 | - } catch (midcom_error $e) { |
|
| 383 | + } |
|
| 384 | + catch (midcom_error $e) { |
|
| 384 | 385 | return false; |
| 385 | 386 | } |
| 386 | 387 | return true; |
@@ -406,7 +407,8 @@ discard block |
||
| 406 | 407 | debug_add("EXIF information missing or without orientation tag. Skipping.", MIDCOM_LOG_INFO); |
| 407 | 408 | return; |
| 408 | 409 | } |
| 409 | - } catch (Exception $e) { |
|
| 410 | + } |
|
| 411 | + catch (Exception $e) { |
|
| 410 | 412 | debug_add("Could not read EXIF data: " . $e->getMessage() . ", skipping.", MIDCOM_LOG_WARN); |
| 411 | 413 | return; |
| 412 | 414 | } |
@@ -44,7 +44,8 @@ discard block |
||
| 44 | 44 | { |
| 45 | 45 | try { |
| 46 | 46 | $tmp = midgard_object_class::get_object_by_guid($guid); |
| 47 | - } catch (midgard_error_exception $e) { |
|
| 47 | + } |
|
| 48 | + catch (midgard_error_exception $e) { |
|
| 48 | 49 | debug_add('Loading object by GUID ' . $guid . ' failed, reason: ' . $e->getMessage(), MIDCOM_LOG_INFO); |
| 49 | 50 | |
| 50 | 51 | throw new midcom_error_midgard($e, $guid); |
@@ -274,7 +275,8 @@ discard block |
||
| 274 | 275 | $parent_data = array( |
| 275 | 276 | $parent->__midcom_class_name__ => $parent_guid |
| 276 | 277 | ); |
| 277 | - } catch (midcom_error $e) { |
|
| 278 | + } |
|
| 279 | + catch (midcom_error $e) { |
|
| 278 | 280 | $parent_data = array( |
| 279 | 281 | '' => null |
| 280 | 282 | ); |
@@ -288,7 +290,8 @@ discard block |
||
| 288 | 290 | |
| 289 | 291 | try { |
| 290 | 292 | return $this->get_cached($classname, $parent_guid); |
| 291 | - } catch (midcom_error $e) { |
|
| 293 | + } |
|
| 294 | + catch (midcom_error $e) { |
|
| 292 | 295 | return null; |
| 293 | 296 | } |
| 294 | 297 | } |
@@ -347,7 +350,8 @@ discard block |
||
| 347 | 350 | if ($the_object === null) { |
| 348 | 351 | try { |
| 349 | 352 | $the_object = $this->get_object_by_guid($object_guid); |
| 350 | - } catch (midcom_error $e) { |
|
| 353 | + } |
|
| 354 | + catch (midcom_error $e) { |
|
| 351 | 355 | return array('' => null); |
| 352 | 356 | } |
| 353 | 357 | } |
@@ -737,7 +737,8 @@ |
||
| 737 | 737 | $iterator = new RecursiveIteratorIterator($dir); |
| 738 | 738 | // ignore backup files |
| 739 | 739 | return new RegexIterator($iterator, '/[^~]$/i'); |
| 740 | - } catch (UnexpectedValueException $e) { |
|
| 740 | + } |
|
| 741 | + catch (UnexpectedValueException $e) { |
|
| 741 | 742 | debug_add("failed to create iterator:" . $e->getMessage(), MIDCOM_LOG_ERROR); |
| 742 | 743 | return array(); |
| 743 | 744 | } |
@@ -364,7 +364,8 @@ discard block |
||
| 364 | 364 | $filter = new midcom_helper_imagefilter($this->attachments[$identifier]); |
| 365 | 365 | try { |
| 366 | 366 | $filter->process_chain($filterchain); |
| 367 | - } catch (midcom_error $e) { |
|
| 367 | + } |
|
| 368 | + catch (midcom_error $e) { |
|
| 368 | 369 | midcom::get()->uimessages->add('midcom.helper.imagefilter', $e->getMessage(), 'error'); |
| 369 | 370 | $e->log(); |
| 370 | 371 | return false; |
@@ -529,7 +530,8 @@ discard block |
||
| 529 | 530 | if ($filter_chain) { |
| 530 | 531 | try { |
| 531 | 532 | $this->_filter->process_chain($filter_chain); |
| 532 | - } catch (midcom_error $e) { |
|
| 533 | + } |
|
| 534 | + catch (midcom_error $e) { |
|
| 533 | 535 | midcom::get()->uimessages->add('midcom.helper.imagefilter', $e->getMessage(), 'error'); |
| 534 | 536 | $e->log(); |
| 535 | 537 | return false; |
@@ -620,7 +622,8 @@ discard block |
||
| 620 | 622 | |
| 621 | 623 | try { |
| 622 | 624 | $this->_filter->convert($conversion); |
| 623 | - } catch (midcom_error $e) { |
|
| 625 | + } |
|
| 626 | + catch (midcom_error $e) { |
|
| 624 | 627 | $e->log(); |
| 625 | 628 | return false; |
| 626 | 629 | } |
@@ -240,7 +240,8 @@ discard block |
||
| 240 | 240 | // Not a MidCOM DBA object |
| 241 | 241 | try { |
| 242 | 242 | $obj = midcom::get()->dbfactory->convert_midgard_to_midcom($object); |
| 243 | - } catch (midcom_error $e) { |
|
| 243 | + } |
|
| 244 | + catch (midcom_error $e) { |
|
| 244 | 245 | return false; |
| 245 | 246 | } |
| 246 | 247 | } else { |
@@ -705,7 +706,8 @@ discard block |
||
| 705 | 706 | } |
| 706 | 707 | try { |
| 707 | 708 | self::$_cache['name'][$key] = self::get($object)->get_name_property_nonstatic($object); |
| 708 | - } catch (midcom_error $e) { |
|
| 709 | + } |
|
| 710 | + catch (midcom_error $e) { |
|
| 709 | 711 | debug_add('Could not get reflector instance for class ' . $key . ': ' . $e->getMessage(), MIDCOM_LOG_ERROR); |
| 710 | 712 | self::$_cache['name'][$key] = null; |
| 711 | 713 | } |