flack / openpsa

lib/midgard/admin/asgard/handler/welcome.php

Braces +4 added lines, -2 removed lines

@@ -196,7 +196,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
 
@@ -211,7 +212,8 @@ 
         foreach ($guids as $guid) {
             try {
                 $object = midcom::get()->dbfactory->get_object_by_guid($guid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 continue;
             }
 

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
                 $qb = new midcom_core_querybuilder($midcom_dba_classname);
                 $qb->add_constraint('metadata.revised', '>=', $since);
 
-                if (   $only_mine
+                if ($only_mine
                     && midcom::get()->auth->user) {
                     $qb->add_constraint('metadata.authors', 'LIKE', '|' . midcom::get()->auth->user->guid . '|');
                 }
@@ -198,7 +198,7 @@ 
                 continue;
             }
 
-            if (   $object->can_do('midgard:update')
+            if ($object->can_do('midgard:update')
                 && $object->can_do('midcom:approve')) {
                 $object->metadata->approve();
                 midcom::get()->uimessages->add($this->_l10n->get('midgard.admin.asgard'), sprintf($this->_l10n->get('object %s approved'), $object->guid));

src/midcom/console/command/repligard.php

Braces +2 added lines, -1 removed lines

@@ -40,7 +40,8 @@
     {
         try {
             $this->db = connection::get_em()->getConnection()->getWrappedConnection();
-        } catch (\Exception $e) {
+        }
+        catch (\Exception $e) {
             $this->db = $this->create_connection($input, $output);
         }
 

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
     private function _confirm(InputInterface $input, OutputInterface $output, string $question) : bool
     {
         $options = [true => 'y', false => 'N'];
-        $question = '<question>' . $question . ' [' . implode('|', $options). ']</question> ';
+        $question = '<question>' . $question . ' [' . implode('|', $options) . ']</question> ';
         $question = new ConfirmationQuestion($question, false);
         $dialog = $this->getHelperSet()->get('question');
         return $dialog->ask($input, $output, $question);

lib/org/openpsa/sales/style/show-deliverable.php

Spacing +3 added lines, -3 removed lines

@@ -3,7 +3,7 @@ 
 $state = $data['deliverable']->get_state();
 $formatter = $data['l10n']->get_formatter();
 $per_unit = $data['l10n']->get('per unit');
-if (   $data['product']
+if ($data['product']
     && $unit_option = org_openpsa_sales_viewer::get_unit_option($data['product']->unit)) {
     $per_unit = sprintf($data['l10n']->get('per %s'), $unit_option);
 }
@@ -115,7 +115,7 @@ 
 	    </div>
      <?php
     $tabs = [];
-    if (   $data['invoices_url']
+    if ($data['invoices_url']
         && $data['deliverable']->invoiced > 0) {
         $tabs[] = [
             'url' => $data['invoices_url'] . "list/deliverable/{$data['deliverable']->guid}/",
@@ -123,7 +123,7 @@ 
         ];
     }
 
-    if (   $data['projects_url']
+    if ($data['projects_url']
         && $data['deliverable']->state >= org_openpsa_sales_salesproject_deliverable_dba::STATE_ORDERED
         && $data['product']
         && $data['product']->orgOpenpsaObtype == org_openpsa_products_product_dba::TYPE_SERVICE) {

Indentation +3 added lines, -3 removed lines

@@ -65,17 +65,17 @@
                         <tr>
                           <td class="title"><?php echo $data['l10n']->get('cost'); ?></td>
                           <?php
-                          if ($data['deliverable']->costType == '%') { ?>
+                            if ($data['deliverable']->costType == '%') { ?>
                               <td class="numeric"><?php echo $view['costPerUnit']; ?> %</td>
                               <td class="numeric">&nbsp;</td>
                               <td class="numeric">&nbsp;</td>
                           <?php
-                          } else { ?>
+                            } else { ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->costPerUnit); ?></td>
                               <td class="numeric"><?php echo $view['plannedUnits']; ?></td>
                               <td class="numeric"><?php echo $view['units']; ?></td>
                           <?php
-                          } ?>
+                            } ?>
                               <td class="numeric"><?php echo $formatter->number($data['deliverable']->cost); ?></td>
                         </tr>
                       </tbody>

lib/org/openpsa/sales/style/show-offers.php

Indentation +22 added lines, -22 removed lines

@@ -5,29 +5,29 @@
     ?>
     <div class="area org_openpsa_helper_box"><h3><?php echo $data['l10n']->get('offers'); ?></h3>
     	<ul><?php
-         foreach ($data['offers'] as $offer) {
-             echo '<li><span class="org_openpsa_helpers_fileinfo">';
-             $attachment = $offer->get_file();
-             $delete_link = $data['router']->generate('delete_offer', ['guid' => $offer->guid]);
-             $edit_link = $data['router']->generate('edit_offer', ['guid' => $offer->guid]);
+            foreach ($data['offers'] as $offer) {
+                echo '<li><span class="org_openpsa_helpers_fileinfo">';
+                $attachment = $offer->get_file();
+                $delete_link = $data['router']->generate('delete_offer', ['guid' => $offer->guid]);
+                $edit_link = $data['router']->generate('edit_offer', ['guid' => $offer->guid]);
 
-             if (!empty($attachment)) {
-                 $url = midcom_db_attachment::get_url($attachment);
-                 echo '<a href="' . $url . '" class="icon"><i class="fa fa-file-text-o"></i></a>';
-             }
-             echo '<span class="info">';
-             echo '<span class="filename">' . $offer->get_label();
-             echo ' <a class="actions" href="' . $delete_link . '"><i class="fa fa-trash" title="' . $data['l10n_midcom']->get('delete') . '"></i></a>';
-             echo ' <a class="actions" ' . $wf->render_attributes() . ' href="' . $edit_link . '"><i class="fa fa-pencil" title="' . $data['l10n_midcom']->get('edit') . '"></i></a>';
-             echo "</span>\n";
-             if (!empty($attachment)) {
-                 echo ' <span class="date">' . $formatter->datetime($attachment->metadata->revised) . '</span> ';
-                 $person_card = org_openpsa_widgets_contact::get($attachment->metadata->revisor);
-                 echo $person_card->show_inline();
-             }
-             echo "</span></span></li>\n";
-         }
-         ?>
+                if (!empty($attachment)) {
+                    $url = midcom_db_attachment::get_url($attachment);
+                    echo '<a href="' . $url . '" class="icon"><i class="fa fa-file-text-o"></i></a>';
+                }
+                echo '<span class="info">';
+                echo '<span class="filename">' . $offer->get_label();
+                echo ' <a class="actions" href="' . $delete_link . '"><i class="fa fa-trash" title="' . $data['l10n_midcom']->get('delete') . '"></i></a>';
+                echo ' <a class="actions" ' . $wf->render_attributes() . ' href="' . $edit_link . '"><i class="fa fa-pencil" title="' . $data['l10n_midcom']->get('edit') . '"></i></a>';
+                echo "</span>\n";
+                if (!empty($attachment)) {
+                    echo ' <span class="date">' . $formatter->datetime($attachment->metadata->revised) . '</span> ';
+                    $person_card = org_openpsa_widgets_contact::get($attachment->metadata->revisor);
+                    echo $person_card->show_inline();
+                }
+                echo "</span></span></li>\n";
+            }
+            ?>
      </ul>
     </div>
 <?php  } ?>
\ No newline at end of file

lib/net/nemein/wiki/resolver.php

Spacing +2 added lines, -2 removed lines

@@ -158,7 +158,7 @@ 
             $localpath = $path;
             $matches['latest_parent'] = $folder_tree['/'];
             $missing_levels = 0;
-            while (   $localpath
+            while ($localpath
                    && $localpath != '/') {
                 $localpath = dirname($localpath);
                 $missing_levels++;
@@ -185,7 +185,7 @@ 
 
         $root_folder = $folder;
         $max = 100;
-        while (   $folder[MIDCOM_NAV_COMPONENT] == 'net.nemein.wiki'
+        while ($folder[MIDCOM_NAV_COMPONENT] == 'net.nemein.wiki'
                && (($parent = $nap->get_node_uplink($folder[MIDCOM_NAV_ID])) != -1)
                && $max > 0) {
             $root_folder = $folder;

lib/org/openpsa/projects/project.php

Spacing +1 added lines, -1 removed lines

@@ -249,7 +249,7 @@
             $new_status = $this->_find_status($this->_status_map[$this->status_type], $status_types);
         }
 
-        if (   $new_status !== null
+        if ($new_status !== null
             && $this->status != $new_status) {
             $this->status = $new_status;
             $update_required = true;

lib/org/openpsa/contacts/handler/person/view.php

Spacing +3 added lines, -3 removed lines

@@ -117,7 +117,7 @@ 
         $invoices_url = $siteconfig->get_node_full_url('org.openpsa.invoices');
         $user_url = $siteconfig->get_node_full_url('org.openpsa.user');
 
-        if (   $invoices_url
+        if ($invoices_url
             && midcom::get()->auth->can_user_do('midgard:create', null, org_openpsa_invoices_invoice_dba::class)
             && $this->_contact->can_do('midgard:update')) {
             $buttons[] = $workflow->get_button($invoices_url . "billingdata/" . $this->_contact->guid . '/', [
@@ -126,8 +126,8 @@ 
             ]);
         }
 
-        if (   $user_url
-            && (   midcom_connection::get_user() == $this->_contact->id
+        if ($user_url
+            && (midcom_connection::get_user() == $this->_contact->id
                 || midcom::get()->auth->can_user_do('org.openpsa.user:access', null, org_openpsa_user_interface::class))) {
             $buttons[] = [
                 MIDCOM_TOOLBAR_URL => $user_url . "view/{$this->_contact->guid}/",

Braces +2 added lines, -1 removed lines

@@ -192,7 +192,8 @@
         foreach ($this->$identifier as $member) {
             try {
                 $this->_request_data['group'] = org_openpsa_contacts_group_dba::get_cached($member->gid);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $e->log();
                 continue;
             }

lib/org/openpsa/products/handler/product/view.php

Braces +2 added lines, -1 removed lines

@@ -83,7 +83,8 @@
                 $productgroup = new org_openpsa_products_product_group_dba($this->_product->productGroup);
                 $replacements['<PRODUCTGROUP_TITLE>'] = $productgroup->title;
                 $replacements['<PRODUCTGROUP_CODE>'] = $productgroup->code;
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 $replacements['<PRODUCTGROUP_TITLE>'] = '';
                 $replacements['<PRODUCTGROUP_CODE>'] = '';
             }

lib/midcom/baseclasses/components/handler/dataexport.php

Spacing +5 added lines, -5 removed lines

@@ -127,7 +127,7 @@ 
         foreach ($this->_datamanagers as $type => $datamanager) {
             foreach ($datamanager->get_schema($this->schemas[$type])->get('fields') as $name => $config) {
                 $title = $config['title'];
-                if (   $this->include_totals
+                if ($this->include_totals
                     && $config['type'] == 'number') {
                     $this->_totals[$type . '-' . $name] = 0;
                 }
@@ -194,18 +194,18 @@ 
                     $data = array_pad($data, $target_size, '');
                     continue;
                 }
-                $object =& $row[$type];
+                $object = & $row[$type];
 
                 $datamanager->set_storage($object, $this->schemas[$type]);
 
-                if (   $this->include_guid
+                if ($this->include_guid
                     && $type == $first_type) {
                     $data[] = $object->guid;
                 }
 
                 $csvdata = $datamanager->get_content_csv();
                 foreach ($datamanager->get_schema()->get('fields') as $fieldname => $config) {
-                    if (   $this->include_totals
+                    if ($this->include_totals
                         && $config['type'] == 'number') {
                         $this->_totals[$type . '-' . $fieldname] += $csvdata[$fieldname];
                     }
@@ -233,7 +233,7 @@ 
         if (empty($this->csv['charset'])) {
             // Default to ISO-LATIN-15 (Latin-1 with EURO sign etc)
             $this->csv['charset'] = 'ISO-8859-15';
-            if (   isset($_SERVER['HTTP_USER_AGENT'])
+            if (isset($_SERVER['HTTP_USER_AGENT'])
                 && !preg_match('/Windows/i', $_SERVER['HTTP_USER_AGENT'])) {
                 // Except when not on windows, then default to UTF-8
                 $this->csv['charset'] = 'UTF-8';