flack / openpsa

lib/org/openpsa/invoices/style/admin-read.php

Braces +2 added lines, -1 removed lines

@@ -8,7 +8,8 @@
     if ($customer->orgOpenpsaObtype <= org_openpsa_contacts_group_dba::MYCONTACTS) {
         $customer = false;
     }
-} catch (midcom_error $e) {
+}
+catch (midcom_error $e) {
     $customer = false;
 }
 

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         <div class="value"><?php echo $formatter->date($invoice->deliverydate); ?></div></div>
     <?php } ?>
 
-    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description');?>: </div>
+    <div class="field"><div class="title"><?php echo $data['l10n_midcom']->get('description'); ?>: </div>
     <div class="description value">&(view['description']:h);</div></div>
 
     <?php

lib/org/openpsa/core/siteconfig.php

Spacing +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
         }
         if (!midcom::get()->auth->admin) {
             $user_id = midcom::get()->auth->acl->get_user_id();
-            if (   !$this->data[$type . '_guid']
+            if (!$this->data[$type . '_guid']
                 || !midcom::get()->auth->acl->can_do_byguid('midgard:read', $this->data[$type . '_guid'], midcom_db_topic::class, $user_id)) {
                 return null;
             }

lib/org/openpsa/widgets/ui.php

Spacing +3 added lines, -3 removed lines

@@ -39,8 +39,8 @@ 
             $config = array_merge($defaults, $config);
 
             $node_url = $siteconfig->get_node_full_url($component);
-            if (   $node_url
-                && (   !$user_id
+            if ($node_url
+                && (!$user_id
                     || midcom::get()->auth->acl->can_do_byguid('midgard:read', $siteconfig->get_node_guid($component), midcom_db_topic::class, $user_id))) {
                 $providers[] = [
                     'placeholder' => midcom::get()->i18n->get_string('search title', $component),
@@ -115,7 +115,7 @@ 
         echo '<div id="tabs">';
         echo "\n<ul>\n";
         foreach ($tabdata as $key => $tab) {
-            echo "<li><a id='key_" . $key ."' class='tabs_link' href='" . $prefix . $tab['url'] . "' ><span> " . $tab['title'] . "</span></a></li>";
+            echo "<li><a id='key_" . $key . "' class='tabs_link' href='" . $prefix . $tab['url'] . "' ><span> " . $tab['title'] . "</span></a></li>";
         }
         echo "\n</ul>\n";
         echo "</div>\n";

Indentation +4 added lines, -4 removed lines

@@ -103,12 +103,12 @@
         if (!empty($guid)) {
             //pass the urls & titles for the tabs
             $tabdata[] = [
-               'url' => '__mfa/org.openpsa.relatedto/journalentry/' . $guid . '/',
-               'title' => midcom::get()->i18n->get_string('journal entries', 'org.openpsa.relatedto'),
+                'url' => '__mfa/org.openpsa.relatedto/journalentry/' . $guid . '/',
+                'title' => midcom::get()->i18n->get_string('journal entries', 'org.openpsa.relatedto'),
             ];
             $tabdata[] = [
-               'url' => '__mfa/org.openpsa.relatedto/render/' . $guid . '/both/',
-               'title' => midcom::get()->i18n->get_string('related objects', 'org.openpsa.relatedto'),
+                'url' => '__mfa/org.openpsa.relatedto/render/' . $guid . '/both/',
+                'title' => midcom::get()->i18n->get_string('related objects', 'org.openpsa.relatedto'),
             ];
         }
 

lib/org/openpsa/directmarketing/midcom/interfaces.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
     public function _on_watched_dba_delete(midcom_core_dbaobject $object)
     {
         $qb = org_openpsa_directmarketing_campaign_member_dba::new_query_builder();
-        if (   $object instanceof midcom_db_person
+        if ($object instanceof midcom_db_person
             || $object instanceof org_openpsa_contacts_person_dba) {
             $qb->add_constraint('person', '=', $object->id);
         } elseif ($object instanceof org_openpsa_directmarketing_campaign_dba) {
@@ -42,7 +42,7 @@ 
      */
     public function background_send_message(array $args, midcom_baseclasses_components_cron_handler $handler)
     {
-        if (   !isset($args['url_base'])
+        if (!isset($args['url_base'])
             || !isset($args['batch'])) {
             $handler->print_error('url_base or batch number not set, aborting');
             return false;

Braces +4 added lines, -2 removed lines

@@ -56,7 +56,8 @@ 
         try {
             midcom::get()->dynamic_load($batch_url);
             $ret = true;
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $ret = $e->getMessage();
         }
         ob_end_clean();
@@ -83,7 +84,8 @@ 
         $stat = true;
         try {
             $campaign = new org_openpsa_directmarketing_campaign_dba($args['campaign_guid']);
-        } catch (midcom_error $e) {
+        }
+        catch (midcom_error $e) {
             $handler->print_error("{$args['campaign_guid']} is not a valid campaign GUID");
             $stat = false;
         }

lib/org/openpsa/products/viewer.php

Spacing +3 added lines, -3 removed lines

@@ -32,11 +32,11 @@
         $object = $dm->get_storage()->get_value();
 
         $document = $indexer->new_document($dm);
-        if (   $config->get('enable_scheduling')
+        if ($config->get('enable_scheduling')
             && is_a($object, org_openpsa_products_product_dba::class)) {
             // Check start/end for products
-            if (   $object->start > time()
-                || (   $object->end != 0
+            if ($object->start > time()
+                || ($object->end != 0
                     && $object->end < time())) {
                 // Not in market, remove from index
                 $indexer->delete($document->RI);

lib/org/openpsa/reports/viewer.php

Braces +2 added lines, -1 removed lines

@@ -103,7 +103,8 @@
             try {
                 midcom_db_topic::get_cached($node_guid);
                 $available_generators[$component] = midcom::get()->i18n->get_string($component, $component);
-            } catch (midcom_error $e) {
+            }
+            catch (midcom_error $e) {
                 debug_add("topic for component '{$component}' not found or accessible");
             }
         }

lib/net/nehmer/comments/handler.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
     {
         $toolbar = new midcom_helper_toolbar();
         $buttons = [];
-        if (   midcom::get()->auth->user
+        if (midcom::get()->auth->user
             && $comment->status < net_nehmer_comments_comment::MODERATED) {
             if (!$comment->can_do('net.nehmer.comments:moderation')) {
                 // Regular users can only report abuse

lib/net/nemein/wiki/handler/create.php

Braces +2 added lines, -1 removed lines

@@ -76,7 +76,8 @@
             } else {
                 try {
                     $this->initialize_index_article($topic);
-                } catch (midcom_error $e) {
+                }
+                catch (midcom_error $e) {
                     // Could not create index
                     $topic->delete();
                     throw $e;

lib/org/openpsa/contacts/handler.php

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
         $prefix = $nap->get_node($this->_topic->id)[MIDCOM_NAV_ABSOLUTEURL];
 
         $tree = new org_openpsa_widgets_tree(org_openpsa_contacts_group_dba::class, 'owner');
-        $tree->link_callback = function ($guid) use ($prefix) {
+        $tree->link_callback = function($guid) use ($prefix) {
             return $prefix . 'group/' . $guid . '/';
         };
         $tree->constraints[] = ['orgOpenpsaObtype', '<', org_openpsa_contacts_group_dba::MYCONTACTS];
@@ -52,7 +52,7 @@ 
     {
         $my_company_guid = $this->_config->get('owner_organization');
 
-        if (   empty($my_company_guid)
+        if (empty($my_company_guid)
             || !mgd_is_guid($my_company_guid)) {
             if (midcom::get()->auth->admin) {
                 midcom::get()->uimessages->add(