SearchController::search() - Code Metrics - Inspection of "Merge branch 'release/4.6.10'" - firefly-iii/firefly-iii - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 869845...9ac565 )

by James

created 2017-11-03 06:27 UTC

SearchController::search() B

↳ Parent: Project

Complexity

Conditions	3
Paths	4

Size

Total Lines	27
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	27
rs	8.8571
c	0
b	0
f	0
cc	3
eloc	14
nc	4
nop	2

<?php
/**
 * SearchController.php
 * Copyright (c) 2017 [email protected]
 *
 * This file is part of Firefly III.
 *
 * Firefly III is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Firefly III is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Firefly III.  If not, see <http://www.gnu.org/licenses/>.
 */

declare(strict_types=1);

namespace FireflyIII\Http\Controllers;

use FireflyIII\Support\CacheProperties;
use FireflyIII\Support\Search\SearchInterface;
use Illuminate\Http\Request;
use Response;
use View;

/**
 * Class SearchController
 *
 * @package FireflyIII\Http\Controllers
 */
class SearchController extends Controller
{
    /**
     * SearchController constructor.
     */
    public function __construct()
    {
        parent::__construct();

        $this->middleware(
            function ($request, $next) {
                View::share('mainTitleIcon', 'fa-search');
                View::share('title', trans('firefly.search'));

                return $next($request);
            }
        );

    }

    /**
     * @param Request         $request
     * @param SearchInterface $searcher
     *
     * @return View
     */
    public function index(Request $request, SearchInterface $searcher)
    {
        $fullQuery = strval($request->get('q'));

        // parse search terms:
        $searcher->parseQuery($fullQuery);
        $query    = $searcher->getWordsAsString();
        $subTitle = trans('breadcrumbs.search_result', ['query' => $query]);

        return view('search.index', compact('query', 'fullQuery', 'subTitle'));
    }

    public function search(Request $request, SearchInterface $searcher)
    {
        $fullQuery = strval($request->get('query'));

        // cache
        $cache = new CacheProperties;
        $cache->addProperty('search');
        $cache->addProperty($fullQuery);

        if ($cache->has()) {
            $transactions = $cache->get();
        }

        if (!$cache->has()) {
            // parse search terms:
            $searcher->parseQuery($fullQuery);
            $searcher->setLimit(intval(env('SEARCH_RESULT_LIMIT', 50)));
            $transactions = $searcher->searchTransactions();
            $cache->store($transactions);
        }

        $html = view('search.search', compact('transactions'))->render();

        return Response::json(['count' => $transactions->count(), 'html' => $html]);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}


    }

}


GitHub Access Token became invalid

Push — master ( 869845...9ac565 )

SearchController::search() B

Complexity

Size

Duplication

Importance

Available Fixes

1			<?php
2			/**
3			* SearchController.php
4			* Copyright (c) 2017 [email protected]
5			*
6			* This file is part of Firefly III.
7			*
8			* Firefly III is free software: you can redistribute it and/or modify
9			* it under the terms of the GNU General Public License as published by
10			* the Free Software Foundation, either version 3 of the License, or
11			* (at your option) any later version.
12			*
13			* Firefly III is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			* GNU General Public License for more details.
17			*
18			* You should have received a copy of the GNU General Public License
19			* along with Firefly III. If not, see <http://www.gnu.org/licenses/>.
20			*/
21
22			declare(strict_types=1);
23
24			namespace FireflyIII\Http\Controllers;
25
26			use FireflyIII\Support\CacheProperties;
27			use FireflyIII\Support\Search\SearchInterface;
28			use Illuminate\Http\Request;
29			use Response;
30			use View;
31
32			/**
33			* Class SearchController
34			*
35			* @package FireflyIII\Http\Controllers
36			*/
37			class SearchController extends Controller
38			{
39			/**
40			* SearchController constructor.
41			*/
42			public function __construct()
43			{
44			parent::__construct();
45
46			$this->middleware(
47			function ($request, $next) {
48			View::share('mainTitleIcon', 'fa-search');
49			View::share('title', trans('firefly.search'));
50
51			return $next($request);
52			}
53			);
54
55			}
56
57			/**
58			* @param Request $request
59			* @param SearchInterface $searcher
60			*
61			* @return View
62			*/
63			public function index(Request $request, SearchInterface $searcher)
64			{
65			$fullQuery = strval($request->get('q'));
66
67			// parse search terms:
68			$searcher->parseQuery($fullQuery);
69			$query = $searcher->getWordsAsString();
70			$subTitle = trans('breadcrumbs.search_result', ['query' => $query]);
71
72			return view('search.index', compact('query', 'fullQuery', 'subTitle'));
73			}
74
75			public function search(Request $request, SearchInterface $searcher)
76			{
77			$fullQuery = strval($request->get('query'));
78
79			// cache
80			$cache = new CacheProperties;
81			$cache->addProperty('search');
82			$cache->addProperty($fullQuery);
83
84			if ($cache->has()) {
85			$transactions = $cache->get();
86			}
87
88			if (!$cache->has()) {
89			// parse search terms:
90			$searcher->parseQuery($fullQuery);
91			$searcher->setLimit(intval(env('SEARCH_RESULT_LIMIT', 50)));
92			$transactions = $searcher->searchTransactions();
93			$cache->store($transactions);
94			}
95
96			$html = view('search.search', compact('transactions'))->render();
97
98			return Response::json(['count' => $transactions->count(), 'html' => $html]);
			0 ignored issues – show Bug introduced 2017-10-26 18:03 UTC by Report Bug Copy Issue Report The variable `$transactions` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
99
100
101			}
102
103			}
104

firefly-iii / firefly-iii

GitHub Access Token became invalid

Push — master ( 869845...9ac565 )

SearchController::search() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like