ezsystems / ezpublish-kernel

eZ/Publish/Core/Persistence/Legacy/Content/Handler.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 
 use Exception;
 use eZ\Publish\Core\Persistence\Legacy\Content\Location\Gateway as LocationGateway;
-use eZ\Publish\SPI\Persistence\Content\Field;
 use eZ\Publish\SPI\Persistence\Content\Handler as BaseContentHandler;
 use eZ\Publish\SPI\Persistence\Content\Type\Handler as ContentTypeHandler;
 use eZ\Publish\Core\Persistence\Legacy\Content\UrlAlias\SlugConverter;

Doc Comments +9 added lines, -9 removed lines

@@ -150,7 +150,7 @@ 
      * Will contain always a complete list of fields.
      *
      * @param \eZ\Publish\SPI\Persistence\Content\CreateStruct $struct Content creation struct.
-     * @param mixed $versionNo Used by self::copy() to maintain version numbers
+     * @param integer $versionNo Used by self::copy() to maintain version numbers
      *
      * @return \eZ\Publish\SPI\Persistence\Content Content value object
      */
@@ -437,7 +437,7 @@ 
     /**
      * Returns the metadata object for a content identified by $remoteId.
      *
-     * @param mixed $remoteId
+     * @param string $remoteId
      *
      * @return \eZ\Publish\SPI\Persistence\Content\ContentInfo
      */
@@ -634,7 +634,7 @@ 
      *
      * @param int $contentId
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteContent($contentId)
     {
@@ -666,7 +666,7 @@ 
      * @param int $contentId
      * @param int $versionNo
      *
-     * @return bool
+     * @return boolean|null
      */
     public function deleteVersion($contentId, $versionNo)
     {
@@ -704,8 +704,8 @@ 
      *
      * @throws \eZ\Publish\API\Repository\Exceptions\NotFoundException If content or version is not found
      *
-     * @param mixed $contentId
-     * @param mixed|null $versionNo Copy all versions if left null
+     * @param integer $contentId
+     * @param integer $versionNo Copy all versions if left null
      * @param int|null $newOwnerId
      *
      * @return \eZ\Publish\SPI\Persistence\Content
@@ -793,7 +793,7 @@ 
      *
      * @todo Should the existence verifications happen here or is this supposed to be handled at a higher level?
      *
-     * @param mixed $relationId
+     * @param integer $relationId
      * @param int $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,
@@ -807,7 +807,7 @@ 
     /**
      * Loads relations from $sourceContentId. Optionally, loads only those with $type and $sourceContentVersionNo.
      *
-     * @param mixed $sourceContentId Source Content ID
+     * @param integer $sourceContentId Source Content ID
      * @param mixed|null $sourceContentVersionNo Source Content Version, null if not specified
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
@@ -836,7 +836,7 @@ 
      *
      * Only loads relations against published versions.
      *
-     * @param mixed $destinationContentId Destination Content ID
+     * @param integer $destinationContentId Destination Content ID
      * @param int|null $type {@see \eZ\Publish\API\Repository\Values\Content\Relation::COMMON,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::EMBED,
      *                 \eZ\Publish\API\Repository\Values\Content\Relation::LINK,

eZ/Publish/Core/IO/Tests/IOServiceTest.php

Doc Comments +2 added lines, -1 removed lines

@@ -422,8 +422,9 @@
      * Asserts that the given $ioCreateStruct is of the right type and that id matches the expected value.
      *
      * @param $ioCreateStruct
+     * @param string $spiId
      *
-     * @return bool
+     * @return \Closure
      */
     private function getSPIBinaryFileCreateStructCallback($spiId)
     {

eZ/Publish/Core/Persistence/Legacy/Tests/Content/Language/CachingLanguageHandlerTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -291,7 +291,7 @@ 
     /**
      * Returns a mock for the in-memory cache.
      *
-     * @return \eZ\Publish\Core\Persistence\Cache\InMemory\InMemoryCache|\PHPUnit\Framework\MockObject\MockObject
+     * @return InMemoryCache
      */
     protected function getLanguageCacheMock()
     {
@@ -305,7 +305,7 @@ 
     /**
      * Returns an array with 2 languages.
      *
-     * @return \eZ\Publish\SPI\Persistence\Content\Language[]
+     * @return Language[]
      */
     protected function getLanguagesFixture()
     {

eZ/Publish/Core/Persistence/Legacy/Tests/Content/Type/ContentUpdater/Action/AddFieldTest.php

Doc Comments +5 added lines, -5 removed lines

@@ -499,7 +499,7 @@ 
      * Returns a Content fixture.
      *
      * @param int $versionNo
-     * @param array $languageCodes
+     * @param string[] $languageCodes
      *
      * @return \eZ\Publish\SPI\Persistence\Content
      */
@@ -527,7 +527,7 @@ 
     /**
      * Returns a Content Gateway mock.
      *
-     * @return \PHPUnit\Framework\MockObject\MockObject|\eZ\Publish\Core\Persistence\Legacy\Content\Gateway
+     * @return Gateway
      */
     protected function getContentGatewayMock()
     {
@@ -541,7 +541,7 @@ 
     /**
      * Returns a FieldValue converter mock.
      *
-     * @return \PHPUnit\Framework\MockObject\MockObject|\eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter
+     * @return Converter
      */
     protected function getFieldValueConverterMock()
     {
@@ -555,7 +555,7 @@ 
     /**
      * Returns a Content StorageHandler mock.
      *
-     * @return \PHPUnit\Framework\MockObject\MockObject|\eZ\Publish\Core\Persistence\Legacy\Content\StorageHandler
+     * @return StorageHandler
      */
     protected function getContentStorageHandlerMock()
     {
@@ -569,7 +569,7 @@ 
     /**
      * Returns a Content mapper mock.
      *
-     * @return \PHPUnit\Framework\MockObject\MockObject|\eZ\Publish\Core\Persistence\Legacy\Content\Mapper
+     * @return ContentMapper
      */
     protected function getContentMapperMock()
     {

eZ/Publish/Core/Persistence/Legacy/Tests/TransactionHandlerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -165,7 +165,7 @@
     /**
      * Returns a mock object for the Content Gateway.
      *
-     * @return \eZ\Publish\Core\Persistence\Database\DatabaseHandler|\PHPUnit\Framework\MockObject\MockObject
+     * @return DatabaseHandler
      */
     protected function getDatabaseHandlerMock()
     {

eZ/Publish/Core/Repository/Tests/Permission/CachedPermissionServiceTest.php

Doc Comments +6 added lines

@@ -173,6 +173,9 @@ 
 
     protected $permissionResolverMock;
 
+    /**
+     * @return PermissionResolver
+     */
     protected function getPermissionResolverMock($methods = [])
     {
         // Tests first calls here with methods set before initiating PermissionCriterionResolver with same instance.
@@ -189,6 +192,9 @@ 
 
     protected $permissionCriterionResolverMock;
 
+    /**
+     * @return PermissionCriterionResolver
+     */
     protected function getPermissionCriterionResolverMock($methods = [])
     {
         // Tests first calls here with methods set before initiating PermissionCriterionResolver with same instance.

eZ/Publish/Core/Repository/Tests/Permission/PermissionCriterionResolverTest.php

Doc Comments +3 added lines

@@ -384,6 +384,9 @@
 
     protected $limitationServiceMock;
 
+    /**
+     * @return integer
+     */
     protected function getLimitationServiceMock($methods = [])
     {
         // Tests first calls here with methods set before initiating PermissionCriterionResolver with same instance.

eZ/Bundle/EzPublishCoreBundle/Features/Context/UserContext.php

Doc Comments +11 added lines, -8 removed lines

@@ -62,9 +62,9 @@ 
      * Search User with given username, optionally at given location.
      *
      * @param string $username name of User to search for
-     * @param string $parentGroupLocationId where to search, in User Group tree
+     * @param string $parentGroupId where to search, in User Group tree
      *
-     * @return User found
+     * @return null|\eZ\Publish\API\Repository\Values\User\User found
      */
     public function searchUserByLogin($username, $parentGroupId = null)
     {
@@ -95,7 +95,7 @@ 
      * @param string $name name of User Group to search for
      * @param string $parentLocationId (optional) parent location id to search in
      *
-     * @return search results
+     * @return \eZ\Publish\API\Repository\Values\Content\Search\SearchHit[] results
      */
     public function searchUserGroups($name, $parentLocationId = null)
     {
@@ -118,12 +118,12 @@ 
     /**
      * Create user inside given User Group; DELETES existing User if login already exists!
      *
-     * @param $username username of the user to create
-     * @param $email email address of user to create
-     * @param $password account password for user to create
-     * @param $parentGroup pathstring wherein to create user
+     * @param string $username username of the user to create
+     * @param string $email email address of user to create
+     * @param string $password account password for user to create
+     * @param \eZ\Publish\API\Repository\Values\User\UserGroup $parentGroup pathstring wherein to create user
      *
-     * @return eZ\Publish\API\Repository\Values\User\User
+     * @return \eZ\Publish\API\Repository\Values\User\User
      */
     protected function createUser($username, $email, $password, $parentGroup = null, $fields = [])
     {
@@ -317,6 +317,9 @@ 
         return false;
     }
 
+    /**
+     * @param integer $type
+     */
     public function createPasswordHash($login, $password, $type)
     {
         switch ($type) {

eZ/Bundle/EzPublishIOBundle/BinaryStreamResponse.php

Doc Comments +2 added lines, -4 removed lines

@@ -44,7 +44,6 @@ 
      * @param array               $headers            An array of response headers
      * @param bool                $public             Files are public by default
      * @param null|string         $contentDisposition The type of Content-Disposition to set automatically with the filename
-     * @param bool                $autoEtag           Whether the ETag header should be automatically set
      * @param bool                $autoLastModified   Whether the Last-Modified header should be automatically set
      */
     public function __construct(BinaryFile $binaryFile, IOServiceInterface $ioService, $status = 200, $headers = [], $public = true, $contentDisposition = null, $autoLastModified = true)
@@ -63,12 +62,11 @@ 
     /**
      * Sets the file to stream.
      *
-     * @param \SplFileInfo|string $file The file to stream
+     * @param BinaryFile $file The file to stream
      * @param string $contentDisposition
-     * @param bool $autoEtag
      * @param bool $autoLastModified
      *
-     * @return BinaryFileResponse
+     * @return BinaryStreamResponse
      */
     public function setFile($file, $contentDisposition = null, $autoLastModified = true)
     {