EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Traits\String\NullableStringFieldTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Test Coverage

Coverage

46.15%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setNullableString()	0	8	1
A	validatorMetaForPropertyNullableString()	0	2	1
A	metaForNullableString()	0	7	1
A	getNullableString()	0	7	2

<?php declare(strict_types=1);

namespace EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Traits\String;

// phpcs:disable

use Doctrine\ORM\Mapping\Builder\ClassMetadataBuilder;
use EdmondsCommerce\DoctrineStaticMeta\Entity\Fields\Interfaces\String\NullableStringFieldInterface;
use EdmondsCommerce\DoctrineStaticMeta\MappingHelper;
use Symfony\Component\Validator\Mapping\ClassMetadata as ValidatorClassMetaData;

// phpcs:enable
trait NullableStringFieldTrait
{

    /**
     * @var string|null
     */
    private $nullableString;

    /**
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    public static function metaForNullableString(ClassMetadataBuilder $builder): void
    {
        MappingHelper::setSimpleStringFields(
            [NullableStringFieldInterface::PROP_NULLABLE_STRING],
            $builder,
            NullableStringFieldInterface::DEFAULT_NULLABLE_STRING,
            false
        );
    }

    /**
     * This method sets the validation for this field.
     *
     * You should add in as many relevant property constraints as you see fit.
     *
     * Remove the PHPMD suppressed warning once you start setting constraints
     *
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     * @see https://symfony.com/doc/current/validation.html#supported-constraints
     *
     * @param ValidatorClassMetaData $metadata
     *
     * @throws \Symfony\Component\Validator\Exception\MissingOptionsException
     * @throws \Symfony\Component\Validator\Exception\InvalidOptionsException
     * @throws \Symfony\Component\Validator\Exception\ConstraintDefinitionException
     */
    protected static function validatorMetaForPropertyNullableString(ValidatorClassMetaData $metadata): void

The parameter $metadata is not used and could be removed.

    {
        //        $metadata->addPropertyConstraint(
        //            NullableStringFieldInterface::PROP_NULLABLE_STRING,
        //            new NotBlank()
        //        );
    }

    /**
     * @return string|null
     */
    public function getNullableString(): ?string
    {
        if (null === $this->nullableString) {
            return NullableStringFieldInterface::DEFAULT_NULLABLE_STRING;
        }

        return $this->nullableString;
    }

    /**
     * @param string|null $nullableString
     *
     * @return self
     */
    private function setNullableString(?string $nullableString): self
    {
        $this->updatePropertyValue(

It seems like updatePropertyValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            NullableStringFieldInterface::PROP_NULLABLE_STRING,
            $nullableString
        );

        return $this;
    }
}