dynamic / foxystripe

code/model/foxycart.cart_validation.php

Doc Comments +3 added lines

@@ -43,6 +43,9 @@
 		self::setSecret(FoxyCart::getStoreKey());
 	}
 
+	/**
+	 * @return string
+	 */
 	public static function getSecret(){
 		return FoxyCart::getStoreKey();
 	}

Braces +3 added lines, -1 removed lines

@@ -269,7 +269,9 @@
 					self::$log[] = '<strong>Options:</strong> <pre>'.htmlspecialchars(print_r($options, true)).'</pre>';
 					unset( $form_part_signed );
 					foreach ($options as $option) {
-						if( !isset($form_part_signed) ) $form_part_signed = $list[0];
+						if( !isset($form_part_signed) ) {
+						    $form_part_signed = $list[0];
+						}
 						$option_signed = preg_replace(
 							'%'.preg_quote($option[1]).preg_quote($option[2]).preg_quote($option[1]).'%',
 							$option[1].self::fc_hash_value($code, $list[2], $option[2], 'value', FALSE).$option[1],

code/pages/ProductHolder.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
 	 * Products function.
 	 *
 	 * @access public
-	 * @return array
+	 * @return PaginatedList
 	 */
 	public function ProductList($limit = 10) {
 

Braces +7 added lines, -3 removed lines

@@ -77,7 +77,9 @@ 
 	public function loadDescendantProductGroupIDListInto(&$idList) {
 		if ($children = $this->AllChildren()) {
 			foreach($children as $child) {
-				if(in_array($child->ID, $idList)) continue;
+				if(in_array($child->ID, $idList)) {
+				    continue;
+				}
 				
 				if($child instanceof ProductHolder) {
 					$idList[] = $child->ID; 
@@ -115,7 +117,7 @@ 
 
 		if($config->MultiGroup){
 			$entries = $this->Products()->sort('SortOrder');
-		}else{
+		} else{
 			$filter = '"ParentID" = ' . $this->ID;
 
 			// Build a list of all IDs for ProductGroups that are children
@@ -124,7 +126,9 @@ 
 			// If no ProductHolders, no ProductPages. So return false
 			if($holderIDs) {
 				// Otherwise, do the actual query
-				if($filter) $filter .= ' OR ';
+				if($filter) {
+				    $filter .= ' OR ';
+				}
 				$filter .= '"ParentID" IN (' . implode(',', $holderIDs) . ")";
 			}
 

code/controllers/FoxyStripe_Controller.php

Doc Comments +15 added lines

@@ -34,6 +34,9 @@ 
 		}
 	}
 
+    /**
+     * @param string $encrypted
+     */
     public function handleDataFeed($encrypted, $decrypted){
         //handle encrypted & decrypted data
         $orders = new SimpleXMLElement($decrypted);
@@ -79,6 +82,10 @@ 
         }
     }
 
+    /**
+     * @param SimpleXMLElement $orders
+     * @param DataObject $transaction
+     */
     public function parseOrderInfo($orders, $transaction) {
 
         foreach ($orders->transactions->transaction as $order) {
@@ -95,6 +102,10 @@ 
         }
     }
 
+    /**
+     * @param SimpleXMLElement $orders
+     * @param DataObject $transaction
+     */
     public function parseOrderCustomer($orders, $transaction) {
 
         foreach ($orders->transactions->transaction as $order) {
@@ -133,6 +144,10 @@ 
         }
     }
 
+    /**
+     * @param SimpleXMLElement $orders
+     * @param DataObject $transaction
+     */
     public function parseOrderDetails($orders, $transaction) {
 
         // remove previous OrderDetails so we don't end up with duplicates

code/forms/FoxyStripePurchaseForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
     private $product;
 
     /**
-     * @param $siteConfig
+     * @param SiteConfig|null $siteConfig
      * @return $this
      */
     public function setSiteConfig($siteConfig)

code/model/FoxyCart.php

Braces +9 added lines, -3 removed lines

@@ -81,13 +81,17 @@ 
     public static function getCustomer($Member = null) {
 
         // throw error if no $Member Object
-        if (!isset($Member)) trigger_error('No Member set', E_USER_ERROR);
+        if (!isset($Member)) {
+            trigger_error('No Member set', E_USER_ERROR);
+        }
 
         // grab customer record from API
 
         $foxyData = array();
         $foxyData["api_action"] = "customer_get";
-        if ($Member->Customer_ID) $foxyData["customer_id"] = $Member->Customer_ID;
+        if ($Member->Customer_ID) {
+            $foxyData["customer_id"] = $Member->Customer_ID;
+        }
         $foxyData["customer_email"] = $Member->Email;
 
         return self::getAPIRequest($foxyData);
@@ -102,7 +106,9 @@ 
         $foxyData = array();
         $foxyData["api_action"] = "customer_save";
         // customer_id will be 0 if created in SilverStripe.
-        if ($Member->Customer_ID) $foxyData["customer_id"] = $Member->Customer_ID;
+        if ($Member->Customer_ID) {
+            $foxyData["customer_id"] = $Member->Customer_ID;
+        }
         $foxyData["customer_email"] = $Member->Email;
         $foxyData["customer_password_hash"] = $Member->Password;
         $foxyData["customer_password_salt"] = $Member->Salt;

code/objects/OptionItem.php

Braces +3 added lines, -1 removed lines

@@ -65,7 +65,9 @@
 		$groupField = DropdownField::create('ProductOptionGroupID', _t("OptionItem.Group", "Group"), $groups())
 			->setEmptyString('')
             ->setDescription(_t('OptionItem.GroupDescription', 'Name of this group of options. Managed in <a href="admin/settings">Settings > FoxyStripe > Option Groups</a>'));
-		if (class_exists('QuickAddNewExtension')) $groupField->useAddNew('OptionGroup', $groups, $groupFields);
+		if (class_exists('QuickAddNewExtension')) {
+		    $groupField->useAddNew('OptionGroup', $groups, $groupFields);
+		}
 
         $fields->addFieldsToTab('Root.Main', array(
 			HeaderField::create('DetailsHD', _t("OptionItem.DetailsHD", "Product Option Details"), 2),

tests/ProductPageTest.php

Braces +6 added lines, -2 removed lines

@@ -41,14 +41,18 @@
 
 		$versions = DB::query('Select * FROM "ProductPage_versions" WHERE "RecordID" = '. $productID);
 		$versionsPostPublish = array();
-		foreach($versions as $versionRow) $versionsPostPublish[] = $versionRow;
+		foreach($versions as $versionRow) {
+		    $versionsPostPublish[] = $versionRow;
+		}
 
 		$product2->delete();
 		$this->assertTrue(!$product2->isPublished());
 
 		$versions = DB::query('Select * FROM "ProductPage_versions" WHERE "RecordID" = '. $productID);
 		$versionsPostDelete = array();
-		foreach($versions as $versionRow) $versionsPostDelete[] = $versionRow;
+		foreach($versions as $versionRow) {
+		    $versionsPostDelete[] = $versionRow;
+		}
 
 		$this->assertTrue($versionsPostPublish == $versionsPostDelete);