PackedItemList::asItemArray() - Code Metrics - Inspection of "Add caching on repeated lookups" - dvdoug/BoxPacker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9610e0...320eee )

by Doug

created 2017-08-12 21:02 UTC

PackedItemList::asItemArray() A

↳ Parent: PackedItemList

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0
crap	2

<?php
/**
 * Box packing (3D bin packing, knapsack problem)
 * @package BoxPacker
 * @author Doug Wright
 */
namespace DVDoug\BoxPacker;

/**
 * List of packed items, ordered by volume
 * @author Doug Wright
 * @package BoxPacker
 */
class PackedItemList extends \SplMaxHeap
{

    /**
     * Compare elements in order to place them correctly in the heap while sifting up.
     *
     * @see \SplMaxHeap::compare()
     *
     * @param PackedItem $itemA
     * @param PackedItem $itemB
     *
     * @return int
     */
    public function compare($itemA, $itemB)
    {
        if ($itemA->getItem()->getVolume() > $itemB->getItem()->getVolume()) {
            return 1;
        } elseif ($itemA->getItem()->getVolume() < $itemB->getItem()->getVolume()) {
            return -1;
        } else {
            return $itemA->getItem()->getWeight() - $itemB->getItem()->getWeight();
        }
    }

    /**
     * Get copy of this list as a standard PHP array
     * @return PackedItem[]
     */
    public function asArray()
    {
        $return = [];
        foreach (clone $this as $item) {
            $return[] = $item;
        }
        return $return;
    }

    /**
     * Get copy of this list as a standard PHP array
     * @return Item[]
     */
    public function asItemArray()
    {
        $return = [];
        foreach (clone $this as $item) {
            $return[] = $item->getItem();
        }
        return $return;
    }
}


1		<?php
2		/**
3		* Box packing (3D bin packing, knapsack problem)
4		* @package BoxPacker
5		* @author Doug Wright
6		*/
7		namespace DVDoug\BoxPacker;
8
9		/**
10		* List of packed items, ordered by volume
11		* @author Doug Wright
12		* @package BoxPacker
13		*/
14		class PackedItemList extends \SplMaxHeap
15		{
16
17		/**
18		* Compare elements in order to place them correctly in the heap while sifting up.
19		*
20		* @see \SplMaxHeap::compare()
21		*
22		* @param PackedItem $itemA
23		* @param PackedItem $itemB
24		*
25		* @return int
26		*/
27	31	public function compare($itemA, $itemB)
28		{
29	31	if ($itemA->getItem()->getVolume() > $itemB->getItem()->getVolume()) {
30	12	return 1;
31	27	} elseif ($itemA->getItem()->getVolume() < $itemB->getItem()->getVolume()) {
32	4	return -1;
33		} else {
34	27	return $itemA->getItem()->getWeight() - $itemB->getItem()->getWeight();
35		}
36		}
37
38		/**
39		* Get copy of this list as a standard PHP array
40		* @return PackedItem[]
41		*/
42	1	public function asArray()
43		{
44	1	$return = [];
45	1	foreach (clone $this as $item) {
46	1	$return[] = $item;
47		}
48	1	return $return;
49		}
50
51		/**
52		* Get copy of this list as a standard PHP array
53		* @return Item[]
54		*/
55	3	public function asItemArray()
56		{
57	3	$return = [];
58	3	foreach (clone $this as $item) {
59	3	$return[] = $item->getItem();
60		}
61	3	return $return;
62		}
63		}
64

dvdoug / BoxPacker

Push — master ( 9610e0...320eee )

PackedItemList::asItemArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like