Inspection of "Added scrutinzier.yml file" - donami/ctable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ebff66...d47983 )

by Markus

created 2016-05-07 19:40 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -4,11 +4,11 @@
 block discarded – undo
 
 <p>How many rolls do you want to do, <a href='<?=$this->url->create("dice/roll?roll=1")?>'>1 roll</a>, <a href='<?=$this->url->create("dice/roll?roll=3")?>'>3 rolls</a> or <a href='<?=$this->url->create("dice/roll?roll=6")?>'>6 rolls</a>? </p>
 
-<?php if(isset($roll)) : ?>
+<?php if (isset($roll)) : ?>
 <p>You made <?=$roll?> roll(s) and you got this serie.</p>
 
 <ul class='dice'>
-<?php foreach($results as $val) : ?>
+<?php foreach ($results as $val) : ?>
 <li class='dice-<?=$val?>'></li>
 <?php endforeach; ?>
 </ul>

Please login to merge, or discard this patch.

vendor/anax/mvc/app/config/autoloader.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -26,7 +26,7 @@
 block discarded – undo
  *
  * @link https://getcomposer.org/doc/01-basic-usage.md#autoloading
  */
-if(is_file(ANAX_INSTALL_PATH . 'vendor/autoload.php')) {
+if (is_file(ANAX_INSTALL_PATH . 'vendor/autoload.php')) {
     include ANAX_INSTALL_PATH . 'vendor/autoload.php';
 }
 

Please login to merge, or discard this patch.

vendor/anax/mvc/app/config/error_reporting.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -8,8 +8,8 @@  discard block
 block discarded – undo
  * Set the error reporting.
  *
  */
-error_reporting(-1);              // Report all type of errors
-ini_set('display_errors', 1);     // Display all errors
+error_reporting(-1); // Report all type of errors
+ini_set('display_errors', 1); // Display all errors
 
 
 
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
  * Default exception handler.
  *
  */
-set_exception_handler(function ($e) {
+set_exception_handler(function($e) {
     echo "Anax: Uncaught exception: <p>"
         . $e->getMessage()
         . "</p><p>Code: "

Please login to merge, or discard this patch.

vendor/anax/mvc/app/config/environment.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,5 +9,5 @@
 block discarded – undo
  *
  */
 define('ANAX_INSTALL_PATH', realpath(__DIR__ . '/../../') . '/');
-define('ANAX_APP_PATH',     ANAX_INSTALL_PATH . 'app/');
+define('ANAX_APP_PATH', ANAX_INSTALL_PATH . 'app/');
 

Please login to merge, or discard this patch.

vendor/anax/mvc/app/config/navbar.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -76,7 +76,7 @@  discard block
 block discarded – undo
      * Callback tracing the current selected menu item base on scriptname
      *
      */
-    'callback' => function ($url) {
+    'callback' => function($url) {
         if ($url == $this->di->get('request')->getCurrentUrl(false)) {
             return true;
         }
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
      * menuitems that has the setting 'mark-if-parent' set to true.
      *
      */
-    'is_parent' => function ($parent) {
+    'is_parent' => function($parent) {
         $route = $this->di->get('request')->getRoute();
         return !substr_compare($parent, $route, 0, strlen($parent));
     },

Please login to merge, or discard this patch.

vendor/anax/mvc/theme/anax-base/index.tpl.php 2 patches

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -3,11 +3,11 @@  discard block
 block discarded – undo
 <head>
 <meta charset='utf-8'/>
 <title><?=$title . $title_append?></title>
-<?php if(isset($favicon)): ?><link rel='icon' href='<?=$this->url->asset($favicon)?>'/><?php endif; ?>
-<?php foreach($stylesheets as $stylesheet): ?>
+<?php if (isset($favicon)): ?><link rel='icon' href='<?=$this->url->asset($favicon)?>'/><?php endif; ?>
+<?php foreach ($stylesheets as $stylesheet): ?>
 <link rel='stylesheet' type='text/css' href='<?=$this->url->asset($stylesheet)?>'/>
 <?php endforeach; ?>
-<?php if(isset($style)): ?><style><?=$style?></style><?php endif; ?>
+<?php if (isset($style)): ?><style><?=$style?></style><?php endif; ?>
 <script src='<?=$this->url->asset($modernizr)?>'></script>
 </head>
 
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
 <div id='wrapper'>
 
 <div id='header'>
-<?php if(isset($header)) echo $header?>
+<?php if (isset($header)) echo $header?>
 <?php $this->views->render('header')?>
 </div>
 
@@ -27,24 +27,24 @@  discard block
 block discarded – undo
 <?php endif; ?>
 
 <div id='main'>
-<?php if(isset($main)) echo $main?>
+<?php if (isset($main)) echo $main?>
 <?php $this->views->render('main')?>
 </div>
 
 <div id='footer'>
-<?php if(isset($footer)) echo $footer?>
+<?php if (isset($footer)) echo $footer?>
 <?php $this->views->render('footer')?>
 </div>
 
 </div>
 
-<?php if(isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif; ?>
+<?php if (isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif; ?>
 
-<?php if(isset($javascript_include)): foreach($javascript_include as $val): ?>
+<?php if (isset($javascript_include)): foreach ($javascript_include as $val): ?>
 <script src='<?=$this->url->asset($val)?>'></script>
 <?php endforeach; endif; ?>
 
-<?php if(isset($google_analytics)): ?>
+<?php if (isset($google_analytics)): ?>
 <script>
   var _gaq=[['_setAccount','<?=$google_analytics?>'],['_trackPageview']];
   (function(d,t){var g=d.createElement(t),s=d.getElementsByTagName(t)[0];

Please login to merge, or discard this patch.

Braces +10 added lines, -4 removed lines patch added patch discarded remove patch

@@ -16,7 +16,8 @@  discard block
 block discarded – undo
 <div id='wrapper'>
 
 <div id='header'>
-<?php if(isset($header)) echo $header?>
+<?php if(isset($header)) {
+  echo $header?>
 <?php $this->views->render('header')?>
 </div>
 
@@ -24,10 +25,13 @@  discard block
 block discarded – undo
 <div id='navbar'>
 <?php $this->views->render('navbar')?>
 </div>
-<?php endif; ?>
+<?php endif;
+}
+?>
 
 <div id='main'>
-<?php if(isset($main)) echo $main?>
+<?php if(isset($main)) {
+  echo $main?>
 <?php $this->views->render('main')?>
 </div>
 
@@ -38,7 +42,9 @@  discard block
 block discarded – undo
 
 </div>
 
-<?php if(isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif; ?>
+<?php if(isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif;
+}
+?>
 
 <?php if(isset($javascript_include)): foreach($javascript_include as $val): ?>
 <script src='<?=$this->url->asset($val)?>'></script>

Please login to merge, or discard this patch.

vendor/anax/mvc/test/DI/CDITest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@  discard block
 block discarded – undo
         $di = new \Anax\DI\CDI();
         $service = 'failsWithException';
 
-        $di->set($service, function () {
+        $di->set($service, function() {
             throw new \Exception("Failed creating service.");
         });
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
         $di = new \Anax\DI\CDIFactoryDefault();
         $service = 'session';
 
-        $di->set($service, function () {
+        $di->set($service, function() {
             $session = new \Anax\Session\CSession();
             $session->configure(ANAX_APP_PATH . 'config/session.php');
             $session->name();

Please login to merge, or discard this patch.

vendor/anax/mvc/test/config.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -11,7 +11,7 @@
 block discarded – undo
  *
  */
 define('ANAX_INSTALL_PATH', realpath(__DIR__ . '/../') . '/');
-define('ANAX_APP_PATH',     ANAX_INSTALL_PATH . 'app/');
+define('ANAX_APP_PATH', ANAX_INSTALL_PATH . 'app/');
 
 
 

Please login to merge, or discard this patch.

vendor/anax/mvc/test/Validate/CValidateTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

		@@ -16,10 +16,10 @@ discard block
		block discarded – undo
16	16	public function providerCheck()
17	17	{
18	18	return [
19		- [ null, ['pass'] ],
20		- [ 0, ['int'] ],
21		- [ 1, ['range' => [1, 100]] ],
22		- [ 100, ['range' => [1, 100]] ],
	19	+ [null, ['pass']],
	20	+ [0, ['int']],
	21	+ [1, ['range' => [1, 100]]],
	22	+ [100, ['range' => [1, 100]]],
23	23	];
24	24	}
25	25
		@@ -69,10 +69,10 @@ discard block
		block discarded – undo
69	69	public function providerCheckFail()
70	70	{
71	71	return [
72		- [ null, ['fail'] ],
73		- [ "moped", ['int'] ],
74		- [ 0, ['range' => [1, 100]] ],
75		- [ 101, ['range' => [1, 100]] ],
	72	+ [null, ['fail']],
	73	+ ["moped", ['int']],
	74	+ [0, ['range' => [1, 100]]],
	75	+ [101, ['range' => [1, 100]]],
76	76	];
77	77	}
78	78

Please login to merge, or discard this patch.

		@@ -4,11 +4,11 @@
		block discarded – undo
4	4
5	5	<p>How many rolls do you want to do, <a href='<?=$this->url->create("dice/roll?roll=1")?>'>1 roll</a>, <a href='<?=$this->url->create("dice/roll?roll=3")?>'>3 rolls</a> or <a href='<?=$this->url->create("dice/roll?roll=6")?>'>6 rolls</a>? </p>
6	6
7		-<?php if(isset($roll)) : ?>
	7	+<?php if (isset($roll)) : ?>
8	8	<p>You made <?=$roll?> roll(s) and you got this serie.</p>
9	9
10	10	<ul class='dice'>
11		-<?php foreach($results as $val) : ?>
	11	+<?php foreach ($results as $val) : ?>
12	12	<li class='dice-<?=$val?>'></li>
13	13	<?php endforeach; ?>
14	14	</ul>

		@@ -26,7 +26,7 @@
		block discarded – undo
26	26	*
27	27	* @link https://getcomposer.org/doc/01-basic-usage.md#autoloading
28	28	*/
29		-if(is_file(ANAX_INSTALL_PATH . 'vendor/autoload.php')) {
	29	+if (is_file(ANAX_INSTALL_PATH . 'vendor/autoload.php')) {
30	30	include ANAX_INSTALL_PATH . 'vendor/autoload.php';
31	31	}
32	32

		@@ -8,8 +8,8 @@ discard block
		block discarded – undo
8	8	* Set the error reporting.
9	9	*
10	10	*/
11		-error_reporting(-1); // Report all type of errors
12		-ini_set('display_errors', 1); // Display all errors
	11	+error_reporting(-1); // Report all type of errors
	12	+ini_set('display_errors', 1); // Display all errors
13	13
14	14
15	15
		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17	* Default exception handler.
18	18	*
19	19	*/
20		-set_exception_handler(function ($e) {
	20	+set_exception_handler(function($e) {
21	21	echo "Anax: Uncaught exception: <p>"
22	22	. $e->getMessage()
23	23	. "</p><p>Code: "

		@@ -9,5 +9,5 @@
		block discarded – undo
9	9	*
10	10	*/
11	11	define('ANAX_INSTALL_PATH', realpath(__DIR__ . '/../../') . '/');
12		-define('ANAX_APP_PATH', ANAX_INSTALL_PATH . 'app/');
	12	+define('ANAX_APP_PATH', ANAX_INSTALL_PATH . 'app/');
13	13

		@@ -76,7 +76,7 @@ discard block
		block discarded – undo
76	76	* Callback tracing the current selected menu item base on scriptname
77	77	*
78	78	*/
79		- 'callback' => function ($url) {
	79	+ 'callback' => function($url) {
80	80	if ($url == $this->di->get('request')->getCurrentUrl(false)) {
81	81	return true;
82	82	}
		@@ -89,7 +89,7 @@ discard block
		block discarded – undo
89	89	* menuitems that has the setting 'mark-if-parent' set to true.
90	90	*
91	91	*/
92		- 'is_parent' => function ($parent) {
	92	+ 'is_parent' => function($parent) {
93	93	$route = $this->di->get('request')->getRoute();
94	94	return !substr_compare($parent, $route, 0, strlen($parent));
95	95	},

		@@ -3,11 +3,11 @@ discard block
		block discarded – undo
3	3	<head>
4	4	<meta charset='utf-8'/>
5	5	<title><?=$title . $title_append?></title>
6		-<?php if(isset($favicon)): ?><link rel='icon' href='<?=$this->url->asset($favicon)?>'/><?php endif; ?>
7		-<?php foreach($stylesheets as $stylesheet): ?>
	6	+<?php if (isset($favicon)): ?><link rel='icon' href='<?=$this->url->asset($favicon)?>'/><?php endif; ?>
	7	+<?php foreach ($stylesheets as $stylesheet): ?>
8	8	<link rel='stylesheet' type='text/css' href='<?=$this->url->asset($stylesheet)?>'/>
9	9	<?php endforeach; ?>
10		-<?php if(isset($style)): ?><style><?=$style?></style><?php endif; ?>
	10	+<?php if (isset($style)): ?><style><?=$style?></style><?php endif; ?>
11	11	<script src='<?=$this->url->asset($modernizr)?>'></script>
12	12	</head>
13	13
		@@ -16,7 +16,7 @@ discard block
		block discarded – undo
16	16	<div id='wrapper'>
17	17
18	18	<div id='header'>
19		-<?php if(isset($header)) echo $header?>
	19	+<?php if (isset($header)) echo $header?>
20	20	<?php $this->views->render('header')?>
21	21	</div>
22	22
		@@ -27,24 +27,24 @@ discard block
		block discarded – undo
27	27	<?php endif; ?>
28	28
29	29	<div id='main'>
30		-<?php if(isset($main)) echo $main?>
	30	+<?php if (isset($main)) echo $main?>
31	31	<?php $this->views->render('main')?>
32	32	</div>
33	33
34	34	<div id='footer'>
35		-<?php if(isset($footer)) echo $footer?>
	35	+<?php if (isset($footer)) echo $footer?>
36	36	<?php $this->views->render('footer')?>
37	37	</div>
38	38
39	39	</div>
40	40
41		-<?php if(isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif; ?>
	41	+<?php if (isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif; ?>
42	42
43		-<?php if(isset($javascript_include)): foreach($javascript_include as $val): ?>
	43	+<?php if (isset($javascript_include)): foreach ($javascript_include as $val): ?>
44	44	<script src='<?=$this->url->asset($val)?>'></script>
45	45	<?php endforeach; endif; ?>
46	46
47		-<?php if(isset($google_analytics)): ?>
	47	+<?php if (isset($google_analytics)): ?>
48	48	<script>
49	49	var _gaq=[['_setAccount','<?=$google_analytics?>'],['_trackPageview']];
50	50	(function(d,t){var g=d.createElement(t),s=d.getElementsByTagName(t)[0];

		@@ -16,7 +16,8 @@ discard block
		block discarded – undo
16	16	<div id='wrapper'>
17	17
18	18	<div id='header'>
19		-<?php if(isset($header)) echo $header?>
	19	+<?php if(isset($header)) {
	20	+ echo $header?>
20	21	<?php $this->views->render('header')?>
21	22	</div>
22	23
		@@ -24,10 +25,13 @@ discard block
		block discarded – undo
24	25	<div id='navbar'>
25	26	<?php $this->views->render('navbar')?>
26	27	</div>
27		-<?php endif; ?>
	28	+<?php endif;
	29	+}
	30	+?>
28	31
29	32	<div id='main'>
30		-<?php if(isset($main)) echo $main?>
	33	+<?php if(isset($main)) {
	34	+ echo $main?>
31	35	<?php $this->views->render('main')?>
32	36	</div>
33	37
		@@ -38,7 +42,9 @@ discard block
		block discarded – undo
38	42
39	43	</div>
40	44
41		-<?php if(isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif; ?>
	45	+<?php if(isset($jquery)):?><script src='<?=$this->url->asset($jquery)?>'></script><?php endif;
	46	+}
	47	+?>
42	48
43	49	<?php if(isset($javascript_include)): foreach($javascript_include as $val): ?>
44	50	<script src='<?=$this->url->asset($val)?>'></script>

		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	$di = new \Anax\DI\CDI();
21	21	$service = 'failsWithException';
22	22
23		- $di->set($service, function () {
	23	+ $di->set($service, function() {
24	24	throw new \Exception("Failed creating service.");
25	25	});
26	26
		@@ -40,7 +40,7 @@ discard block
		block discarded – undo
40	40	$di = new \Anax\DI\CDIFactoryDefault();
41	41	$service = 'session';
42	42
43		- $di->set($service, function () {
	43	+ $di->set($service, function() {
44	44	$session = new \Anax\Session\CSession();
45	45	$session->configure(ANAX_APP_PATH . 'config/session.php');
46	46	$session->name();

		@@ -11,7 +11,7 @@
		block discarded – undo
11	11	*
12	12	*/
13	13	define('ANAX_INSTALL_PATH', realpath(__DIR__ . '/../') . '/');
14		-define('ANAX_APP_PATH', ANAX_INSTALL_PATH . 'app/');
	14	+define('ANAX_APP_PATH', ANAX_INSTALL_PATH . 'app/');
15	15
16	16
17	17

donami / ctable

Push — master ( ebff66...d47983 )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Braces +10 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch