Failed Conditions
Pull Request — 2.7 (#8065)
by
unknown
07:44
created
tests/Doctrine/Tests/ORM/Functional/Ticket/GH7820Test.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,13 +49,13 @@  discard block
 block discarded – undo
49 49
     {
50 50
         parent::setUp();
51 51
 
52
-        if (! Type::hasType(GH7820LineTextType::class)) {
52
+        if ( ! Type::hasType(GH7820LineTextType::class)) {
53 53
             Type::addType(GH7820LineTextType::class, GH7820LineTextType::class);
54 54
         }
55 55
 
56 56
         $this->setUpEntitySchema([GH7820Line::class]);
57 57
 
58
-        $this->_em->createQuery('DELETE FROM ' . GH7820Line::class . ' l')
58
+        $this->_em->createQuery('DELETE FROM '.GH7820Line::class.' l')
59 59
             ->execute();
60 60
 
61 61
         foreach (self::SONG as $index => $line) {
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 
74 74
         self::assertSame(
75 75
             self::SONG,
76
-            array_map(static function (GH7820Line $line) : string {
76
+            array_map(static function(GH7820Line $line) : string {
77 77
                 return $line->toString();
78 78
             }, iterator_to_array(new Paginator($query)))
79 79
         );
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
         self::assertSame(
97 97
             self::SONG,
98
-            array_map(static function (GH7820Line $line) : string {
98
+            array_map(static function(GH7820Line $line) : string {
99 99
                 return $line->toString();
100 100
             }, iterator_to_array(new Paginator($query))),
101 101
             'Expected to return expected data before query cache is populated with DQL -> SQL translation. Were SQL parameters translated?'
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
         self::assertSame(
109 109
             self::SONG,
110
-            array_map(static function (GH7820Line $line) : string {
110
+            array_map(static function(GH7820Line $line) : string {
111 111
                 return $line->toString();
112 112
             }, iterator_to_array(new Paginator($query))),
113 113
             'Expected to return expected data even when DQL -> SQL translation is present in cache. Were SQL parameters translated again?'
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 
166 166
     public function __toString() : string
167 167
     {
168
-        return 'Line: ' . $this->text;
168
+        return 'Line: '.$this->text;
169 169
     }
170 170
 }
171 171
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
     {
176 176
         $text = parent::convertToPHPValue($value, $platform);
177 177
 
178
-        if (! is_string($text)) {
178
+        if ( ! is_string($text)) {
179 179
             return $text;
180 180
         }
181 181
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 
185 185
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
186 186
     {
187
-        if (! $value instanceof GH7820LineText) {
187
+        if ( ! $value instanceof GH7820LineText) {
188 188
             return parent::convertToDatabaseValue($value, $platform);
189 189
         }
190 190
 
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Tools/Export/AbstractClassMetadataExporterTest.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     {
45 45
         $driverMock = new DriverMock();
46 46
         $config = new Configuration();
47
-        $config->setProxyDir(__DIR__ . '/../../Proxies');
47
+        $config->setProxyDir(__DIR__.'/../../Proxies');
48 48
         $config->setProxyNamespace('Doctrine\Tests\Proxies');
49 49
         $eventManager = new EventManager();
50 50
         $conn = new ConnectionMock([], $driverMock, $config, $eventManager);
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
             'yaml'       => YamlDriver::class,
63 63
         ];
64 64
 
65
-        $this->assertArrayHasKey($type, $mappingDriver, "There is no metadata driver for the type '" . $type . "'.");
65
+        $this->assertArrayHasKey($type, $mappingDriver, "There is no metadata driver for the type '".$type."'.");
66 66
 
67 67
         $class  = $mappingDriver[$type];
68 68
         $driver = ($type === 'annotation')
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
85 85
 
86 86
     public function testExportDirectoryAndFilesAreCreated()
87 87
     {
88
-        $this->_deleteDirectory(__DIR__ . '/export/'.$this->_getType());
88
+        $this->_deleteDirectory(__DIR__.'/export/'.$this->_getType());
89 89
 
90 90
         $type = $this->_getType();
91
-        $metadataDriver = $this->_createMetadataDriver($type, __DIR__ . '/' . $type);
91
+        $metadataDriver = $this->_createMetadataDriver($type, __DIR__.'/'.$type);
92 92
         $em = $this->_createEntityManager($metadataDriver);
93 93
         $cmf = $this->_createClassMetadataFactory($em, $type);
94 94
         $metadata = $cmf->getAllMetadata();
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 
100 100
         $type = $this->_getType();
101 101
         $cme = new ClassMetadataExporter();
102
-        $exporter = $cme->getExporter($type, __DIR__ . '/export/' . $type);
102
+        $exporter = $cme->getExporter($type, __DIR__.'/export/'.$type);
103 103
 
104 104
         if ($type === 'annotation') {
105 105
             $entityGenerator = new EntityGenerator();
@@ -114,9 +114,9 @@  discard block
 block discarded – undo
114 114
         $exporter->export();
115 115
 
116 116
         if ($type == 'annotation') {
117
-            $this->assertTrue(file_exists(__DIR__ . '/export/' . $type . '/'.str_replace('\\', '/', ExportedUser::class).$this->_extension));
117
+            $this->assertTrue(file_exists(__DIR__.'/export/'.$type.'/'.str_replace('\\', '/', ExportedUser::class).$this->_extension));
118 118
         } else {
119
-            $this->assertTrue(file_exists(__DIR__ . '/export/' . $type . '/Doctrine.Tests.ORM.Tools.Export.ExportedUser'.$this->_extension));
119
+            $this->assertTrue(file_exists(__DIR__.'/export/'.$type.'/Doctrine.Tests.ORM.Tools.Export.ExportedUser'.$this->_extension));
120 120
         }
121 121
 
122 122
         $this->assertHasDeprecationMessages();
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
     {
130 130
         $type = $this->_getType();
131 131
 
132
-        $metadataDriver = $this->_createMetadataDriver($type, __DIR__ . '/export/' . $type);
132
+        $metadataDriver = $this->_createMetadataDriver($type, __DIR__.'/export/'.$type);
133 133
         $em = $this->_createEntityManager($metadataDriver);
134 134
         $cmf = $this->_createClassMetadataFactory($em, $type);
135 135
         $metadata = $cmf->getAllMetadata();
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
         $type = $this->_getType();
216 216
 
217 217
         if ($type == 'xml') {
218
-            $xml = simplexml_load_file(__DIR__ . '/export/'.$type.'/Doctrine.Tests.ORM.Tools.Export.ExportedUser.dcm.xml');
218
+            $xml = simplexml_load_file(__DIR__.'/export/'.$type.'/Doctrine.Tests.ORM.Tools.Export.ExportedUser.dcm.xml');
219 219
 
220 220
             $xml->registerXPathNamespace("d", "http://doctrine-project.org/schemas/orm/doctrine-mapping");
221 221
             $nodes = $xml->xpath("/d:doctrine-mapping/d:entity/d:field[@name='name' and @type='string' and @nullable='true']");
@@ -359,7 +359,7 @@  discard block
 block discarded – undo
359 359
         $type = $this->_getType();
360 360
 
361 361
         if ($type == 'xml') {
362
-            $xml = simplexml_load_file(__DIR__ . '/export/'.$type.'/Doctrine.Tests.ORM.Tools.Export.ExportedUser.dcm.xml');
362
+            $xml = simplexml_load_file(__DIR__.'/export/'.$type.'/Doctrine.Tests.ORM.Tools.Export.ExportedUser.dcm.xml');
363 363
 
364 364
             $xml->registerXPathNamespace("d", "http://doctrine-project.org/schemas/orm/doctrine-mapping");
365 365
             $nodes = $xml->xpath("/d:doctrine-mapping/d:entity/d:one-to-many[@field='interests']/d:cascade/d:*");
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
             $this->assertEquals('cascade-all', $nodes[0]->getName());
369 369
         } else if ($type == 'yaml') {
370 370
             $yaml = new Parser();
371
-            $value = $yaml->parse(file_get_contents(__DIR__ . '/export/'.$type.'/Doctrine.Tests.ORM.Tools.Export.ExportedUser.dcm.yml'));
371
+            $value = $yaml->parse(file_get_contents(__DIR__.'/export/'.$type.'/Doctrine.Tests.ORM.Tools.Export.ExportedUser.dcm.yml'));
372 372
 
373 373
             $this->assertTrue(isset($value[ExportedUser::class]['oneToMany']['interests']['cascade']));
374 374
             $this->assertEquals(1, count($value[ExportedUser::class]['oneToMany']['interests']['cascade']));
@@ -408,10 +408,10 @@  discard block
 block discarded – undo
408 408
         if (is_file($path)) {
409 409
             return unlink($path);
410 410
         } else if (is_dir($path)) {
411
-            $files = glob(rtrim($path,'/').'/*');
411
+            $files = glob(rtrim($path, '/').'/*');
412 412
 
413 413
             if (is_array($files)) {
414
-                foreach ($files as $file){
414
+                foreach ($files as $file) {
415 415
                     $this->_deleteDirectory($file);
416 416
                 }
417 417
             }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/DDC1383Test.php 2 patches
Indentation   +47 added lines, -47 removed lines patch added patch discarded remove patch
@@ -27,30 +27,30 @@  discard block
 block discarded – undo
27 27
 
28 28
     public function testFailingCase()
29 29
     {
30
-		$parent = new DDC1383Entity();
31
-		$child = new DDC1383Entity();
30
+        $parent = new DDC1383Entity();
31
+        $child = new DDC1383Entity();
32 32
 
33
-		$child->setReference($parent);
33
+        $child->setReference($parent);
34 34
 
35
-		$this->_em->persist($parent);
36
-		$this->_em->persist($child);
35
+        $this->_em->persist($parent);
36
+        $this->_em->persist($child);
37 37
 
38
-		$id = $child->getId();
38
+        $id = $child->getId();
39 39
 
40
-		$this->_em->flush();
41
-		$this->_em->clear();
40
+        $this->_em->flush();
41
+        $this->_em->clear();
42 42
 
43
-		// Try merging the parent entity
44
-		$child = $this->_em->merge($child);
45
-		$parent = $child->getReference();
43
+        // Try merging the parent entity
44
+        $child = $this->_em->merge($child);
45
+        $parent = $child->getReference();
46 46
 
47
-		// Parent is not instance of the abstract class
48
-		self::assertTrue($parent instanceof DDC1383AbstractEntity,
49
-				"Entity class is " . get_class($parent) . ', "DDC1383AbstractEntity" was expected');
47
+        // Parent is not instance of the abstract class
48
+        self::assertTrue($parent instanceof DDC1383AbstractEntity,
49
+                "Entity class is " . get_class($parent) . ', "DDC1383AbstractEntity" was expected');
50 50
 
51
-		// Parent is NOT instance of entity
52
-		self::assertTrue($parent instanceof DDC1383Entity,
53
-				"Entity class is " . get_class($parent) . ', "DDC1383Entity" was expected');
51
+        // Parent is NOT instance of entity
52
+        self::assertTrue($parent instanceof DDC1383Entity,
53
+                "Entity class is " . get_class($parent) . ', "DDC1383Entity" was expected');
54 54
         $this->assertHasDeprecationMessages();
55 55
     }
56 56
 }
@@ -63,22 +63,22 @@  discard block
 block discarded – undo
63 63
  */
64 64
 abstract class DDC1383AbstractEntity
65 65
 {
66
-	/**
67
-	 * @Id
68
-	 * @Column(type="integer")
69
-	 * @GeneratedValue
70
-	 */
71
-	protected $id;
72
-
73
-	public function getId()
74
-	{
75
-		return $this->id;
76
-	}
77
-
78
-	public function setId($id)
79
-	{
80
-		$this->id = $id;
81
-	}
66
+    /**
67
+     * @Id
68
+     * @Column(type="integer")
69
+     * @GeneratedValue
70
+     */
71
+    protected $id;
72
+
73
+    public function getId()
74
+    {
75
+        return $this->id;
76
+    }
77
+
78
+    public function setId($id)
79
+    {
80
+        $this->id = $id;
81
+    }
82 82
 }
83 83
 
84 84
 /**
@@ -86,18 +86,18 @@  discard block
 block discarded – undo
86 86
  */
87 87
 class DDC1383Entity extends DDC1383AbstractEntity
88 88
 {
89
-	/**
90
-	 * @ManyToOne(targetEntity="DDC1383AbstractEntity")
91
-	 */
92
-	protected $reference;
93
-
94
-	public function getReference()
95
-	{
96
-		return $this->reference;
97
-	}
98
-
99
-	public function setReference(DDC1383AbstractEntity $reference)
100
-	{
101
-		$this->reference = $reference;
102
-	}
89
+    /**
90
+     * @ManyToOne(targetEntity="DDC1383AbstractEntity")
91
+     */
92
+    protected $reference;
93
+
94
+    public function getReference()
95
+    {
96
+        return $this->reference;
97
+    }
98
+
99
+    public function setReference(DDC1383AbstractEntity $reference)
100
+    {
101
+        $this->reference = $reference;
102
+    }
103 103
 }
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
                 $this->_em->getClassMetadata(DDC1383Entity::class),
23 23
                 ]
24 24
             );
25
-        } catch(\Exception $ignored) {}
25
+        } catch (\Exception $ignored) {}
26 26
     }
27 27
 
28 28
     public function testFailingCase()
@@ -46,11 +46,11 @@  discard block
 block discarded – undo
46 46
 
47 47
 		// Parent is not instance of the abstract class
48 48
 		self::assertTrue($parent instanceof DDC1383AbstractEntity,
49
-				"Entity class is " . get_class($parent) . ', "DDC1383AbstractEntity" was expected');
49
+				"Entity class is ".get_class($parent).', "DDC1383AbstractEntity" was expected');
50 50
 
51 51
 		// Parent is NOT instance of entity
52 52
 		self::assertTrue($parent instanceof DDC1383Entity,
53
-				"Entity class is " . get_class($parent) . ', "DDC1383Entity" was expected');
53
+				"Entity class is ".get_class($parent).', "DDC1383Entity" was expected');
54 54
         $this->assertHasDeprecationMessages();
55 55
     }
56 56
 }
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Mapping/YamlMappingDriverTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,11 +17,11 @@  discard block
 block discarded – undo
17 17
 
18 18
     protected function _loadDriver()
19 19
     {
20
-        if (!class_exists(Yaml::class, true)) {
20
+        if ( ! class_exists(Yaml::class, true)) {
21 21
             $this->markTestSkipped('Please install Symfony YAML Component into the include path of your PHP installation.');
22 22
         }
23 23
 
24
-        return new YamlDriver(__DIR__ . DIRECTORY_SEPARATOR . 'yaml');
24
+        return new YamlDriver(__DIR__.DIRECTORY_SEPARATOR.'yaml');
25 25
     }
26 26
 
27 27
     /**
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     public function testJoinTablesWithMappedSuperclassForYamlDriver()
33 33
     {
34 34
         $yamlDriver = $this->_loadDriver();
35
-        $yamlDriver->getLocator()->addPaths([__DIR__ . DIRECTORY_SEPARATOR . 'yaml']);
35
+        $yamlDriver->getLocator()->addPaths([__DIR__.DIRECTORY_SEPARATOR.'yaml']);
36 36
 
37 37
         $em = $this->_getTestEntityManager();
38 38
         $em->getConfiguration()->setMetadataDriverImpl($yamlDriver);
Please login to merge, or discard this patch.
lib/Doctrine/ORM/PersistentCollection.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -400,7 +400,7 @@  discard block
 block discarded – undo
400 400
      */
401 401
     public function containsKey($key)
402 402
     {
403
-        if (! $this->initialized && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY
403
+        if ( ! $this->initialized && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY
404 404
             && isset($this->association['indexBy'])) {
405 405
             $persister = $this->em->getUnitOfWork()->getCollectionPersister($this->association);
406 406
 
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
             && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY
434 434
             && isset($this->association['indexBy'])
435 435
         ) {
436
-            if (!$this->typeClass->isIdentifierComposite && $this->typeClass->isIdentifier($this->association['indexBy'])) {
436
+            if ( ! $this->typeClass->isIdentifierComposite && $this->typeClass->isIdentifier($this->association['indexBy'])) {
437 437
                 return $this->em->find($this->typeClass->name, $key);
438 438
             }
439 439
 
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
      */
449 449
     public function count()
450 450
     {
451
-        if (! $this->initialized && $this->association !== null && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY) {
451
+        if ( ! $this->initialized && $this->association !== null && $this->association['fetch'] === ClassMetadata::FETCH_EXTRA_LAZY) {
452 452
             $persister = $this->em->getUnitOfWork()->getCollectionPersister($this->association);
453 453
 
454 454
             return $persister->count($this) + ($this->isDirty ? $this->collection->count() : 0);
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Internal/Hydration/AbstractHydrator.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
                         : $value;
318 318
 
319 319
                     if ($cacheKeyInfo['isIdentifier'] && $value !== null) {
320
-                        $id[$dqlAlias] .= '|' . $value;
320
+                        $id[$dqlAlias] .= '|'.$value;
321 321
                         $nonemptyComponents[$dqlAlias] = true;
322 322
                     }
323 323
                     break;
@@ -352,11 +352,11 @@  discard block
 block discarded – undo
352 352
 
353 353
             // WARNING: BC break! We know this is the desired behavior to type convert values, but this
354 354
             // erroneous behavior exists since 2.0 and we're forced to keep compatibility.
355
-            if (! isset($cacheKeyInfo['isScalar'])) {
355
+            if ( ! isset($cacheKeyInfo['isScalar'])) {
356 356
                 $type  = $cacheKeyInfo['type'];
357 357
                 $value = $type ? $type->convertToPHPValue($value, $this->_platform) : $value;
358 358
 
359
-                $fieldName = $cacheKeyInfo['dqlAlias'] . '_' . $fieldName;
359
+                $fieldName = $cacheKeyInfo['dqlAlias'].'_'.$fieldName;
360 360
             }
361 361
 
362 362
             $rowData[$fieldName] = $value;
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
     private function getDiscriminatorValues(ClassMetadata $classMetadata) : array
466 466
     {
467 467
         $values = array_map(
468
-            function (string $subClass) : string {
468
+            function(string $subClass) : string {
469 469
                 return (string) $this->getClassMetadata($subClass)->discriminatorValue;
470 470
             },
471 471
             $classMetadata->subClasses
Please login to merge, or discard this patch.
tests/Doctrine/Tests/ORM/Functional/Ticket/GH7079Test.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,11 +69,11 @@
 block discarded – undo
69 69
     private function getTableFullName(array $table) : string
70 70
     {
71 71
         $join = '.';
72
-        if (! $this->platform->supportsSchemas() && $this->platform->canEmulateSchemas()) {
72
+        if ( ! $this->platform->supportsSchemas() && $this->platform->canEmulateSchemas()) {
73 73
             $join = '__';
74 74
         }
75 75
 
76
-        return $table['schema'] . $join . $table['name'];
76
+        return $table['schema'].$join.$table['name'];
77 77
     }
78 78
 
79 79
     private function createClassMetadata(string $className) : ClassMetadata
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Export/ClassMetadataExporter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
     public function __construct()
48 48
     {
49
-        @trigger_error(self::class . ' is deprecated and will be removed in Doctrine ORM 3.0', E_USER_DEPRECATED);
49
+        @trigger_error(self::class.' is deprecated and will be removed in Doctrine ORM 3.0', E_USER_DEPRECATED);
50 50
     }
51 51
 
52 52
     /**
Please login to merge, or discard this patch.
lib/Doctrine/ORM/Tools/Export/Driver/AbstractExporter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      */
61 61
     public function __construct($dir = null)
62 62
     {
63
-        @trigger_error(static::class . ' is deprecated and will be removed in Doctrine ORM 3.0', E_USER_DEPRECATED);
63
+        @trigger_error(static::class.' is deprecated and will be removed in Doctrine ORM 3.0', E_USER_DEPRECATED);
64 64
 
65 65
         $this->_outputDir = $dir;
66 66
     }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
                 if ( ! is_dir($dir)) {
147 147
                     mkdir($dir, 0775, true);
148 148
                 }
149
-                if (file_exists($path) && !$this->_overwriteExistingFiles) {
149
+                if (file_exists($path) && ! $this->_overwriteExistingFiles) {
150 150
                     throw ExportException::attemptOverwriteExistingFile($path);
151 151
                 }
152 152
                 file_put_contents($path, $output);
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     protected function _generateOutputPath(ClassMetadataInfo $metadata)
166 166
     {
167
-        return $this->_outputDir . '/' . str_replace('\\', '.', $metadata->name) . $this->_extension;
167
+        return $this->_outputDir.'/'.str_replace('\\', '.', $metadata->name).$this->_extension;
168 168
     }
169 169
 
170 170
     /**
Please login to merge, or discard this patch.