Driver::connect() - Code Metrics - Inspection of "Updated mariadb 10.4 support" - doctrine/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#3533)

unknown

created 2019-04-25 14:00 UTC

Driver::connect() A

↳ Parent: Driver

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	15
ccs	0
cts	10
cp	0
rs	9.9332
c	0
b	0
f	0
cc	3
nc	4
nop	4
crap	12

<?php

declare(strict_types=1);

namespace Doctrine\DBAL\Driver\PDOOracle;

use Doctrine\DBAL\DBALException;
use Doctrine\DBAL\Driver\AbstractOracleDriver;
use Doctrine\DBAL\Driver\PDOConnection;
use Doctrine\DBAL\Driver\PDOException;
use PDO;

/**
 * PDO Oracle driver.
 *
 * WARNING: This driver gives us segfaults in our testsuites on CLOB and other
 * stuff. PDO Oracle is not maintained by Oracle or anyone in the PHP community,
 * which leads us to the recommendation to use the "oci8" driver to connect
 * to Oracle instead.
 */
class Driver extends AbstractOracleDriver
{
    /**
     * {@inheritdoc}
     */
    public function connect(array $params, $username = null, $password = null, array $driverOptions = [])
    {
        if (! empty($params['persistent'])) {
            $driverOptions[PDO::ATTR_PERSISTENT] = true;
        }

        try {
            return new PDOConnection(
                $this->constructPdoDsn($params),
                $username,
                $password,
                $driverOptions
            );
        } catch (PDOException $e) {
            throw DBALException::driverException($this, $e);
        }
    }

    /**
     * Constructs the Oracle PDO DSN.
     *
     * @param mixed[] $params
     *
     * @return string The DSN.
     */
    private function constructPdoDsn(array $params)
    {
        $dsn = 'oci:dbname=' . $this->getEasyConnectString($params);

        if (isset($params['charset'])) {
            $dsn .= ';charset=' . $params['charset'];
        }

        return $dsn;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'pdo_oracle';
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Doctrine\DBAL\Driver\PDOOracle;
6
7		use Doctrine\DBAL\DBALException;
8		use Doctrine\DBAL\Driver\AbstractOracleDriver;
9		use Doctrine\DBAL\Driver\PDOConnection;
10		use Doctrine\DBAL\Driver\PDOException;
11		use PDO;
12
13		/**
14		* PDO Oracle driver.
15		*
16		* WARNING: This driver gives us segfaults in our testsuites on CLOB and other
17		* stuff. PDO Oracle is not maintained by Oracle or anyone in the PHP community,
18		* which leads us to the recommendation to use the "oci8" driver to connect
19		* to Oracle instead.
20		*/
21		class Driver extends AbstractOracleDriver
22		{
23		/**
24		* {@inheritdoc}
25		*/
26		public function connect(array $params, $username = null, $password = null, array $driverOptions = [])
27		{
28		if (! empty($params['persistent'])) {
29		$driverOptions[PDO::ATTR_PERSISTENT] = true;
30		}
31
32		try {
33		return new PDOConnection(
34		$this->constructPdoDsn($params),
35		$username,
36		$password,
37		$driverOptions
38		);
39		} catch (PDOException $e) {
40		throw DBALException::driverException($this, $e);
41		}
42		}
43
44		/**
45		* Constructs the Oracle PDO DSN.
46		*
47		* @param mixed[] $params
48		*
49		* @return string The DSN.
50		*/
51		private function constructPdoDsn(array $params)
52		{
53		$dsn = 'oci:dbname=' . $this->getEasyConnectString($params);
54
55		if (isset($params['charset'])) {
56		$dsn .= ';charset=' . $params['charset'];
57		}
58
59		return $dsn;
60		}
61
62		/**
63		* {@inheritdoc}
64		*/
65	27	public function getName()
66		{
67	27	return 'pdo_oracle';
68		}
69		}
70

doctrine / dbal

Pull Request — develop (#3533)

Driver::connect() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like