dnadesign / silverstripe-elemental

code/models/BaseElement.php

<?php

/**
 * @package elemental
 */
class BaseElement extends Widget

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var array $db
     */
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'ExtraClass' => 'Varchar(255)',
        'HideTitle' => 'Boolean'
    );

    /**
     * @var array $has_one
     */
    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'List' => 'ElementList' // optional.
    );

    /**
     * @var array $has_many
     */
    private static $has_many = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_many is not used and could be removed.

        'VirtualClones' => 'ElementVirtualLinked'
    );

    /**
     * @var string
     */
    private static $title = "Content Block";

Consider using a different property name as you override a private property of the parent class.

The property $title is not used and could be removed.

    /**
     * @var string
     */
    private static $singular_name = 'Content Block';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    /**
     * @var array
     */
    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'ID' => 'ID',
        'Title' => 'Title',
        'ElementType' => 'Type'
    );

    /**
     * @var boolean
     */
    protected $enable_title_in_template = false;


    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = $this->scaffoldFormFields(array(
            'includeRelations' => ($this->ID > 0),
            'tabbed' => true,
            'ajaxSafe' => true
        ));

        $fields->insertAfter(new ReadonlyField('ClassNameTranslated', _t('BaseElement.TYPE', 'Type'), $this->i18n_singular_name()), 'Title');

'Title' is of type string, but the function expects a object<FormField>.

        $fields->removeByName('ListID');
        $fields->removeByName('ParentID');
        $fields->removeByName('Sort');
        $fields->removeByName('ExtraClass');

        if (!$this->enable_title_in_template) {
            $fields->removeByName('HideTitle');
            $title = $fields->fieldByName('Root.Main.Title');

            if ($title) {
                $title->setRightTitle('For reference only. Does not appear in the template.');
            }
        }

        $fields->addFieldToTab('Root.Settings', new TextField('ExtraClass', 'Extra CSS Classes to add'));

        if (!is_a($this, 'ElementList')) {
            $lists = ElementList::get()->filter('ParentID', $this->ParentID);

The property ParentID does not exist on object<BaseElement>. Since you implemented __get, maybe consider adding a @property annotation.

            if ($lists->exists()) {
                $fields->addFieldToTab('Root.Main',
                    $move = new DropdownField('MoveToListID', 'Move this to another list', $lists->map('ID', 'CMSTitle'), '')
                );

                $move->setEmptyString('Select a list..');
                $move->setHasEmptyDefault(true);
            }
        }

        $this->extend('updateCMSFields', $fields);

        if ($this->IsInDB()) {
            if ($this->isEndofLine('BaseElement') && $this->hasExtension('VersionViewerDataObject')) {
                $fields = $this->addVersionViewer($fields, $this);

The method addVersionViewer does not exist on object<BaseElement>? Since you implemented __call, maybe consider adding a @method annotation.

            }
        }

        return $fields;
    }

    /**
     * Version viewer must only be added at if this is the final getCMSFields for a class.
     * in order to avoid having to rename all fields from eg Root.Main to Root.Current.Main
     * To do this we test if getCMSFields is from the current class
     */
    public function isEndofLine($className)
    {
        $methodFromClass = ClassInfo::has_method_from(
            $this->ClassName, 'getCMSFields', $className
        );

        if($methodFromClass) {
            return true;
        }
    }


    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        if (!$this->Sort) {

The property Sort does not exist on object<BaseElement>. Since you implemented __get, maybe consider adding a @property annotation.

            $parentID = ($this->ParentID) ? $this->ParentID : 0;

The property ParentID does not exist on object<BaseElement>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->Sort = DB::query("SELECT MAX(\"Sort\") + 1 FROM \"Widget\" WHERE \"ParentID\" = $parentID")->value();

The property Sort does not exist on object<BaseElement>. Since you implemented __set, maybe consider adding a @property annotation.

        }

        if ($this->MoveToListID) {

The property MoveToListID does not exist on object<BaseElement>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->ListID = $this->MoveToListID;

The property ListID does not exist on object<BaseElement>. Since you implemented __set, maybe consider adding a @property annotation.

The property MoveToListID does not exist on object<BaseElement>. Since you implemented __set, maybe consider adding a @property annotation.

        }
    }

    public function i18n_singular_name()
    {
        return _t(__CLASS__, $this->config()->title);
    }

    public function getElementType()
    {
        return $this->i18n_singular_name();
    }

    public function getTitle()

This method seems to be duplicated in your project.

    {
        if ($title = $this->getField('Title')) {
            return $title;
        } else {
            if (!$this->isInDb()) {
                return;
            }

            return $this->config()->title;
        }
    }

    public function getCMSTitle()

The return type could not be reliably inferred; please add a @return annotation.

This method seems to be duplicated in your project.

    {
        if ($title = $this->getField('Title')) {
            return $this->config()->title . ': ' . $title;
        } else {
            if (!$this->isInDb()) {
                return;
            }
            return $this->config()->title;
        }
    }

    public function canView($member = null)
    {
        return Permission::check('CMS_ACCESS_CMSMain', 'any', $member);
    }

    public function canEdit($member = null)
    {
        return Permission::check('CMS_ACCESS_CMSMain', 'any', $member);
    }

    public function canDelete($member = null)
    {
        return Permission::check('CMS_ACCESS_CMSMain', 'any', $member);
    }

    public function canCreate($member = null)
    {
        return Permission::check('CMS_ACCESS_CMSMain', 'any', $member);
    }

    public function ControllerTop()
    {
        return Controller::curr();
    }

    public function getPage()
    {
        $area = $this->Parent();

The method Parent() does not exist on BaseElement. Did you maybe mean parentClass()?

        if ($area instanceof ElementalArea) {
            return $area->getOwnerPage();
        }

        return null;
    }

    /**
     * Override the {@link Widget::forTemplate()} method so that holders are not rendered twice. The controller should
     * render with widget inside the
     *
     * @return HTML

Should the return type not be HTMLText?

     */
    public function forTemplate($holder = true) {
        return $this->renderWith($this->class);
    }

    /**
     * @return string
     */
    public function getEditLink() {
        return Controller::join_links(
            Director::absoluteBaseURL(),
            'admin/elemental/BaseElement/EditForm/field/BaseElement/item',
            $this->ID,
            'edit'
        );
    }
}