daylerees / scientist

src/Blind/Preparation.php

Doc Comments +8 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
     }
 
     /**
-     * @param $study
+     * @param Study $study
      * @param mixed $control
      * @param Experiment[] $experiments
      * @param string[] $interfaces
@@ -111,6 +111,9 @@ 
         return $experiment;
     }
 
+    /**
+     * @param string $name
+     */
     private function createPropertyExperiment($name, Study $study, $control, array $trials)
     {
         $experiment_name = sprintf('%s::$%s', $study->getName(), $name);
@@ -137,7 +140,7 @@ 
     /**
      * @param mixed $instance
      * @param string $name
-     * @return callable
+     * @return \Closure
      */
     private function createPropertyCallable($instance, $name)
     {
@@ -161,6 +164,9 @@ 
         };
     }
 
+    /**
+     * @param string $name
+     */
     private function createMissingMethodCallable($instance, $name)
     {
         return function() use ($instance, $name) {

Spacing +13 added lines, -13 removed lines

@@ -43,15 +43,15 @@ 
 
         array_push($interfaces, Blind::class);
 
-        foreach($interfaces as &$interface) {
-            if(strpos($interface, '\\') !== 0) {
-                $interface = '\\'.$interface;
+        foreach ($interfaces as &$interface) {
+            if (strpos($interface, '\\') !== 0) {
+                $interface = '\\' . $interface;
             }
         }
 
         $generator = new ClassGenerator($blind_name, 'Scientist\Blind');
         $generator->setImplementedInterfaces($interfaces);
-        $generator->addTrait('\\'.DecoratorTrait::class);
+        $generator->addTrait('\\' . DecoratorTrait::class);
 
         $this->addInterfaceMethods($generator, $interfaces);
 
@@ -72,10 +72,10 @@ 
     {
         $experiments = [];
         $reflection = new ReflectionClass($control);
-        foreach($reflection->getMethods() as $method) {
+        foreach ($reflection->getMethods() as $method) {
             $experiments[] = $this->createMethodExperiment($method->getName(), $study, $control, $trials);
         }
-        foreach($reflection->getProperties(ReflectionProperty::IS_PUBLIC) as $property) {
+        foreach ($reflection->getProperties(ReflectionProperty::IS_PUBLIC) as $property) {
             $experiments[] = $this->createPropertyExperiment($property->getName(), $study, $control, $trials);
         }
         return $experiments;
@@ -97,8 +97,8 @@ 
 
         $experiment->control([$control, $name]);
 
-        foreach($trials as $trial_name => $trial) {
-            if(method_exists($trial, $name)){
+        foreach ($trials as $trial_name => $trial) {
+            if (method_exists($trial, $name)) {
                 $experiment->trial($trial_name, [$trial, $name]);
             } else {
                 $experiment->trial($trial_name, $this->createMissingMethodCallable($trial, $name));
@@ -120,8 +120,8 @@ 
 
         $experiment->control($this->createPropertyCallable($control, $name));
 
-        foreach($trials as $trial_name => $trial) {
-            if(property_exists($trial, $name)){
+        foreach ($trials as $trial_name => $trial) {
+            if (property_exists($trial, $name)) {
                 $experiment->trial($trial_name, $this->createPropertyCallable($trial, $name));
             } else {
                 $experiment->trial($trial_name, $this->createMissingPropertyCallable($trial, $name));
@@ -144,7 +144,7 @@ 
         return function() use ($instance, $name) {
             $args = func_get_args();
             // __set
-            if(count($args) > 1) {
+            if (count($args) > 1) {
                 list($name, $value) = $args;
                 return $instance->{$name} = $value;
             }
@@ -176,9 +176,9 @@ 
     return call_user_func_array([$experiment, 'run'], $arguments);
 PHP;
 
-        foreach($interfaces as $interface) {
+        foreach ($interfaces as $interface) {
             $reflection = new ClassReflection($interface);
-            foreach($reflection->getMethods() as $method) {
+            foreach ($reflection->getMethods() as $method) {
                 $generator = MethodGenerator::fromReflection($method);
                 $generator->setInterface(false);
                 $generator->setBody(sprintf($template, $method->getName()));

src/Study.php

Doc Comments +1 added lines, -1 removed lines

@@ -205,7 +205,7 @@
 
     /**
      * @param string ...$interface blind will implement the interfaces specified
-     * @return mixed
+     * @return Blind
      */
     public function blind($interface = null)
     {

Spacing +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
     public function blind($interface = null)
     {
         $interfaces = func_get_args();
-        if($interface == null) {
+        if ($interface == null) {
             array_shift($interfaces);
         }
 

src/Blind/DecoratorTrait.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     function __construct(Study $study, array $experiments = [])
     {
         $this->study = $study;
-        foreach($experiments as $experiment) {
+        foreach ($experiments as $experiment) {
             $this->experiments[$experiment->getName()] = $experiment;
         }
     }