App\Services\TeamService

Complexity

Total Complexity

8

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getAllUserRoles()	0	3	1
A	createTeam()	0	5	1
A	getAllTeamRoles()	0	7	1
A	deleteTeam()	0	4	1
A	getAllAdminRoles()	0	3	1
A	updateTeam()	0	7	1
A	getById()	0	3	1
A	getAll()	0	3	1

<?php

namespace App\Services;

use App\Http\Requests\TeamStoreRequest;
use Spatie\Permission\Models\Role;

class TeamService
{


    /**
     * Create a user team (Spatie role)
     *
     * @param TeamStoreRequest $request
     *
     * @return \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Eloquent\Model
     */
    public function createTeam(TeamStoreRequest $request)
    {
        $team = Role::create(['name' => $request->name, 'guard_name' => 'web']);

        return $team;
    }

    /**
     * Update a user team (Spatie role)
     *
     * @param \App\Http\Requests\TeamStoreRequest $request
     * @param int $teamId
     *
     * @return \Spatie\Permission\Contracts\Role
     */
    public function updateTeam(TeamStoreRequest $request, int $teamId)
    {
        $team = Role::findById($teamId);
        $team->name = $request->name;

The property name does not seem to exist on Spatie\Permission\Models\Role. Are you sure there is no database migration missing?

        $team->save();

        return $team;
    }

    /**
     * Return the team from the database
     *
     * @param int $teamId
     *
     * @return \Spatie\Permission\Contracts\Role
     */
    public function getById(int $teamId)
    {
        return Role::findById($teamId);
    }

    /**
     * Get all teams.
     *
     * @return iterable
     */
    public function getAll()
    {
        return Role::whereNotIn('name', ['Super Admin', 'Admin', 'Individual', 'Organisation', 'Venue'])->get();
    }

    /**
     * Delete the team from the database
     *
     * @param int $teamId
     *
     * @throws \Exception
     */
    public function deleteTeam(int $teamId)
    {
        $team = Role::findById($teamId);
        $team->delete();
    }

    /**
     * Return all the roles related to administration
     *
     * @return \Spatie\Permission\Models\Role[]
     */
    public function getAllAdminRoles()
    {
        return Role::where('name', 'like', '%Admin%')->get(); // Admin, Super Admin
    }

    /**
     * Return all the roles related to teams
     * (just admins can be assigned to teams)
     *
     * @return \Spatie\Permission\Models\Role[]
     */
    public function getAllTeamRoles()
    {
        return Role::orWhere(function ($query) {
            $query->where('name', 'not like', '%Super admin%')
                ->where('name', 'not like', '%Admin%')
                ->where('name', 'not like', '%Registered%');
        })->get();
    }

    /**
     * Return all the roles Admins and Teams
     *
     * @param null $userId

Are you sure the doc-type for parameter $userId is correct as it would always require null to be passed?

     *
     * @return \Illuminate\Support\Collection
     */
    public function getAllUserRoles($userId = null)

The parameter $userId is not used and could be removed.

    {
        return Role::all()->pluck('name');
    }




}