DanchukAS\DenyMultiplyRunTest\ExistWrongPidFileTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	testBiggerPid()	0	6	1
A	setUp()	0	3	1
A	testNoValidPid()	0	6	1
A	tearDown()	0	4	1
A	testNoAccessFile()	0	16	3

<?php
declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: danchukas
 * Date: 2017-07-15 00:56
 */

namespace DanchukAS\DenyMultiplyRunTest;

use DanchukAS\DenyMultiplyRun\DenyMultiplyRun;
use PHPUnit\Framework\TestCase;

class ExistWrongPidFileTest extends TestCase
{

    private static $existFileName;

    function setUp()

It is recommend to declare an explicit visibility for setUp.

    {
        self::$existFileName = tempnam(sys_get_temp_dir(), 'vo_');
    }

    function tearDown()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for tearDown.

    {
        /** @noinspection PhpUsageOfSilenceOperatorInspection */
        @unlink(self::$existFileName);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

    }


    function testNoValidPid()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for testNoValidPid.

    {
        file_put_contents(self::$existFileName, "12as");

        self::expectException("DanchukAS\DenyMultiplyRun\Exception\ConvertPidFail");

The method PHPUnit\Framework\TestCase::expectException() is not static, but was called statically.

        DenyMultiplyRun::setPidFile(self::$existFileName);
    }


    function testBiggerPid()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for testBiggerPid.

    {
        file_put_contents(self::$existFileName, PHP_INT_MAX);

        self::expectException("DanchukAS\DenyMultiplyRun\Exception\PidBiggerMax");

The method PHPUnit\Framework\TestCase::expectException() is not static, but was called statically.

        DenyMultiplyRun::setPidFile(self::$existFileName);
    }

    function testNoAccessFile()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for testNoAccessFile.

    {
        // existed file without write access for current user.
        // for Ubuntu is /etc/hosts.
        $file_name = "/etc/hosts";

        if (!file_exists($file_name)) {
            self::markTestSkipped("test only for *nix.");
        }

        if (is_writable($file_name)) {
            self::markTestSkipped("test runned under super/admin user. Change user.");
        }

        self::expectException("DanchukAS\DenyMultiplyRun\Exception\OpenFileFail");

The method PHPUnit\Framework\TestCase::expectException() is not static, but was called statically.

        DenyMultiplyRun::setPidFile($file_name);
    }


}