DanchukAS\DenyMultiplyRunTest\ExistRightPidFileTest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	catchError()	0	4	1
A	testExistedPid()	0	7	1
A	waitError()	0	9	1
A	testLockedFile()	0	7	1
A	testNoExistedPid()	0	18	4
A	setUp()	0	3	1
A	testEmptyFile()	0	6	1
A	tearDown()	0	4	1

<?php
/**
 * Created by PhpStorm.
 * User: danchukas
 * Date: 2017-07-15 01:03
 */

namespace DanchukAS\DenyMultiplyRunTest;

use DanchukAS\DenyMultiplyRun\DenyMultiplyRun;
use PHPUnit\Framework\TestCase;

class ExistRightPidFileTest extends TestCase
{

    private static $lastError;

    private static $existFileName;

    function setUp()

It is recommend to declare an explicit visibility for setUp.

    {
        self::$existFileName = tempnam(sys_get_temp_dir(), 'vo_');
    }

    function tearDown()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for tearDown.

    {
        /** @noinspection PhpUsageOfSilenceOperatorInspection */
        @unlink(self::$existFileName);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

    }

    function testEmptyFile()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for testEmptyFile.

    {
        self::waitError();
        DenyMultiplyRun::setPidFile(self::$existFileName);
        $wait_error = "pid-file exist, but file empty. pid-file updated with pid this process: %i";
        self::catchError($wait_error);
    }

    private static function waitError()
    {

        /** @noinspection PhpUnusedParameterInspection */
        set_error_handler(function (int $messageType, string $messageText) {
            self::$lastError = $messageText;
        });

        self::$lastError = null;
    }

    /**
     * перевіряє чи помилка відбулась, і саме та яка очікувалась.
     * @param string $message
     */
    private static function catchError(string $message)
    {
        restore_error_handler();
        self::assertStringMatchesFormat("$message", self::$lastError);
    }

    /**
     * @expectedException \DanchukAS\DenyMultiplyRun\Exception\ProcessExisted
     */
    function testExistedPid()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for testExistedPid.

    {

        $file_name = self::$existFileName;
        file_put_contents($file_name, getmypid());

        DenyMultiplyRun::setPidFile($file_name);
    }

    function testNoExistedPid()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for testNoExistedPid.

    {

        $no_exist_pid = 1;
        while (++$no_exist_pid < PHP_INT_MAX) {
            if (false === posix_kill($no_exist_pid, 0)
                && 3 === posix_get_last_error()
            ) {
                break;
            }
        }
        file_put_contents(self::$existFileName, $no_exist_pid);

        self::waitError();
        DenyMultiplyRun::setPidFile(self::$existFileName);
        $wait_error = "pid-file exist, but process with contained ID(%i) in it is not exist. "
            . "pid-file updated with pid this process: %i";
        self::catchError($wait_error);
    }

    function testLockedFile()

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for testLockedFile.

    {
        $file_resource = fopen(self::$existFileName, "r+");
        flock($file_resource,LOCK_EX);

        self::expectException("DanchukAS\DenyMultiplyRun\Exception\LockFileFail");

The method PHPUnit\Framework\TestCase::expectException() is not static, but was called statically.

        DenyMultiplyRun::setPidFile(self::$existFileName);
    }

}