AddMagicGetMethod::leaveNode() - Code Metrics - Inspection of "Merge pull request #3 from cycle/feature/remove_st..." - cycle/proxy-factory - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 503081...57dad7 )

by Valentin

created 2019-06-03 07:04 UTC

AddMagicGetMethod::leaveNode() A

↳ Parent: AddMagicGetMethod

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php
declare(strict_types=1);

namespace Cycle\ORM\Promise\Visitor;

use Cycle\ORM\Promise\Expressions;
use PhpParser\Builder;
use PhpParser\Node;
use PhpParser\NodeVisitorAbstract;

class AddMagicGetMethod extends NodeVisitorAbstract
{
    /** @var string */
    private $resolverProperty;

    /** @var string */
    private $resolveMethod;

    public function __construct(string $resolverProperty, string $resolveMethod)
    {
        $this->resolverProperty = $resolverProperty;
        $this->resolveMethod = $resolveMethod;
    }

    public function leaveNode(Node $node)
    {
        if ($node instanceof Node\Stmt\Class_) {
            $method = new Builder\Method('__get');
            $method->makePublic();
            $method->addParam(new Builder\Param('name'));
            $method->addStmt($this->buildGetExpression());

            $node->stmts[] = $method->getNode();
        }

        return null;
    }

    private function buildGetExpression(): Node\Stmt\If_

    {
        $resolved = Expressions::resolveMethodCall('this', $this->resolverProperty, $this->resolveMethod);
        $stmt = new Node\Stmt\Return_(new Node\Expr\PropertyFetch($resolved, '{$name}'));

        return Expressions::throwExceptionOnNull($resolved, $stmt);
    }
}

1		<?php
2		declare(strict_types=1);
3
4		namespace Cycle\ORM\Promise\Visitor;
5
6		use Cycle\ORM\Promise\Expressions;
7		use PhpParser\Builder;
8		use PhpParser\Node;
9		use PhpParser\NodeVisitorAbstract;
10
11		class AddMagicGetMethod extends NodeVisitorAbstract
12		{
13		/** @var string */
14		private $resolverProperty;
15
16		/** @var string */
17		private $resolveMethod;
18
19		public function __construct(string $resolverProperty, string $resolveMethod)
20		{
21		$this->resolverProperty = $resolverProperty;
22		$this->resolveMethod = $resolveMethod;
23		}
24
25		public function leaveNode(Node $node)
26		{
27		if ($node instanceof Node\Stmt\Class_) {
28		$method = new Builder\Method('__get');
29		$method->makePublic();
30		$method->addParam(new Builder\Param('name'));
31		$method->addStmt($this->buildGetExpression());
32
33		$node->stmts[] = $method->getNode();
34		}
35
36		return null;
37		}
38
39	View Code Duplication	private function buildGetExpression(): Node\Stmt\If_
		0 ignored issues – show Duplication introduced 2019-05-27 12:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		{
41		$resolved = Expressions::resolveMethodCall('this', $this->resolverProperty, $this->resolveMethod);
42		$stmt = new Node\Stmt\Return_(new Node\Expr\PropertyFetch($resolved, '{$name}'));
43
44		return Expressions::throwExceptionOnNull($resolved, $stmt);
45		}
46		}

cycle / proxy-factory

Push — master ( 503081...57dad7 )

AddMagicGetMethod::leaveNode() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like