Issues in Inverse.php - All Issues - Inspection of "Merge pull request #2 from cycle/feature/doctrine-..." - cycle/annotated - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c93c78...d9ab06 )

by Anton

created 2019-08-13 10:35 UTC

src/Annotation/Relation/Inverse.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php
/**
 * Spiral Framework.
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */
declare(strict_types=1);

namespace Cycle\Annotated\Annotation\Relation;

use Cycle\ORM\Relation;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Doctrine\Common\Annotations\Annotation\Attribute;
use Doctrine\Common\Annotations\Annotation\Attributes;
use Doctrine\Common\Annotations\Annotation\Enum;

/**
 * @Annotation
 * @Target({"PROPERTY", "ANNOTATION"})
 * @Attributes({
 *      @Attribute("as", type="string", required=true),
 *      @Attribute("type", type="string", required=true),
 *      @Attribute("load", type="string"),
 * })
 */
final class Inverse
{
    /** @var string */
    private $as;

    /** @var string */
    private $type;

    /**
     * @Enum({"eager", "lazy", "promise"}
     * @var string
     */
    private $load;

    /**
     * @param array $values
     */
    public function __construct(array $values)
    {
        foreach ($values as $key => $value) {
            if ($key == "fetch") {
                $key = "load";
            }

            $this->$key = $value;
        }
    }

    /**
     * @return string|null
     */
    public function getType(): ?string
    {
        return $this->type;
    }

    /**
     * @return string|null
     */
    public function getName(): ?string
    {
        return $this->as;
    }

    /**
     * @return int|null
     */
    public function getLoadMethod(): ?int
    {
        switch ($this->load) {
            case 'eager':
            case Relation::LOAD_EAGER:
                return Relation::LOAD_EAGER;
            case 'promise':
            case 'lazy':
            case Relation::LOAD_PROMISE:
                return Relation::LOAD_PROMISE;
            default:
                return null;
        }
    }
}

1			<?php
2			/**
3			* Spiral Framework.
4			*
5			* @license MIT
6			* @author Anton Titov (Wolfy-J)
7			*/
8			declare(strict_types=1);
9
10			namespace Cycle\Annotated\Annotation\Relation;
11
12			use Cycle\ORM\Relation;
			0 ignored issues – show Bug introduced 2019-05-29 09:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Cycle\Annotated\Annotation\Relation\Relation`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
13			use Doctrine\Common\Annotations\Annotation\Attribute;
14			use Doctrine\Common\Annotations\Annotation\Attributes;
15			use Doctrine\Common\Annotations\Annotation\Enum;
16
17			/**
18			* @Annotation
19			* @Target({"PROPERTY", "ANNOTATION"})
20			* @Attributes({
21			* @Attribute("as", type="string", required=true),
22			* @Attribute("type", type="string", required=true),
23			* @Attribute("load", type="string"),
24			* })
25			*/
26			final class Inverse
27			{
28			/** @var string */
29			private $as;
30
31			/** @var string */
32			private $type;
33
34			/**
35			* @Enum({"eager", "lazy", "promise"}
36			* @var string
37			*/
38			private $load;
39
40			/**
41			* @param array $values
42			*/
43			public function __construct(array $values)
44			{
45			foreach ($values as $key => $value) {
46			if ($key == "fetch") {
47			$key = "load";
48			}
49
50			$this->$key = $value;
51			}
52			}
53
54			/**
55			* @return string\|null
56			*/
57			public function getType(): ?string
58			{
59			return $this->type;
60			}
61
62			/**
63			* @return string\|null
64			*/
65			public function getName(): ?string
66			{
67			return $this->as;
68			}
69
70			/**
71			* @return int\|null
72			*/
73			public function getLoadMethod(): ?int
74			{
75			switch ($this->load) {
76			case 'eager':
77			case Relation::LOAD_EAGER:
78			return Relation::LOAD_EAGER;
79			case 'promise':
80			case 'lazy':
81			case Relation::LOAD_PROMISE:
82			return Relation::LOAD_PROMISE;
83			default:
84			return null;
85			}
86			}
87			}

cycle / annotated

Push — master ( c93c78...d9ab06 )

src/Annotation/Relation/Inverse.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like