These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | /* |
||
4 | * This file is part of Laravel Paket. |
||
5 | * |
||
6 | * (c) Anton Komarev <[email protected]> |
||
7 | * |
||
8 | * For the full copyright and license information, please view the LICENSE |
||
9 | * file that was distributed with this source code. |
||
10 | */ |
||
11 | |||
12 | declare(strict_types=1); |
||
13 | |||
14 | namespace Cog\Laravel\Paket\Http\Controllers\Api\Jobs; |
||
15 | |||
16 | use Cog\Contracts\Paket\Job\Entities\Job as JobContract; |
||
17 | use Illuminate\Contracts\Support\Responsable as ResponsableContract; |
||
18 | use Illuminate\Http\JsonResponse; |
||
19 | |||
20 | View Code Duplication | final class DeleteResponse implements ResponsableContract |
|
0 ignored issues
–
show
|
|||
21 | { |
||
22 | private $job; |
||
23 | |||
24 | public function __construct(JobContract $job) |
||
25 | { |
||
26 | $this->job = $job; |
||
27 | } |
||
28 | |||
29 | /** |
||
30 | * Create an HTTP response that represents the object. |
||
31 | * |
||
32 | * @param \Illuminate\Http\Request $request |
||
33 | * @return \Symfony\Component\HttpFoundation\Response |
||
34 | */ |
||
35 | public function toResponse($request) |
||
36 | { |
||
37 | return $this->toJson(); |
||
38 | } |
||
39 | |||
40 | private function toJson(): JsonResponse |
||
41 | { |
||
42 | return response()->json($this->job->toArray()); |
||
0 ignored issues
–
show
The method
json does only exist in Illuminate\Contracts\Routing\ResponseFactory , but not in Illuminate\Http\Response .
It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A
{
public function foo() { }
}
class B extends A
{
public function bar() { }
}
/**
* @param A|B $x
*/
function someFunction($x)
{
$x->foo(); // This call is fine as the method exists in A and B.
$x->bar(); // This method only exists in B and might cause an error.
}
Available Fixes
Loading history...
|
|||
43 | } |
||
44 | } |
||
45 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.