Completed
Pull Request — master (#103)
by Kristof
20:26
created
src/CollaborationData.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     }
58 58
 
59 59
     /**
60
-     * @return String|null
60
+     * @return String
61 61
      */
62 62
     public function getSubBrand()
63 63
     {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     }
77 77
 
78 78
     /**
79
-     * @return String|null
79
+     * @return String
80 80
      */
81 81
     public function getTitle()
82 82
     {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
     }
96 96
 
97 97
     /**
98
-     * @return String|null
98
+     * @return String
99 99
      */
100 100
     public function getText()
101 101
     {
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
     }
115 115
 
116 116
     /**
117
-     * @return String|null
117
+     * @return String
118 118
      */
119 119
     public function getCopyright()
120 120
     {
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
     }
134 134
 
135 135
     /**
136
-     * @return String|null
136
+     * @return String
137 137
      */
138 138
     public function getKeyword()
139 139
     {
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
     }
153 153
 
154 154
     /**
155
-     * @return String|null
155
+     * @return String
156 156
      */
157 157
     public function getArticle()
158 158
     {
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -252,14 +252,14 @@
 block discarded – undo
252 252
     public function serialize()
253 253
     {
254 254
         $data = [
255
-            'subBrand' => (string) $this->subBrand,
256
-            'title' => (string) $this->title,
257
-            'text' => (string) $this->text,
258
-            'copyright' => (string) $this->copyright,
259
-            'keyword' => (string) $this->keyword,
260
-            'image' => (string) $this->image,
261
-            'article' => (string) $this->article,
262
-            'link' => (string) $this->link,
255
+            'subBrand' => (string)$this->subBrand,
256
+            'title' => (string)$this->title,
257
+            'text' => (string)$this->text,
258
+            'copyright' => (string)$this->copyright,
259
+            'keyword' => (string)$this->keyword,
260
+            'image' => (string)$this->image,
261
+            'article' => (string)$this->article,
262
+            'link' => (string)$this->link,
263 263
         ];
264 264
 
265 265
         return array_filter($data, 'strlen');
Please login to merge, or discard this patch.
src/Event/Event.php 1 patch
Doc Comments   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -76,8 +76,9 @@  discard block
 block discarded – undo
76 76
      * @param Title $title
77 77
      * @param EventType $eventType
78 78
      * @param Location $location
79
-     * @param CalendarBase $calendar
79
+     * @param CalendarInterface $calendar
80 80
      * @param Theme/null $theme
81
+     * @param string $eventId
81 82
      *
82 83
      * @return Event
83 84
      */
@@ -181,9 +182,9 @@  discard block
 block discarded – undo
181 182
 
182 183
     /**
183 184
      * @param Language $language
184
-     * @param String|null $title
185
-     * @param String|null $shortDescription
186
-     * @param String|null $longDescription
185
+     * @param null|string $title
186
+     * @param null|string $shortDescription
187
+     * @param null|string $longDescription
187 188
      */
188 189
     public function applyTranslation(
189 190
         Language $language,
@@ -262,7 +263,7 @@  discard block
 block discarded – undo
262 263
     }
263 264
 
264 265
     /**
265
-     * @return \CultuurNet\UDB3\CollaborationData[]
266
+     * @return CollaborationDataCollection[]
266 267
      */
267 268
     public function getCollaborationData()
268 269
     {
@@ -402,9 +403,6 @@  discard block
 block discarded – undo
402 403
     /**
403 404
      * Updated the contact info.
404 405
      *
405
-     * @param array $phones
406
-     * @param array $emails
407
-     * @param array $urls
408 406
      */
409 407
     public function updateContactPoint(ContactPoint $contactPoint)
410 408
     {
Please login to merge, or discard this patch.
src/Event/Events/CollaborationDataAdded.php 2 patches
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,12 +4,8 @@
 block discarded – undo
4 4
 
5 5
 use Broadway\Serializer\SerializableInterface;
6 6
 use CultuurNet\UDB3\CollaborationData;
7
-use CultuurNet\UDB3\CollaborationData\CollaborationDataPropertiesTrait;
8 7
 use CultuurNet\UDB3\Language;
9
-use CultuurNet\UDB3\CollaborationData\Description;
10
-use CultuurNet\UDB3\Link\LinkType;
11 8
 use ValueObjects\String\String;
12
-use ValueObjects\Web\Url;
13 9
 
14 10
 final class CollaborationDataAdded implements SerializableInterface
15 11
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
     public function serialize()
87 87
     {
88 88
         $serialized = array(
89
-            'eventId' => (string) $this->eventId,
89
+            'eventId' => (string)$this->eventId,
90 90
             'language' => $this->language->getCode(),
91 91
             'collaborationData' => $this->collaborationData->serialize(),
92 92
         );
Please login to merge, or discard this patch.