cultuurnet / udb3-php

src/StringFilter/StripLeadingSpaceStringFilter.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     public function filter($string)
     {
         if (!is_string($string)) {
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
         }
 
         return preg_replace("/(\\n)+/", " ", $string);

src/OpeningHours.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 
     /**
      * OpeningHours constructor.
-     * @param OpeningHour[]|null $openingHours
+     * @param OpeningHour[] $openingHours
      */
     public function __construct(array $openingHours = null)
     {

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace CultuurNet\UDB3;
 
-use ValueObjects\DateTime\WeekDay;
-
 class OpeningHours
 {
     /**

src/StringFilter/StripSourceStringFilter.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     public function filter($string)
     {
         if (!is_string($string)) {
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
         }
 
         return preg_replace("/(\\n)+/", " ", $string);

src/Label/ReadModels/Relations/Projector.php

Spacing +2 added lines, -2 removed lines

@@ -185,7 +185,7 @@ 
 
         foreach ($labelCollection->asArray() as $label) {
             $this->writeRepository->save(
-                new LabelName((string) $label),
+                new LabelName((string)$label),
                 $relationType,
                 $relationId
             );
@@ -200,7 +200,7 @@ 
     {
         $labelRelation = null;
 
-        $labelName = new LabelName((string) $labelEvent->getLabel());
+        $labelName = new LabelName((string)$labelEvent->getLabel());
         $relationType = $this->offerTypeResolver->getRelationType($labelEvent);
         $relationId = new StringLiteral($labelEvent->getItemId());
 

src/LabelImporter.php

Spacing +2 added lines, -2 removed lines

@@ -15,13 +15,13 @@
         );
 
         $visibleLabels = $labelCollection->filter(
-            function (Label $label) {
+            function(Label $label) {
                 return $label->isVisible();
             }
         )->toStrings();
 
         $hiddenLabels = $labelCollection->filter(
-            function (Label $label) {
+            function(Label $label) {
                 return !$label->isVisible();
             }
         )->toStrings();

src/CalendarFactory.php

Spacing +10 added lines, -10 removed lines

@@ -36,14 +36,14 @@ 
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
             $period = $cdbCalendar->current();
-            $startDateString = $period->getDateFrom() . 'T00:00:00';
+            $startDateString = $period->getDateFrom().'T00:00:00';
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
             $timestamp = $cdbCalendar->current();
             if ($timestamp->getStartTime()) {
-                $startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
+                $startDateString = $timestamp->getDate().'T'.$timestamp->getStartTime();
             } else {
-                $startDateString = $timestamp->getDate() . 'T00:00:00';
+                $startDateString = $timestamp->getDate().'T00:00:00';
             }
         }
         $startDate = !empty($startDateString) ? DateTimeFactory::dateTimeFromDateString($startDateString) : null;
@@ -56,17 +56,17 @@ 
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
             $period = $cdbCalendar->current();
-            $endDateString = $period->getDateTo() . 'T00:00:00';
+            $endDateString = $period->getDateTo().'T00:00:00';
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
             $firstTimestamp = $cdbCalendar->current();
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
             $cdbCalendarAsArray = iterator_to_array($cdbCalendar);
             $timestamp = iterator_count($cdbCalendar) > 1 ? end($cdbCalendarAsArray) : $firstTimestamp;
             if ($timestamp->getEndTime()) {
-                $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
+                $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
             } else {
                 $endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
-                $endDateString = $timestamp->getDate() . 'T' . $endTime;
+                $endDateString = $timestamp->getDate().'T'.$endTime;
             }
         }
         $endDate = !empty($endDateString) ? DateTimeFactory::dateTimeFromDateString($endDateString) : null;
@@ -83,12 +83,12 @@ 
                 $cdbCalendar->next();
 
                 $startTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
-                $startDateString = $timestamp->getDate() . 'T' . $startTime;
+                $startDateString = $timestamp->getDate().'T'.$startTime;
 
                 if ($timestamp->getEndTime()) {
-                    $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
+                    $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
                 } else {
-                    $endDateString = $timestamp->getDate() . 'T' . $startTime;
+                    $endDateString = $timestamp->getDate().'T'.$startTime;
                 }
 
                 $timestamps[] = new Timestamp(
@@ -202,7 +202,7 @@ 
             $openingHour = $mergedOpeningHour->getOpeningHours()[0];
             $openingHoursAsArray[] = [
                 'dayOfWeek' => array_map(
-                    function (WeekDay $weekDay) {
+                    function(WeekDay $weekDay) {
                         return strtolower($weekDay->toNative());
                     },
                     $mergedOpeningHour->getWeekDays()

src/Offer/Offer.php

Spacing +3 added lines, -3 removed lines

@@ -269,7 +269,7 @@ 
     {
         $equalImages = array_filter(
             $this->mediaObjects,
-            function ($existingMediaObjectId) use ($image) {
+            function($existingMediaObjectId) use ($image) {
                 return $image
                     ->getMediaObjectId()
                     ->sameValueAs($existingMediaObjectId);
@@ -444,7 +444,7 @@ 
             if ($this->rejectedReason && $reason->sameValueAs($this->rejectedReason)) {
                 return true; // nothing left to do if the offer has already been rejected for the same reason
             } else {
-                throw new Exception('The offer has already been rejected for another reason: ' . $this->rejectedReason);
+                throw new Exception('The offer has already been rejected for another reason: '.$this->rejectedReason);
             }
         }
 
@@ -586,7 +586,7 @@ 
         $this->mainImageId = $mainImage ? $mainImage->getMediaObjectId() : null;
 
         $this->mediaObjects = array_map(
-            function (Image $image) {
+            function(Image $image) {
                 return $image->getMediaObjectId();
             },
             $imagesEvent->getImages()->toArray()

src/Media/MediaManager.php

Spacing +7 added lines, -7 removed lines

@@ -76,11 +76,11 @@ 
     ) {
         try {
             $existingMediaObject = $this->repository->load($id);
-            $this->logger->info('Trying to create media with id: ' .$id . ' but it already exists. Using existing Media Object!');
+            $this->logger->info('Trying to create media with id: '.$id.' but it already exists. Using existing Media Object!');
 
             return $existingMediaObject;
         } catch (AggregateNotFoundException $exception) {
-            $this->logger->info('No existing media with id: ' .$id . ' found. Creating a new Media Object!');
+            $this->logger->info('No existing media with id: '.$id.' found. Creating a new Media Object!');
         }
 
         $mediaObject = MediaObject::create(
@@ -114,7 +114,7 @@ 
 
         $this->filesystem->rename(
             $uploadImage->getFilePath(),
-            $this->mediaDirectory . '/' . $destinationPath
+            $this->mediaDirectory.'/'.$destinationPath
         );
 
         $this->create(
@@ -125,7 +125,7 @@ 
             Url::fromNative($destinationIri)
         );
 
-        $jobInfo = ['file_id' => (string) $uploadImage->getFileId()];
+        $jobInfo = ['file_id' => (string)$uploadImage->getFileId()];
         $this->logger->info('job_info', $jobInfo);
     }
 
@@ -135,7 +135,7 @@ 
     public function get(UUID $fileId)
     {
         try {
-            $mediaObject = $this->repository->load((string) $fileId);
+            $mediaObject = $this->repository->load((string)$fileId);
         } catch (AggregateNotFoundException $e) {
             throw new MediaObjectNotFoundException(
                 sprintf("Media object with id '%s' not found", $fileId),
@@ -159,8 +159,8 @@ 
         $image = new Image(
             $mediaObject->getMediaObjectId(),
             $mediaObject->getMimeType(),
-            new Description((string) $mediaObject->getDescription()),
-            new CopyrightHolder((string) $mediaObject->getCopyrightHolder()),
+            new Description((string)$mediaObject->getDescription()),
+            new CopyrightHolder((string)$mediaObject->getCopyrightHolder()),
             $mediaObject->getSourceLocation()
         );
 

src/Offer/Events/Image/AbstractImagesEvent.php

Spacing +3 added lines, -3 removed lines

@@ -36,9 +36,9 @@ 
      */
     public function serialize()
     {
-        $serializedData =  parent::serialize() + array(
+        $serializedData = parent::serialize() + array(
             'images' => array_map(
-                function (Image $image) {
+                function(Image $image) {
                     return $image->serialize();
                 },
                 $this->images->toArray()
@@ -61,7 +61,7 @@ 
     {
         $images = ImageCollection::fromArray(
             array_map(
-                function ($imageData) {
+                function($imageData) {
                     return Image::deserialize($imageData);
                 },
                 $data['images']