consolidation / robo

src/Task/Composer/RequireDependency.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
         if (isset($version)) {
             $project = array_map(
-                function ($item) use ($version) {
+                function($item) use ($version) {
                     return "$item:$version";
                 },
                 $project

tests/cli/CopyDirRecursiveExcludeCept.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 $I = new CliGuy($scenario);
 
 $I->wantTo('copy dir recursively with CopyDir task, but exclude a file');
-$I->amInPath(codecept_data_dir().'sandbox');
+$I->amInPath(codecept_data_dir() . 'sandbox');
 $I->seeDirFound('some/deeply/nested');
 $I->seeDirFound('some/deeply/nested2');
 $I->seeDirFound('some/deeply/nested3');

src/Task/Development/SemVer.php

Spacing +1 added lines, -1 removed lines

@@ -235,7 +235,7 @@
         }
 
         $this->version = array_intersect_key($matches, $this->version);
-        $this->version = array_map(function ($item) {
+        $this->version = array_map(function($item) {
             return $item[0];
         }, $this->version);
     }

src/Common/ConfigAwareTrait.php

Spacing +3 added lines, -3 removed lines

@@ -73,9 +73,9 @@
      */
     private static function getClassKey($key)
     {
-        $configPrefix = static::configPrefix();                            // task.
-        $configClass = static::configClassIdentifier(get_called_class());  // PARTIAL_NAMESPACE.CLASSNAME
-        $configPostFix = static::configPostfix();                          // .settings
+        $configPrefix = static::configPrefix(); // task.
+        $configClass = static::configClassIdentifier(get_called_class()); // PARTIAL_NAMESPACE.CLASSNAME
+        $configPostFix = static::configPostfix(); // .settings
 
         return sprintf('%s%s%s.%s', $configPrefix, $configClass, $configPostFix, $key);
     }

tests/unit/ConfigurationInjectionTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 use Robo\Robo;
-
 use Consolidation\Config\Loader\ConfigProcessor;
 use Consolidation\Config\Loader\YamlConfigLoader;
 

src/Runner.php

Spacing +4 added lines, -4 removed lines

@@ -47,7 +47,7 @@ 
     public function __construct($roboClass = null, $roboFile = null)
     {
         // set the const as class properties to allow overwriting in child classes
-        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS ;
+        $this->roboClass = $roboClass ? $roboClass : self::ROBOCLASS;
         $this->roboFile  = $roboFile ? $roboFile : self::ROBOFILE;
         $this->dir = getcwd();
     }
@@ -371,9 +371,9 @@ 
 
         if (substr($argv[$pos], 0, 12) == '--load-from=') {
             $this->dir = substr($argv[$pos], 12);
-        } elseif (isset($argv[$pos +1])) {
-            $this->dir = $argv[$pos +1];
-            unset($argv[$pos +1]);
+        } elseif (isset($argv[$pos + 1])) {
+            $this->dir = $argv[$pos + 1];
+            unset($argv[$pos + 1]);
         }
         unset($argv[$pos]);
         // Make adjustments if '--load-from' points at a file.

Doc Comments +5 added lines, -2 removed lines

@@ -63,6 +63,9 @@ 
         $this->dir = getcwd();
     }
 
+    /**
+     * @param string $errorType
+     */
     protected function errorCondtion($msg, $errorType)
     {
         $this->errorConditions[$msg] = $errorType;
@@ -110,7 +113,7 @@ 
     }
 
     /**
-     * @param array $argv
+     * @param string[] $argv
      * @param null|string $appName
      * @param null|string $appVersion
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
@@ -133,7 +136,7 @@ 
      * @param null|\Symfony\Component\Console\Input\InputInterface $input
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
      * @param null|\Robo\Application $app
-     * @param array[] $commandFiles
+     * @param null|string $commandFiles
      * @param null|ClassLoader $classLoader
      *
      * @return int

src/GlobalOptionsEventListener.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
      * the input string contains no '=' character, then the value will be 'true'.
      *
      * @param string $value
-     * @return array
+     * @return boolean[]
      */
     protected function splitConfigKeyValue($value)
     {

src/SelfUpdateCommand.php

Doc Comments +5 added lines

@@ -24,6 +24,11 @@
 
     protected $applicationName;
 
+    /**
+     * @param string $applicationName
+     * @param string $currentVersion
+     * @param string $gitHubRepository
+     */
     public function __construct($applicationName = null, $currentVersion = null, $gitHubRepository = null)
     {
         parent::__construct(self::SELF_UPDATE_COMMAND_NAME);

Spacing +7 added lines, -7 removed lines

@@ -55,7 +55,7 @@ 
             'http' => [
                 'method' => 'GET',
                 'header' => [
-                    'User-Agent: ' . $this->applicationName  . ' (' . $this->gitHubRepository . ')' . ' Self-Update (PHP)'
+                    'User-Agent: ' . $this->applicationName . ' (' . $this->gitHubRepository . ')' . ' Self-Update (PHP)'
                 ]
             ]
         ];
@@ -65,14 +65,14 @@ 
         $releases = file_get_contents('https://api.github.com/repos/' . $this->gitHubRepository . '/releases', false, $context);
         $releases = json_decode($releases);
 
-        if (! isset($releases[0])) {
+        if (!isset($releases[0])) {
             throw new \Exception('API error - no release found at GitHub repository ' . $this->gitHubRepository);
         }
 
         $version = $releases[0]->tag_name;
         $url     = $releases[0]->assets[0]->browser_download_url;
 
-        return [ $version, $url ];
+        return [$version, $url];
     }
 
     /**
@@ -89,20 +89,20 @@ 
         $tempFilename  = dirname($localFilename) . '/' . basename($localFilename, '.phar') . '-temp.phar';
 
         // check for permissions in local filesystem before start connection process
-        if (! is_writable($tempDirectory = dirname($tempFilename))) {
+        if (!is_writable($tempDirectory = dirname($tempFilename))) {
             throw new \Exception(
                 $programName . ' update failed: the "' . $tempDirectory .
                 '" directory used to download the temp file could not be written'
             );
         }
 
-        if (! is_writable($localFilename)) {
+        if (!is_writable($localFilename)) {
             throw new \Exception(
                 $programName . ' update failed: the "' . $localFilename . '" file could not be written (execute with sudo)'
             );
         }
 
-        list( $latest, $downloadUrl ) = $this->getLatestReleaseFromGithub();
+        list($latest, $downloadUrl) = $this->getLatestReleaseFromGithub();
 
 
         if ($this->currentVersion == $latest) {
@@ -131,7 +131,7 @@ 
             $this->_exit();
         } catch (\Exception $e) {
             @unlink($tempFilename);
-            if (! $e instanceof \UnexpectedValueException && ! $e instanceof \PharException) {
+            if (!$e instanceof \UnexpectedValueException && !$e instanceof \PharException) {
                 throw $e;
             }
             $output->writeln('<error>The download is corrupted (' . $e->getMessage() . ').</error>');

src/Common/ProcessUtils.php

Unused Use Statements -2 removed lines

@@ -7,8 +7,6 @@
 
 namespace Robo\Common;
 
-use Symfony\Component\Process\Exception\InvalidArgumentException;
-
 /**
  * ProcessUtils is a bunch of utility methods. We want to allow Robo 1.x
  * to work with Symfony 4.x while remaining backwards compatibility. This

Doc Comments +3 added lines

@@ -72,6 +72,9 @@
         return "'".str_replace("'", "'\\''", $argument)."'";
     }
 
+    /**
+     * @param string $char
+     */
     private static function isSurroundedBy($arg, $char)
     {
         return 2 < strlen($arg) && $char === $arg[0] && $char === $arg[strlen($arg) - 1];

Spacing +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
      */
     public static function escapeArgument($argument)
     {
-        @trigger_error('The '.__METHOD__.'() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0.', E_USER_DEPRECATED);
+        @trigger_error('The ' . __METHOD__ . '() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0.', E_USER_DEPRECATED);
 
         //Fix for PHP bug #43784 escapeshellarg removes % from given string
         //Fix for PHP bug #49446 escapeshellarg doesn't work on Windows
@@ -52,7 +52,7 @@ 
                     $escapedArgument .= '\\"';
                 } elseif (self::isSurroundedBy($part, '%')) {
                     // Avoid environment variable expansion
-                    $escapedArgument .= '^%"'.substr($part, 1, -1).'"^%';
+                    $escapedArgument .= '^%"' . substr($part, 1, -1) . '"^%';
                 } else {
                     // escape trailing backslash
                     if ('\\' === substr($part, -1)) {
@@ -63,13 +63,13 @@ 
                 }
             }
             if ($quote) {
-                $escapedArgument = '"'.$escapedArgument.'"';
+                $escapedArgument = '"' . $escapedArgument . '"';
             }
 
             return $escapedArgument;
         }
 
-        return "'".str_replace("'", "'\\''", $argument)."'";
+        return "'" . str_replace("'", "'\\''", $argument) . "'";
     }
 
     private static function isSurroundedBy($arg, $char)