These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | use AspectMock\Test as test; |
||
0 ignored issues
–
show
|
|||
3 | |||
4 | class AtoumTest extends \Codeception\TestCase\Test |
||
5 | { |
||
6 | /** |
||
7 | * @var \AspectMock\Proxy\ClassProxy |
||
8 | */ |
||
9 | protected $atoum; |
||
10 | |||
11 | protected function _before() |
||
12 | { |
||
13 | $this->atoum = test::double('Robo\Task\Testing\Atoum', [ |
||
0 ignored issues
–
show
It seems like
\AspectMock\Test::double...\Psr\Log\NullLogger())) can also be of type object<AspectMock\Proxy\InstanceProxy> . However, the property $atoum is declared as type object<AspectMock\Proxy\ClassProxy> . Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable Either this assignment is in error or a type check should be added for that assignment. class Id
{
public $id;
public function __construct($id)
{
$this->id = $id;
}
}
class Account
{
/** @var Id $id */
public $id;
}
$account_id = false;
if (starsAreRight()) {
$account_id = new Id(42);
}
$account = new Account();
if ($account instanceof Id)
{
$account->id = $account_id;
}
Loading history...
|
|||
14 | 'executeCommand' => null, |
||
15 | 'output' => new \Symfony\Component\Console\Output\NullOutput(), |
||
16 | 'logger' => new \Psr\Log\NullLogger(), |
||
17 | ]); |
||
18 | } |
||
19 | |||
20 | public function testAtoumCommand() |
||
21 | { |
||
22 | $task = (new \Robo\Task\Testing\Atoum('atoum')) |
||
23 | ->bootstrap('bootstrap.php') |
||
24 | ->tags("needDb") |
||
25 | ->lightReport() |
||
26 | ->tap() |
||
27 | ->bootstrap('tests/bootstrap.php') |
||
28 | ->configFile("config/dev.php") |
||
29 | ->debug() |
||
30 | ->files(array("path/to/file1.php", "path/to/file2.php")) |
||
31 | ->directories("tests/units") |
||
32 | ; |
||
33 | verify($task->getCommand())->equals('atoum --bootstrap bootstrap.php --tags needDb --use-light-report --use-tap-report --bootstrap tests/bootstrap.php -c config/dev.php --debug --f path/to/file1.php --f path/to/file2.php --directories tests/units'); |
||
34 | $task->run(); |
||
35 | $this->atoum->verifyInvoked('executeCommand', ['atoum --bootstrap bootstrap.php --tags needDb --use-light-report --use-tap-report --bootstrap tests/bootstrap.php -c config/dev.php --debug --f path/to/file1.php --f path/to/file2.php --directories tests/units']); |
||
36 | } |
||
37 | } |
||
38 |
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: