Issues in loadTasks.php - All Issues - Inspection of "Failing test fixed by Annotated Command 2.10.2 upg..." - consolidation/robo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 061d1e...31cfb3 )

by Greg

created 2018-12-21 04:12 UTC

All Issues
New 3

src/Collection/loadTasks.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Robo\Collection;

trait loadTasks
{
    /**
     * Run a callback function on each item in a collection
     *
     * @param array $collection
     *
     * @return \Robo\Collection\TaskForEach|\Robo\Collection\CollectionBuilder
     */
    protected function taskForEach($collection = [])
    {
        return $this->task(TaskForEach::class, $collection);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2			namespace Robo\Collection;
3
4			trait loadTasks
5			{
6			/**
7			* Run a callback function on each item in a collection
8			*
9			* @param array $collection
10			*
11			* @return \Robo\Collection\TaskForEach\|\Robo\Collection\CollectionBuilder
12			*/
13			protected function taskForEach($collection = [])
14			{
15			return $this->task(TaskForEach::class, $collection);
			0 ignored issues – show Bug introduced 2016-09-13 23:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17			}
18

consolidation / robo

Push — master ( 061d1e...31cfb3 )

src/Collection/loadTasks.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like