Completed
Push — master ( 436ab8...4d7079 )
by Greg
33:38
created

testSemverParseFileWithWindowsLineEndings()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 11

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 11
rs 9.9
c 0
b 0
f 0
cc 1
nc 1
nop 0
1
<?php
2
3
use AspectMock\Test as test;
0 ignored issues
show
Bug introduced by Davert
This use statement conflicts with another class in this namespace, test.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
4
5
class SemVerTest extends \Codeception\TestCase\Test
6
{
7
    public function testSemver()
8
    {
9
        $semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
10
        $res = (new \Robo\Task\Development\SemVer())
11
            ->increment('major')
12
            ->prerelease('RC')
13
            ->increment('patch')
14
            ->run();
15
        verify($res->getMessage())->equals('v1.0.1-RC.1');
16
        $semver->verifyInvoked('dump');
17
    }
18
19
    public function testSemverIncrementMinorAfterIncrementedPatch()
20
    {
21
        $semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
22
        $res = (new \Robo\Task\Development\SemVer())
23
            ->increment('patch')
24
            ->run();
25
        verify($res->getMessage())->equals('v0.0.1');
26
        $res = (new \Robo\Task\Development\SemVer())
27
            ->increment('minor')
28
            ->run();
29
        verify($res->getMessage())->equals('v0.1.0');
30
        $semver->verifyInvoked('dump');
31
    }
32
33
    public function testSemverIncrementMajorAfterIncrementedMinorAndPatch()
34
    {
35
        $semver = test::double('Robo\Task\Development\SemVer', ['dump' => null]);
36
        $res = (new \Robo\Task\Development\SemVer())
37
            ->increment('patch')
38
            ->run();
39
        verify($res->getMessage())->equals('v0.0.1');
40
        $res = (new \Robo\Task\Development\SemVer())
41
            ->increment('minor')
42
            ->run();
43
        verify($res->getMessage())->equals('v0.1.0');
44
        $res = (new \Robo\Task\Development\SemVer())
45
            ->increment('major')
46
            ->run();
47
        verify($res->getMessage())->equals('v1.0.0');
48
        $semver->verifyInvoked('dump');
49
    }
50
51
    public function testSemverParseFileWithWindowsLineEndings()
52
    {
53
        $fixturePath = tempnam(sys_get_temp_dir(), 'semver');
54
        $semverFile = str_replace("\n", "\r\n", file_get_contents(codecept_data_dir().'.semver'));
55
        file_put_contents($fixturePath, $semverFile);
56
57
        $res = (new \Robo\Task\Development\SemVer($fixturePath))
58
            ->run();
59
        verify($res->getMessage())->equals('v1.0.1-RC.1');
60
        @unlink($fixturePath);
0 ignored issues
show
Security Best Practice introduced by Cédric Belin
It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

If you suppress an error, we recommend checking for the error condition explicitly:

// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
Loading history...
61
    }
62
63
    public function testThrowsExceptionWhenIncrementWithWrongParameter()
64
    {
65
        \PHPUnit_Framework_TestCase::setExpectedExceptionRegExp(
0 ignored issues
show
Deprecated Code introduced by Tim Tegeler
The method PHPUnit_Framework_TestCa...pectedExceptionRegExp() has been deprecated with message: Method deprecated since Release 5.6.0; use expectExceptionMessageRegExp() instead

This method has been deprecated. The supplier of the class has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead.

Loading history...
66
            'Robo\Exception\TaskException',
67
            '/Bad argument, only one of the following is allowed: major, minor, patch/'
68
        );
69
        $res = (new \Robo\Task\Development\SemVer())
0 ignored issues
show
Unused Code introduced by Greg Anderson
$res is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
70
            ->increment('wrongParameter');
71
    }
72
73
    public function testThrowsExceptionWhenSemverFileNotWriteable()
74
    {
75
        \PHPUnit_Framework_TestCase::setExpectedExceptionRegExp(
0 ignored issues
show
Deprecated Code introduced by Raphael Stolt
The method PHPUnit_Framework_TestCa...pectedExceptionRegExp() has been deprecated with message: Method deprecated since Release 5.6.0; use expectExceptionMessageRegExp() instead

This method has been deprecated. The supplier of the class has supplied an explanatory message.

The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead.

Loading history...
76
            'Robo\Exception\TaskException',
77
            '/Failed to write semver file./'
78
        );
79
        (new \Robo\Task\Development\SemVer('/.semver'))
80
            ->increment('major')
81
            ->run();
82
    }
83
}
84