Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 22 | class NetworkException extends ClientException implements NetworkExceptionInterface{ |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @var \Psr\Http\Message\RequestInterface |
||
| 26 | */ |
||
| 27 | private RequestInterface $request; |
||
|
|
|||
| 28 | |||
| 29 | /** |
||
| 30 | * @param string $message |
||
| 31 | * @param \Psr\Http\Message\RequestInterface $request |
||
| 32 | * @param \Exception|null $previous |
||
| 33 | */ |
||
| 34 | public function __construct(string $message, RequestInterface $request, Exception $previous = null){ |
||
| 35 | $this->request = $request; |
||
| 36 | |||
| 37 | parent::__construct($message, 0, $previous); |
||
| 38 | } |
||
| 39 | |||
| 40 | /** |
||
| 41 | * Returns the request. |
||
| 42 | * |
||
| 43 | * The request object MAY be a different object from the one passed to ClientInterface::sendRequest() |
||
| 44 | * |
||
| 45 | * @return \Psr\Http\Message\RequestInterface |
||
| 46 | */ |
||
| 47 | public function getRequest():RequestInterface{ |
||
| 48 | return $this->request; |
||
| 49 | } |
||
| 50 | |||
| 51 | } |
||
| 52 |