ProfileType::buildForm() - Code Metrics - Inspection of "Add extra fields in profile (WIP) + add tests" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ee4256...c7999a )

by Julito

created 2021-10-13 12:46 UTC

ProfileType::buildForm() B

↳ Parent: ProfileType

Complexity

Conditions	6
Paths	5

Size

Total Lines	112
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	41
nc	5
nop	2
dl	0
loc	112
rs	8.6417
c	0
b	0
f	0

How to fix Long Method

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Form;

use Chamilo\CoreBundle\Entity\ExtraField;
use Chamilo\CoreBundle\Entity\ExtraFieldValues;
use Chamilo\CoreBundle\Entity\User;
use Chamilo\CoreBundle\Form\Type\IllustrationType;
use Chamilo\CoreBundle\Repository\ExtraFieldRepository;
use Chamilo\CoreBundle\Repository\ExtraFieldValuesRepository;
use Chamilo\CoreBundle\Repository\LanguageRepository;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\BirthdayType;
use Symfony\Component\Form\Extension\Core\Type\EmailType;
use Symfony\Component\Form\Extension\Core\Type\LocaleType;
use Symfony\Component\Form\Extension\Core\Type\TextareaType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\Extension\Core\Type\TimezoneType;
use Symfony\Component\Form\Extension\Core\Type\UrlType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\Security\Core\Security;

class ProfileType extends AbstractType
{
    private LanguageRepository $languageRepository;
    private ExtraFieldValuesRepository $extraFieldValuesRepository;
    private Security $security;

    public function __construct(LanguageRepository $languageRepository, ExtraFieldValuesRepository $extraFieldValuesRepository, ExtraFieldRepository $extraFieldRepository, Security $security)
    {
        $this->languageRepository = $languageRepository;
        $this->extraFieldValuesRepository = $extraFieldValuesRepository;
        $this->extraFieldRepository = $extraFieldRepository;
        $this->security = $security;
    }

    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $languages = array_flip($this->languageRepository->getAllAvailableToArray());

        $builder
            ->add('firstname', TextType::class, ['label' => 'Firstname', 'required' => true])
            ->add('lastname', TextType::class, ['label' => 'Lastname', 'required' => true])
            ->add('email', EmailType::class, ['label' => 'Email', 'required' => true])
            //->add('official_code', TextType::class)
            //->add('groups')
            ->add('locale', LocaleType::class, [
                //'preferred_choices' => ['en', 'fr_FR', 'es_ES', 'pt', 'nl'],
                'choices' => $languages,
                'choice_loader' => null,
            ])
            /*->add(                'dateOfBirth',
                BirthdayType::class,
                [
                    'label' => 'form.label_date_of_birth',
                    'required' => false,
                    'widget' => 'single_text',
                ]
            )
            ->add(
                'biography',
                TextareaType::class,
                [
                    'label' => 'form.label_biography',
                    'required' => false,
                ]
            )*/
            /*->add('locale', 'locale', array(
                'label'    => 'form.label_locale',
                'required' => false,
            ))*/
            ->add('timezone', TimezoneType::class, ['label' => 'Timezone', 'required' => true])
            ->add('phone', TextType::class, ['label' => 'Phone number', 'required' => false])
            ->add(
                'illustration',
                IllustrationType::class,
                ['label' => 'Picture', 'required' => false, 'mapped' => false]
            )
            //->add('website', UrlType::class, ['label' => 'Website', 'required' => false])
            /*->add(
                'extraFieldValues',
                CollectionType::class,
                array(
                    'required' => false,
                    'allow_add' => true,
                    'allow_delete' => true,
                    'type' => 'chamilo_user_extra_field_value',
                    'by_reference' => false,
                    'prototype' => true,
                    'widget_add_btn' => ['label' => 'Add'],
                    'options' => array( // options for collection fields
                        'widget_remove_btn' => array('label' => 'Remove'),
                        'label_render' => false,
                    )
                )
            )*/
            //->add('save', 'submit', array('label' => 'Update')            )
        ;

        $user = $this->security->getUser();

        if (null === $user) {
            return;
        }

        $extraFields = $this->extraFieldRepository->getExtraFields();
        $values = $this->extraFieldValuesRepository->getExtraFieldValuesFromItem($user);

        $data = [];
        foreach ($values as $value) {
            $data[$value->getField()->getVariable()] = $value->getValue();
        }

        foreach ($extraFields as $extraField) {
            $text = $extraField->getDisplayText();
            $variable = $extraField->getVariable();

            $value = $data[$extraField->getVariable()] ?? '';

            // @todo
            /*switch ($extraField->getFieldType()) {
                case \ExtraField::FIELD_TYPE_TEXTAREA:
                case \ExtraField::FIELD_TYPE_TEXT:

                    break;
            }*/

            $builder->add($variable, TextType::class, [
                'label' => $text,
                'required' => false,
                'by_reference' => false,
                'mapped' => false,
                'data' => $value,
            ]);
        }

        $builder->addEventListener(
            FormEvents::PRE_SUBMIT,
            function (FormEvent $event) use ($user, $extraFields): void {
                $data = $event->getData();

                /** @var ExtraField $extraField */
                foreach ($extraFields as $extraField) {
                    $newValue = $data[$extraField->getVariable()] ?? '';
                    if (empty($newValue)) {
                        continue;
                    }
                    $this->extraFieldValuesRepository->updateItemData($extraField, $user, $newValue);
                }
            }
        );
    }

    public function configureOptions(OptionsResolver $resolver): void
    {
        $resolver->setDefaults(
            [
                'data_class' => User::class,
            ]
        );
    }

    public function getName(): string
    {
        return 'chamilo_user_profile';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Form;
8
9			use Chamilo\CoreBundle\Entity\ExtraField;
10			use Chamilo\CoreBundle\Entity\ExtraFieldValues;
11			use Chamilo\CoreBundle\Entity\User;
12			use Chamilo\CoreBundle\Form\Type\IllustrationType;
13			use Chamilo\CoreBundle\Repository\ExtraFieldRepository;
14			use Chamilo\CoreBundle\Repository\ExtraFieldValuesRepository;
15			use Chamilo\CoreBundle\Repository\LanguageRepository;
16			use Symfony\Component\Form\AbstractType;
17			use Symfony\Component\Form\Extension\Core\Type\BirthdayType;
18			use Symfony\Component\Form\Extension\Core\Type\EmailType;
19			use Symfony\Component\Form\Extension\Core\Type\LocaleType;
20			use Symfony\Component\Form\Extension\Core\Type\TextareaType;
21			use Symfony\Component\Form\Extension\Core\Type\TextType;
22			use Symfony\Component\Form\Extension\Core\Type\TimezoneType;
23			use Symfony\Component\Form\Extension\Core\Type\UrlType;
24			use Symfony\Component\Form\FormBuilderInterface;
25			use Symfony\Component\Form\FormEvent;
26			use Symfony\Component\Form\FormEvents;
27			use Symfony\Component\OptionsResolver\OptionsResolver;
28			use Symfony\Component\Security\Core\Security;
29
30			class ProfileType extends AbstractType
31			{
32			private LanguageRepository $languageRepository;
33			private ExtraFieldValuesRepository $extraFieldValuesRepository;
34			private Security $security;
35
36			public function __construct(LanguageRepository $languageRepository, ExtraFieldValuesRepository $extraFieldValuesRepository, ExtraFieldRepository $extraFieldRepository, Security $security)
37			{
38			$this->languageRepository = $languageRepository;
39			$this->extraFieldValuesRepository = $extraFieldValuesRepository;
40			$this->extraFieldRepository = $extraFieldRepository;
41			$this->security = $security;
42			}
43
44			public function buildForm(FormBuilderInterface $builder, array $options): void
45			{
46			$languages = array_flip($this->languageRepository->getAllAvailableToArray());
47
48			$builder
49			->add('firstname', TextType::class, ['label' => 'Firstname', 'required' => true])
50			->add('lastname', TextType::class, ['label' => 'Lastname', 'required' => true])
51			->add('email', EmailType::class, ['label' => 'Email', 'required' => true])
52			//->add('official_code', TextType::class)
53			//->add('groups')
54			->add('locale', LocaleType::class, [
55			//'preferred_choices' => ['en', 'fr_FR', 'es_ES', 'pt', 'nl'],
56			'choices' => $languages,
57			'choice_loader' => null,
58			])
59			/*->add( 'dateOfBirth',
60			BirthdayType::class,
61			[
62			'label' => 'form.label_date_of_birth',
63			'required' => false,
64			'widget' => 'single_text',
65			]
66			)
67			->add(
68			'biography',
69			TextareaType::class,
70			[
71			'label' => 'form.label_biography',
72			'required' => false,
73			]
74			)*/
75			/*->add('locale', 'locale', array(
76			'label' => 'form.label_locale',
77			'required' => false,
78			))*/
79			->add('timezone', TimezoneType::class, ['label' => 'Timezone', 'required' => true])
80			->add('phone', TextType::class, ['label' => 'Phone number', 'required' => false])
81			->add(
82			'illustration',
83			IllustrationType::class,
84			['label' => 'Picture', 'required' => false, 'mapped' => false]
85			)
86			//->add('website', UrlType::class, ['label' => 'Website', 'required' => false])
87			/*->add(
88			'extraFieldValues',
89			CollectionType::class,
90			array(
91			'required' => false,
92			'allow_add' => true,
93			'allow_delete' => true,
94			'type' => 'chamilo_user_extra_field_value',
95			'by_reference' => false,
96			'prototype' => true,
97			'widget_add_btn' => ['label' => 'Add'],
98			'options' => array( // options for collection fields
99			'widget_remove_btn' => array('label' => 'Remove'),
100			'label_render' => false,
101			)
102			)
103			)*/
104			//->add('save', 'submit', array('label' => 'Update') )
105			;
106
107			$user = $this->security->getUser();
108
109			if (null === $user) {
110			return;
111			}
112
113			$extraFields = $this->extraFieldRepository->getExtraFields();
114			$values = $this->extraFieldValuesRepository->getExtraFieldValuesFromItem($user);
115
116			$data = [];
117			foreach ($values as $value) {
118			$data[$value->getField()->getVariable()] = $value->getValue();
119			}
120
121			foreach ($extraFields as $extraField) {
122			$text = $extraField->getDisplayText();
123			$variable = $extraField->getVariable();
124
125			$value = $data[$extraField->getVariable()] ?? '';
126
127			// @todo
128			/*switch ($extraField->getFieldType()) {
129			case \ExtraField::FIELD_TYPE_TEXTAREA:
130			case \ExtraField::FIELD_TYPE_TEXT:
131
132			break;
133			}*/
134
135			$builder->add($variable, TextType::class, [
136			'label' => $text,
137			'required' => false,
138			'by_reference' => false,
139			'mapped' => false,
140			'data' => $value,
141			]);
142			}
143
144			$builder->addEventListener(
145			FormEvents::PRE_SUBMIT,
146			function (FormEvent $event) use ($user, $extraFields): void {
147			$data = $event->getData();
148
149			/** @var ExtraField $extraField */
150			foreach ($extraFields as $extraField) {
151			$newValue = $data[$extraField->getVariable()] ?? '';
152			if (empty($newValue)) {
153			continue;
154			}
155			$this->extraFieldValuesRepository->updateItemData($extraField, $user, $newValue);
156			}
157			}
158			);
159			}
160
161			public function configureOptions(OptionsResolver $resolver): void
162			{
163			$resolver->setDefaults(
164			[
165			'data_class' => User::class,
166			]
167			);
168			}
169
170			public function getName(): string
171			{
172			return 'chamilo_user_profile';
173			}
174			}
175

chamilo / chamilo-lms

Push — master ( ee4256...c7999a )

ProfileType::buildForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like