Issues in EmphStrongTrait.php - New Issues - Inspection of "improved table rendering, added some tests" - cebe/markdown - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( af7bae...87972f )

by Carsten

created 2018-03-13 23:45 UTC

inline/EmphStrongTrait.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @copyright Copyright (c) 2014 Carsten Brandt
 * @license https://github.com/cebe/markdown/blob/master/LICENSE
 * @link https://github.com/cebe/markdown#readme
 */

namespace cebe\markdown\inline;

/**
 * Adds inline emphasizes and strong elements
 */
trait EmphStrongTrait
{
	/**
	 * Parses empathized and strong elements.
	 * @marker _
	 * @marker *
	 */
	protected function parseEmphStrong($text)
	{
		$marker = $text[0];

		if (!isset($text[1])) {
			return [['text', $text[0]], 1];
		}

		if ($marker == $text[1]) { // strong
			// work around a PHP bug that crashes with a segfault on too much regex backtrack
			// check whether the end marker exists in the text
			// https://github.com/erusev/parsedown/issues/443
			// https://bugs.php.net/bug.php?id=45735
			if (strpos($text, $marker . $marker, 2) === false) {
				return [['text', $text[0] . $text[1]], 2];
			}

			if ($marker == '*' && preg_match('/^[*]{2}((?:[^*]|[*][^*]*[*])+?)[*]{2}(?![*]{2})/s', $text, $matches) ||
				$marker == '_' && preg_match('/^__((?:[^_]|_[^_]*_)+?)__(?!__)/us', $text, $matches)) {

				return [
					[
						'strong',
						$this->parseInline($matches[1]),
					],
					strlen($matches[0])
				];
			}
		} else { // emph
			// work around a PHP bug that crashes with a segfault on too much regex backtrack
			// check whether the end marker exists in the text
			// https://github.com/erusev/parsedown/issues/443
			// https://bugs.php.net/bug.php?id=45735
			if (strpos($text, $marker, 1) === false) {
				return [['text', $text[0]], 1];
			}

			if ($marker == '*' && preg_match('/^[*]((?:[^*]|[*][*][^*]+?[*][*])+?)[*](?![*][^*])/s', $text, $matches) ||

				$marker == '_' && preg_match('/^_((?:[^_]|__[^_]*__)+?)_(?!_[^_])\b/us', $text, $matches)) {
				return [
					[
						'emph',
						$this->parseInline($matches[1]),
					],
					strlen($matches[0])
				];
			}
		}
		return [['text', $text[0]], 1];
	}

	protected function renderStrong($block)
	{
		return '<strong>' . $this->renderAbsy($block[1]) . '</strong>';
	}

	protected function renderEmph($block)
	{
		return '<em>' . $this->renderAbsy($block[1]) . '</em>';
	}
}


1			<?php
2			/**
3			* @copyright Copyright (c) 2014 Carsten Brandt
4			* @license https://github.com/cebe/markdown/blob/master/LICENSE
5			* @link https://github.com/cebe/markdown#readme
6			*/
7
8			namespace cebe\markdown\inline;
9
10			/**
11			* Adds inline emphasizes and strong elements
12			*/
13			trait EmphStrongTrait
14			{
15			/**
16			* Parses empathized and strong elements.
17			* @marker _
18			* @marker *
19			*/
20	33		protected function parseEmphStrong($text)
21			{
22	33		$marker = $text[0];
23
24	33		if (!isset($text[1])) {
25	3		return [['text', $text[0]], 1];
26			}
27
28	33		if ($marker == $text[1]) { // strong
29			// work around a PHP bug that crashes with a segfault on too much regex backtrack
30			// check whether the end marker exists in the text
31			// https://github.com/erusev/parsedown/issues/443
32			// https://bugs.php.net/bug.php?id=45735
33	27		if (strpos($text, $marker . $marker, 2) === false) {
34	6		return [['text', $text[0] . $text[1]], 2];
35			}
36
37	21	View Code Duplication	if ($marker == '' && preg_match('/^[]{2}((?:[^]\|[][^][])+?)[]{2}(?![*]{2})/s', $text, $matches) \|\|
38	21		$marker == '_' && preg_match('/^__((?:[^_]\|_[^_]*_)+?)__(?!__)/us', $text, $matches)) {
39
40			return [
41			[
42	21		'strong',
43	21		$this->parseInline($matches[1]),
44			],
45	21		strlen($matches[0])
46			];
47			}
48			} else { // emph
49			// work around a PHP bug that crashes with a segfault on too much regex backtrack
50			// check whether the end marker exists in the text
51			// https://github.com/erusev/parsedown/issues/443
52			// https://bugs.php.net/bug.php?id=45735
53	21		if (strpos($text, $marker, 1) === false) {
54	10		return [['text', $text[0]], 1];
55			}
56
57	16	View Code Duplication	if ($marker == '' && preg_match('/^[]((?:[^]\|[][][^]+?[][])+?)[](?![][^*])/s', $text, $matches) \|\|
			1 ignored issue – show Duplication introduced 2018-03-12 19:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58	16		$marker == '_' && preg_match('/^_((?:[^_]\|__[^_]*__)+?)_(?!_[^_])\b/us', $text, $matches)) {
59			return [
60			[
61	15		'emph',
62	15		$this->parseInline($matches[1]),
63			],
64	15		strlen($matches[0])
65			];
66			}
67			}
68	5		return [['text', $text[0]], 1];
69			}
70
71	21		protected function renderStrong($block)
72			{
73	21		return '<strong>' . $this->renderAbsy($block[1]) . '</strong>';
74			}
75
76	15		protected function renderEmph($block)
77			{
78	15		return '<em>' . $this->renderAbsy($block[1]) . '</em>';
79			}
80			}
81

cebe / markdown

Push — master ( af7bae...87972f )

inline/EmphStrongTrait.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like