Completed
Push — main ( 98c31b...2aeb61 )
by Jochen
03:25
created

manage_seats_in_area()   B

Complexity

Conditions 7

Size

Total Lines 52
Code Lines 36

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 41.4155

Importance

Changes 0
Metric Value
cc 7
eloc 36
nop 1
dl 0
loc 52
ccs 3
cts 27
cp 0.1111
crap 41.4155
rs 7.616
c 0
b 0
f 0

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
"""
2
byceps.blueprints.site.seating.views
3
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4
5
:Copyright: 2006-2020 Jochen Kupperschmidt
6
:License: Modified BSD, see LICENSE for details.
7
"""
8
9 1
from flask import abort, g, request
10
11 1
from ....services.party import service as party_service
12 1
from ....services.seating import area_service as seating_area_service
13 1
from ....services.seating.models.seat import Seat
14 1
from ....services.seating import seat_service
15 1
from ....services.seating.transfer.models import SeatID
16 1
from ....services.ticketing.models.ticket import Ticket as DbTicket
17 1
from ....services.ticketing import (
18
    exceptions as ticket_exceptions,
19
    ticket_seat_management_service,
20
    ticket_service,
21
)
22 1
from ....services.ticketing.transfer.models import TicketID
23 1
from ....util.framework.blueprint import create_blueprint
24 1
from ....util.framework.flash import flash_error, flash_success
25 1
from ....util.framework.templating import templated
26 1
from ....util.views import respond_no_content
27
28 1
from ...admin.seating.authorization import SeatingPermission
29 1
from ...common.authentication.decorators import login_required
30 1
from ...common.authorization.registry import permission_registry
31
32 1
from . import service
33
34
35 1
blueprint = create_blueprint('seating', __name__)
36
37
38 1
permission_registry.register_enum(SeatingPermission)
39
40
41 1
@blueprint.route('/')
42 1
@templated
43
def index():
44
    """List areas."""
45
    if g.party_id is None:
46
        # No party is configured for the current site.
47
        abort(404)
48
49
    areas = seating_area_service.get_areas_for_party(g.party_id)
50
51
    return {
52
        'areas': areas,
53
    }
54
55
56 1
@blueprint.route('/areas/<slug>')
57 1
@templated
58
def view_area(slug):
59
    """View area."""
60
    if g.party_id is None:
61
        # No party is configured for the current site.
62
        abort(404)
63
64
    area = seating_area_service.find_area_for_party_by_slug(g.party_id, slug)
65
    if area is None:
66
        abort(404)
67
68
    seat_management_enabled = _is_seat_management_enabled()
69
70
    seats = seat_service.get_seats_with_tickets_for_area(area.id)
71
72
    users_by_id = service.get_users(seats, [])
73
74
    seats = service.get_seats(seats, users_by_id)
75
76
    return {
77
        'area': area,
78
        'seat_management_enabled': seat_management_enabled,
79
        'seats': seats,
80
        'manage_mode': False,
81
    }
82
83
84 1
@blueprint.route('/areas/<slug>/manage_seats')
85 1
@login_required
86 1
@templated('site/seating/view_area')
87
def manage_seats_in_area(slug):
88
    """Manage seats for assigned tickets in area."""
89
    _abort_if_seat_management_disabled()
90
91
    area = seating_area_service.find_area_for_party_by_slug(g.party_id, slug)
92
    if area is None:
93
        abort(404)
94
95
    seat_management_enabled = _is_seat_management_enabled()
96
97
    seat_manager_id = None
98
    selected_ticket_id = None
99
100
    if _is_seating_admin(g.current_user):
101
        selected_ticket = _get_selected_ticket()
102
        if selected_ticket is not None:
103
            seat_manager_id = ticket.get_seat_manager().id
0 ignored issues
show
Comprehensibility Best Practice introduced by
The variable ticket does not seem to be defined.
Loading history...
104
            selected_ticket_id = ticket.id
105
106
    elif seat_management_enabled:
107
        seat_manager_id = g.current_user.id
108
109
    seats = seat_service.get_seats_with_tickets_for_area(area.id)
110
111
    if seat_manager_id is not None:
112
        tickets = ticket_service.find_tickets_for_seat_manager(
113
            seat_manager_id, g.party_id
114
        )
115
    else:
116
        tickets = []
117
118
    users_by_id = service.get_users(seats, tickets)
119
120
    seats = service.get_seats(seats, users_by_id)
121
122
    if seat_management_enabled:
123
        managed_tickets = list(
124
            service.get_managed_tickets(tickets, users_by_id)
125
        )
126
    else:
127
        managed_tickets = []
128
129
    return {
130
        'area': area,
131
        'seats': seats,
132
        'manage_mode': True,
133
        'seat_management_enabled': seat_management_enabled,
134
        'managed_tickets': managed_tickets,
135
        'selected_ticket_id': selected_ticket_id,
136
    }
137
138
139 1
def _get_selected_ticket():
140
    selected_ticket_code_arg = request.args.get('ticket_code')
141
    selected_ticket_id_arg = request.args.get('ticket_id')
142
143
    selected_ticket = None
144
145
    if selected_ticket_code_arg:
146
        ticket_code = selected_ticket_code_arg.upper()
147
        selected_ticket = ticket_service.find_ticket_by_code(ticket_code)
148
        if selected_ticket is None:
149
            flash_error(f'Ticket code "{ticket_code}" not found.')
150
151
    elif selected_ticket_id_arg:
152
        selected_ticket = ticket_service.find_ticket(selected_ticket_id_arg)
153
        if selected_ticket is None:
154
            flash_error(f'Ticket ID "{selected_ticket_id_arg}" not found.')
155
156
    return selected_ticket
157
158
159 1
@blueprint.route(
160
    '/ticket/<uuid:ticket_id>/seat/<uuid:seat_id>', methods=['POST']
161
)
162 1
@login_required
163 1
@respond_no_content
164
def occupy_seat(ticket_id, seat_id):
165
    """Use ticket to occupy seat."""
166
    _abort_if_seat_management_disabled()
167
168
    ticket = _get_ticket_or_404(ticket_id)
169
170
    manager = g.current_user
171
172
    if not ticket.is_seat_managed_by(manager.id) and not _is_seating_admin(
173
        manager
174
    ):
175
        flash_error(
176
            'Du bist nicht berechtigt, den Sitzplatz '
177
            f'für Ticket {ticket.code} zu verwalten.'
178
        )
179
        return
180
181
    seat = _get_seat_or_404(seat_id)
182
183
    if seat.is_occupied:
184
        flash_error(f'{seat.label} ist bereits belegt.')
185
        return
186
187
    try:
188
        ticket_seat_management_service.occupy_seat(
189
            ticket.id, seat.id, manager.id
190
        )
191
    except ticket_exceptions.SeatChangeDeniedForBundledTicket:
192
        flash_error(
193
            f'Ticket {ticket.code} gehört zu einem Paket '
194
            'und kann nicht einzeln verwaltet werden.'
195
        )
196
        return
197
    except ticket_exceptions.TicketCategoryMismatch:
198
        flash_error(
199
            f'Ticket {ticket.code} und {seat.label} haben '
200
            'unterschiedliche Kategorien.'
201
        )
202
        return
203
    except ValueError:
204
        abort(404)
205
206
    flash_success(f'{seat.label} wurde mit Ticket {ticket.code} reserviert.')
207
208
209 1
@blueprint.route('/ticket/<uuid:ticket_id>/seat', methods=['DELETE'])
210 1
@login_required
211 1
@respond_no_content
212
def release_seat(ticket_id):
213
    """Release the seat."""
214
    _abort_if_seat_management_disabled()
215
216
    ticket = _get_ticket_or_404(ticket_id)
217
218
    if not ticket.occupied_seat:
219
        flash_error(f'Ticket {ticket.code} belegt keinen Sitzplatz.')
220
        return
221
222
    manager = g.current_user
223
224
    if not ticket.is_seat_managed_by(manager.id) and not _is_seating_admin(
225
        manager
226
    ):
227
        flash_error(
228
            'Du bist nicht berechtigt, den Sitzplatz '
229
            f'für Ticket {ticket.code} zu verwalten.'
230
        )
231
        return
232
233
    seat = ticket.occupied_seat
234
235
    try:
236
        ticket_seat_management_service.release_seat(ticket.id, manager.id)
237
    except ticket_exceptions.SeatChangeDeniedForBundledTicket:
238
        flash_error(
239
            f'Ticket {ticket.code} gehört zu einem Paket '
240
            'und kann nicht einzeln verwaltet werden.'
241
        )
242
        return
243
244
    flash_success(f'{seat.label} wurde freigegeben.')
245
246
247 1
def _abort_if_seat_management_disabled() -> None:
248
    if not _is_seat_management_enabled():
249
        flash_error('Sitzplätze können derzeit nicht verändert werden.')
250
        return
251
252
253 1
def _is_seat_management_enabled():
254
    if g.current_user.is_anonymous:
255
        return False
256
257
    if g.party_id is None:
258
        return False
259
260
    if _is_seating_admin(g.current_user):
261
        return True
262
263
    party = party_service.get_party(g.party_id)
264
    return party.seat_management_enabled
265
266
267 1
def _is_seating_admin(user) -> bool:
268
    return user.has_permission(SeatingPermission.administrate)
269
270
271 1
def _get_ticket_or_404(ticket_id: TicketID) -> DbTicket:
272
    ticket = ticket_service.find_ticket(ticket_id)
273
274
    if (ticket is None) or ticket.revoked:
275
        abort(404)
276
277
    return ticket
278
279
280 1
def _get_seat_or_404(seat_id: SeatID) -> Seat:
281
    seat = seat_service.find_seat(seat_id)
282
283
    if seat is None:
284
        abort(404)
285
286
    return seat
287