Issues in dashboard.page.php - Failed Issues - Inspection of "Combine PR #353 with #363 & Code formatting" - brusselopole/Worldopole - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#371)

unknown

created 2019-02-03 13:06 UTC

pages/dashboard.page.php (14 issues)

Labels

Coding Style 14

Severity

Informational 14

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<header id="single-header">
	<div class="row">
		<div class="col-md-12 text-center">
			<h1>
				<?= $locales->DASHBOARD_TITLE; ?> <br/>
				<small><?= $locales->DASHBOARD_SUBTITLE; ?></small>
			</h1>
			
		</div>
	</div>
</header>

<div class="row">
	
	<div class="col-md-12">

		<div class="row area">
		
			<div class="col-md-12">
				<h2 class="sub-title"><?= $locales->DASHBOARD_SPAWN_TITLE; ?></h2>
			</div>
		
			<div class="col-md-12">
			
				<h4><?= $locales->DASHBOARD_SPAWN_TOTAL; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<div style="height:30vh">
					<canvas id="total_spawn"></canvas>
				</div>
			</div>
			
			<div class="col-md-3">
				
				<h4><?= $locales->VERYCOMMON; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<div style="height:15vh">
					<canvas id="very_common"></canvas>
				</div>
			</div>
			
			<div class="col-md-3">
				
				<h4><?= $locales->COMMON; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<div style="height:15vh">
					<canvas id="common"></canvas>
				</div>
			
			</div>
			
			<div class="col-md-3">
				
				<h4><?= $locales->RARE; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<div style="height:15vh">
					<canvas id="rare"></canvas>
				</div>
			</div>
			
			<div class="col-md-3">
				
				<h4><?= $locales->MYTHIC; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<div style="height:15vh">
					<canvas id="mythics"></canvas>
				</div>
			</div>
		
		</div>
		
		<div class="row area">
			
			<div class="col-md-12">
				<h2 class="sub-title"><strong><?= $locales->TEAM; ?></strong> <?= $locales->PERFORMANCE; ?></h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</div>
			
			<div class="col-md-12">
				<h4><?= $locales->DASHBOARD_PRESTIGE_AVERAGE; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</div>
			
			<div class="col-md-12">
				<div style="height:30vh">
					<canvas id="team_av"></canvas>
				</div>
			</div>
		
			
			<div class="col-md-12">
				<h4><?= $locales->DASHBOARD_GYM_OWNED_PERFORMANCE; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</div>
			
			<div class="col-md-12">
				<div style="height:30vh">
					<canvas id="team_gym"></canvas>
				</div>
			</div>
			
		
		</div>

<?php if (true === !$config->system->no_lures) {

    ?>

    <?php if ($config->system->captcha_support) {
        ?>
        <div class="row area">
    <?php
    } else {

        ?>
        <div class="row">
    <?php
    } ?>

			<div class="col-md-12">
				<h2 class="sub-title"><strong><?= $locales->POKESTOPS; ?></strong> <?= $locales->DASHBOARD_ACTIVITY; ?></h2>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
			</div>
		
			<div class="col-md-12">
			
				<h4><?= $locales->DASHBOARD_LURES; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<div style="height:30vh">
					<canvas id="lures"></canvas>
				</div>
			</div>

		</div>

<?php
} ?>


<?php if ($config->system->captcha_support) {
        ?>
		<div class="row">

			<div class="col-md-12">
				<h2 class="sub-title"><strong>reCaptcha</strong> <?= $locales->DASHBOARD_ACTIVITY; ?></h2>
			</div>

			<div class="col-md-12">
			
				<h4><?= $locales->DASHBOARD_CAPTCHA; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
// Bad
$a = 5; $b = 6; $c = 7;

// Good
$a = 5;
$b = 6;
$c = 7;
				<div style="height:30vh">
					<canvas id="captcha"></canvas>
				</div>
			</div>


		</div>
<?php
    } ?>


	
	</div>


</div>


1			<header id="single-header">
2			<div class="row">
3			<div class="col-md-12 text-center">
4			<h1>
5			<?= $locales->DASHBOARD_TITLE; ?> <br/>
6			<small><?= $locales->DASHBOARD_SUBTITLE; ?></small>
7			</h1>
8
9			</div>
10			</div>
11			</header>
12
13			<div class="row">
14
15			<div class="col-md-12">
16
17			<div class="row area">
18
19			<div class="col-md-12">
20			<h2 class="sub-title"><?= $locales->DASHBOARD_SPAWN_TITLE; ?></h2>
21			</div>
22
23			<div class="col-md-12">
24
25			<h4><?= $locales->DASHBOARD_SPAWN_TOTAL; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
26			<div style="height:30vh">
27			<canvas id="total_spawn"></canvas>
28			</div>
29			</div>
30
31			<div class="col-md-3">
32
33			<h4><?= $locales->VERYCOMMON; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
34			<div style="height:15vh">
35			<canvas id="very_common"></canvas>
36			</div>
37			</div>
38
39			<div class="col-md-3">
40
41			<h4><?= $locales->COMMON; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
42			<div style="height:15vh">
43			<canvas id="common"></canvas>
44			</div>
45
46			</div>
47
48			<div class="col-md-3">
49
50			<h4><?= $locales->RARE; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
51			<div style="height:15vh">
52			<canvas id="rare"></canvas>
53			</div>
54			</div>
55
56			<div class="col-md-3">
57
58			<h4><?= $locales->MYTHIC; ?> <small><?= $locales->DASHBOARD_LAST24HOURS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
59			<div style="height:15vh">
60			<canvas id="mythics"></canvas>
61			</div>
62			</div>
63
64			</div>
65
66			<div class="row area">
67
68			<div class="col-md-12">
69			<h2 class="sub-title"><strong><?= $locales->TEAM; ?></strong> <?= $locales->PERFORMANCE; ?></h2>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
70			</div>
71
72			<div class="col-md-12">
73			<h4><?= $locales->DASHBOARD_PRESTIGE_AVERAGE; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
74			</div>
75
76			<div class="col-md-12">
77			<div style="height:30vh">
78			<canvas id="team_av"></canvas>
79			</div>
80			</div>
81
82
83			<div class="col-md-12">
84			<h4><?= $locales->DASHBOARD_GYM_OWNED_PERFORMANCE; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
85			</div>
86
87			<div class="col-md-12">
88			<div style="height:30vh">
89			<canvas id="team_gym"></canvas>
90			</div>
91			</div>
92
93
94			</div>
95
96			<?php if (true === !$config->system->no_lures) {
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The opening PHP tag must be the first content in the file Loading history...
97			?>
98
99			<?php if ($config->system->captcha_support) {
100			?>
101			<div class="row area">
102			<?php
103			} else {
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Closing brace indented incorrectly; expected 0 spaces, found 4 Loading history...
104			?>
105			<div class="row">
106			<?php
107			} ?>
108
109			<div class="col-md-12">
110			<h2 class="sub-title"><strong><?= $locales->POKESTOPS; ?></strong> <?= $locales->DASHBOARD_ACTIVITY; ?></h2>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
111			</div>
112
113			<div class="col-md-12">
114
115			<h4><?= $locales->DASHBOARD_LURES; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
116			<div style="height:30vh">
117			<canvas id="lures"></canvas>
118			</div>
119			</div>
120
121			</div>
122
123			<?php
124			} ?>
125
126
127			<?php if ($config->system->captcha_support) {
128			?>
129			<div class="row">
130
131			<div class="col-md-12">
132			<h2 class="sub-title"><strong>reCaptcha</strong> <?= $locales->DASHBOARD_ACTIVITY; ?></h2>
133			</div>
134
135			<div class="col-md-12">
136
137			<h4><?= $locales->DASHBOARD_CAPTCHA; ?> <small><?= $locales->DASHBOARD_LAST7DAYS; ?></small></h4>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to place each PHP statement on a line by itself. Let’s take a look at an example: // Bad $a = 5; $b = 6; $c = 7; // Good $a = 5; $b = 6; $c = 7; Loading history...
138			<div style="height:30vh">
139			<canvas id="captcha"></canvas>
140			</div>
141			</div>
142
143
144			</div>
145			<?php
146			} ?>
			0 ignored issues – show Coding Style introduced 2019-02-03 13:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Closing brace indented incorrectly; expected 0 spaces, found 4 Loading history...
147
148
149			</div>
150
151
152			</div>
153

brusselopole / Worldopole

Pull Request — master (#371)

pages/dashboard.page.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like