TarantoolProvider::register() - Code Metrics - Inspection of "act as admin" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 13738a...da5e92 )

by Dmitry

created 2019-05-21 20:59 UTC

TarantoolProvider::register() B

↳ Parent: TarantoolProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	36
CRAP Score	1.0018

Importance

Changes

Metric	Value
dl	0
loc	63
ccs	36
cts	41
cp	0.878
rs	8.8072
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1.0018

1 Method

Rating	Name	Duplication	Size	Complexity
A	TarantoolProvider.php$0 ➔ afterInstantiate()	0	5	1

How to fix Long Method

<?php

namespace Basis\Provider;

use Basis\Config;
use Basis\Filesystem;
use League\Container\ServiceProvider\AbstractServiceProvider;
use Tarantool\Client\Client;
use Tarantool\Mapper\Bootstrap;
use Tarantool\Mapper\Entity;
use Tarantool\Mapper\Mapper;
use Tarantool\Mapper\Plugin;
use Tarantool\Mapper\Plugin\Annotation;
use Tarantool\Mapper\Plugin\Sequence;
use Tarantool\Mapper\Plugin\Spy;
use Tarantool\Mapper\Plugin\Temporal;
use Tarantool\Mapper\Schema;

class TarantoolProvider extends AbstractServiceProvider
{
    protected $provides = [
        Bootstrap::class,
        Client::class,
        Mapper::class,
        Schema::class,
        Spy::class,
        Temporal::class,
    ];

    public function register()
    {
        $this->container->share(Bootstrap::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return $this->container->get(Mapper::class)->getBootstrap();
        });

        $this->getContainer()->share(Client::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $client = Client::fromDefaults();
            $client->evaluate("box.session.su('admin')");
            return $client;
        });

        $this->getContainer()->share(Mapper::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $mapper = new Mapper($this->getContainer()->get(Client::class));
            $filesystem = $this->getContainer()->get(Filesystem::class);

            $mapperCache = $filesystem->getPath('.cache/mapper-meta.php');
            if (file_exists($mapperCache)) {
                $meta = include $mapperCache;
                $mapper->setMeta($meta);
            }

            $annotation = $mapper->getPlugin(Annotation::class);

            foreach ($filesystem->listClasses('Entity') as $class) {
                $annotation->register($class);
            }
            foreach ($filesystem->listClasses('Repository') as $class) {
                $annotation->register($class);
            }

            $mapper->getPlugin(Sequence::class);
            $mapper->getPlugin(Spy::class);

            $mapper->getPlugin(Temporal::class)
                ->getAggregator()
                ->setReferenceAggregation(false);

            $mapper->application = $this->getContainer();


            $mapper->getPlugin(new class($mapper) extends Plugin {
                public function afterInstantiate(Entity $entity) : Entity
                {
                    $entity->app = $this->mapper->application;

                    return $entity;
                }
            });

            return $mapper;
        });

        $this->getContainer()->share(Schema::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return $this->getContainer()->get(Mapper::class)->getSchema();
        });

        $this->getContainer()->share(Spy::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return $this->getContainer()->get(Mapper::class)->getPlugin(Spy::class);
        });

        $this->getContainer()->share(Temporal::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return $this->getContainer()->get(Mapper::class)->getPlugin(Temporal::class);
        });
    }
}


Push — master ( 13738a...da5e92 )

TarantoolProvider::register() B

Complexity

Size

Duplication

Code Coverage

Importance

1 Method

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Basis\Provider;
4
5		use Basis\Config;
6		use Basis\Filesystem;
7		use League\Container\ServiceProvider\AbstractServiceProvider;
8		use Tarantool\Client\Client;
9		use Tarantool\Mapper\Bootstrap;
10		use Tarantool\Mapper\Entity;
11		use Tarantool\Mapper\Mapper;
12		use Tarantool\Mapper\Plugin;
13		use Tarantool\Mapper\Plugin\Annotation;
14		use Tarantool\Mapper\Plugin\Sequence;
15		use Tarantool\Mapper\Plugin\Spy;
16		use Tarantool\Mapper\Plugin\Temporal;
17		use Tarantool\Mapper\Schema;
18
19		class TarantoolProvider extends AbstractServiceProvider
20		{
21		protected $provides = [
22		Bootstrap::class,
23		Client::class,
24		Mapper::class,
25		Schema::class,
26		Spy::class,
27		Temporal::class,
28		];
29
30		public function register()
31		{
32	38	$this->container->share(Bootstrap::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
33	38	return $this->container->get(Mapper::class)->getBootstrap();
34	38	});
35
36	38	$this->getContainer()->share(Client::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37	38	$client = Client::fromDefaults();
38	38	$client->evaluate("box.session.su('admin')");
39	38	return $client;
40	38	});
41
42	38	$this->getContainer()->share(Mapper::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43	38	$mapper = new Mapper($this->getContainer()->get(Client::class));
44	38	$filesystem = $this->getContainer()->get(Filesystem::class);
45
46	38	$mapperCache = $filesystem->getPath('.cache/mapper-meta.php');
47	38	if (file_exists($mapperCache)) {
48		$meta = include $mapperCache;
49		$mapper->setMeta($meta);
50		}
51
52	38	$annotation = $mapper->getPlugin(Annotation::class);
53
54	38	foreach ($filesystem->listClasses('Entity') as $class) {
55	38	$annotation->register($class);
56		}
57	38	foreach ($filesystem->listClasses('Repository') as $class) {
58	38	$annotation->register($class);
59		}
60
61	38	$mapper->getPlugin(Sequence::class);
62	38	$mapper->getPlugin(Spy::class);
63
64	38	$mapper->getPlugin(Temporal::class)
65	38	->getAggregator()
66	38	->setReferenceAggregation(false);
67
68	38	$mapper->application = $this->getContainer();
		0 ignored issues – show Bug introduced 2017-05-29 16:50 UTC by Report Bug Copy Issue Report The property `application` does not seem to exist in `Tarantool\Mapper\Mapper`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
69
70		$mapper->getPlugin(new class($mapper) extends Plugin {
71	38	public function afterInstantiate(Entity $entity) : Entity
72		{
73	38	$entity->app = $this->mapper->application;
		0 ignored issues – show Bug introduced 2017-05-29 16:50 UTC by Report Bug Copy Issue Report The property `app` does not seem to exist in `Tarantool\Mapper\Entity`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history... Bug introduced 2017-05-29 16:50 UTC by Report Bug Copy Issue Report The property `application` does not seem to exist in `Tarantool\Mapper\Mapper`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
74	38	return $entity;
75		}
76		});
77
78	38	return $mapper;
79	38	});
80
81	38	$this->getContainer()->share(Schema::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
82		return $this->getContainer()->get(Mapper::class)->getSchema();
83	38	});
84
85	38	$this->getContainer()->share(Spy::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
86		return $this->getContainer()->get(Mapper::class)->getPlugin(Spy::class);
87	38	});
88
89	38	$this->getContainer()->share(Temporal::class, function () {
		0 ignored issues – show Bug introduced 2019-05-21 20:58 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
90		return $this->getContainer()->get(Mapper::class)->getPlugin(Temporal::class);
91	38	});
92	38	}
93		}
94

basis-company / framework.php

Push — master ( 13738a...da5e92 )

TarantoolProvider::register() B

Complexity

Size

Duplication

Code Coverage

Importance

1 Method

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like