OpenTelemetryProvider::register() - Code Metrics - Inspection of "use opentelemetry tracing" - basis-company/framework.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f08c31...be488a )

by Dmitry

created 2019-10-08 20:07 UTC

OpenTelemetryProvider::register() A

↳ Parent: OpenTelemetryProvider

Complexity

Conditions	3
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3.9953

Importance

Changes

Metric	Value
dl	0
loc	34
ccs	13
cts	25
cp	0.52
rs	9.376
c	0
b	0
f	0
cc	3
nc	1
nop	0
crap	3.9953

<?php

namespace Basis\Provider;

use League\Container\ServiceProvider\AbstractServiceProvider;
use OpenTelemetry\Exporter;
use OpenTelemetry\Exporter\BasisExporter;
use OpenTelemetry\Tracing\SpanContext;
use OpenTelemetry\Tracing\Tracer;
use OpenTelemetry\Transport;
use OpenTelemetry\Transport\TarantoolQueueTransport;

class OpenTelemetryProvider extends AbstractServiceProvider
{
    protected $provides = [
        BasisExporter::class,
        Exporter::class,
        TarantoolQueueTransport::class,
        Tracer::class,
        Transport::class,
    ];

    public function register()
    {
        $this->container->share(BasisExporter::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return new BasisExporter();
        });

        $this->container->share(Exporter::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return $this->getContainer()->get(BasisExporter::class);
        });

        $this->container->share(TarantoolQueueTransport::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return (new TarantoolQueueTransport())
                ->setQueue(
                    $this->getContainer()->getQueue('audit.tracing')
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                );
        });

        $this->container->share(Tracer::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if (array_key_exists('rpc', $_REQUEST)) {
                $data = json_decode($_REQUEST['rpc']);
                if (property_exists($data, 'span')) {
                    $traceId = $data->span->traceId;
                    $spanId = $data->span->spanId;
                    $context = SpanContext::restore($traceId, $spanId);
                    return new Tracer($context);
                }
            }
            return new Tracer();
        });

        $this->container->share(Transport::class, function () {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return $this->getContainer()->get(TarantoolQueueTransport::class);
        });
    }
}


Push — master ( f08c31...be488a )

OpenTelemetryProvider::register() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Basis\Provider;
4
5		use League\Container\ServiceProvider\AbstractServiceProvider;
6		use OpenTelemetry\Exporter;
7		use OpenTelemetry\Exporter\BasisExporter;
8		use OpenTelemetry\Tracing\SpanContext;
9		use OpenTelemetry\Tracing\Tracer;
10		use OpenTelemetry\Transport;
11		use OpenTelemetry\Transport\TarantoolQueueTransport;
12
13		class OpenTelemetryProvider extends AbstractServiceProvider
14		{
15		protected $provides = [
16		BasisExporter::class,
17		Exporter::class,
18		TarantoolQueueTransport::class,
19		Tracer::class,
20		Transport::class,
21		];
22
23		public function register()
24		{
25	52	$this->container->share(BasisExporter::class, function () {
		0 ignored issues – show Bug introduced 2019-10-08 20:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
26		return new BasisExporter();
27	52	});
28
29	52	$this->container->share(Exporter::class, function () {
		0 ignored issues – show Bug introduced 2019-10-08 20:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
30		return $this->getContainer()->get(BasisExporter::class);
31	52	});
32
33	52	$this->container->share(TarantoolQueueTransport::class, function () {
		0 ignored issues – show Bug introduced 2019-10-08 20:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
34		return (new TarantoolQueueTransport())
35		->setQueue(
36		$this->getContainer()->getQueue('audit.tracing')
		0 ignored issues – show Bug introduced 2019-10-08 20:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `getQueue()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
37		);
38	52	});
39
40	52	$this->container->share(Tracer::class, function () {
		0 ignored issues – show Bug introduced 2019-10-08 20:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
41	52	if (array_key_exists('rpc', $_REQUEST)) {
42		$data = json_decode($_REQUEST['rpc']);
43		if (property_exists($data, 'span')) {
44		$traceId = $data->span->traceId;
45		$spanId = $data->span->spanId;
46		$context = SpanContext::restore($traceId, $spanId);
47		return new Tracer($context);
48		}
49		}
50	52	return new Tracer();
51	52	});
52
53	52	$this->container->share(Transport::class, function () {
		0 ignored issues – show Bug introduced 2019-10-08 20:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Psr\Container\ContainerInterface` as the method `share()` does only exist in the following implementations of said interface: `Basis\Application`, `Basis\Test\Application`, `League\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
54		return $this->getContainer()->get(TarantoolQueueTransport::class);
55	52	});
56	52	}
57		}
58

basis-company / framework.php

Push — master ( f08c31...be488a )

OpenTelemetryProvider::register() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like