Issues (127)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Containers/Payment/Gateway/PaymentsGateway.php (1 issue)

Labels
Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace App\Containers\Payment\Gateway;
4
5
use App\Containers\Payment\Contracts\ChargeableInterface;
6
use App\Containers\Payment\Contracts\PaymentChargerInterface;
7
use App\Containers\Payment\Exceptions\ChargerTaskDoesNotImplementInterfaceException;
8
use App\Containers\Payment\Exceptions\NoChargeTaskForPaymentGatewayDefinedException;
9
use App\Containers\Payment\Models\PaymentAccount;
10
use App\Containers\Payment\Models\PaymentTransaction;
11
use App\Containers\Payment\Tasks\CheckIfPaymentAccountBelongsToUserTask;
12
use Illuminate\Support\Facades\App;
13
use Illuminate\Support\Facades\Config;
14
15
/**
16
 * Class PaymentsGateway
17
 *
18
 * @author  Johannes Schobel <[email protected]>
19
 * @author  Mahmoud Zalt  <[email protected]>
20
 */
21
class PaymentsGateway
22
{
23
24
    /**
25
     * @param ChargeableInterface $chargeable
26
     * @param PaymentAccount      $account
27
     * @param                     $amount
28
     * @param string|null         $currency
29
     *
30
     * @return PaymentTransaction
31
     * @throws ChargerTaskDoesNotImplementInterfaceException
32
     * @throws NoChargeTaskForPaymentGatewayDefinedException
33
     */
34
    public function charge(ChargeableInterface $chargeable, PaymentAccount $account, $amount, $currency = null) : PaymentTransaction
35
    {
36
        $currency = ($currency === null) ? Config::get('payment.currency') : $currency;
37
38
        // check, if the account is owned by user to be charged
39
        App::make(CheckIfPaymentAccountBelongsToUserTask::class)->run($chargeable, $account);
40
41
        $typedAccount = $account->accountable;
42
43
        $chargerTaskTaskName = Config::get('payment-container.gateways.' . $typedAccount->getPaymentGatewaySlug() . '.charge_task', null);
44
45
        if ($chargerTaskTaskName === null) {
46
            throw new NoChargeTaskForPaymentGatewayDefinedException();
47
        }
48
49
        // create the task
50
        $chargerTask = App::make($chargerTaskTaskName);
51
52
        // check if it implements the required interface
53
        if (!$chargerTask instanceof PaymentChargerInterface) {
54
            throw new ChargerTaskDoesNotImplementInterfaceException();
55
        }
56
57
        /** @var PaymentTransaction $transaction */
58
        $transaction = $chargerTask->charge($chargeable, $typedAccount, $amount, $currency);
59
60
        // now set some details of the transaction
61
        $transaction->user_id = $chargeable->id;
0 ignored issues
show
Accessing id on the interface App\Containers\Payment\C...cts\ChargeableInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
62
        $transaction->gateway = $typedAccount->getPaymentGatewayReadableName();
63
        $transaction->amount = $amount;
64
        $transaction->currency = $currency;
65
66
        $transaction->save();
67
68
        return $transaction;
69
    }
70
}
71