GetAllClientsTest   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 55
Duplicated Lines 36.36 %

Coupling/Cohesion

Components 1
Dependencies 3

Importance

Changes 0
Metric Value
wmc 2
lcom 1
cbo 3
dl 20
loc 55
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A testGetAllClientsByAdmin_() 20 20 1
A testGetAllClientsByNonAdmin_() 0 16 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace App\Containers\User\UI\API\Tests\Functional;
4
5
use App\Containers\User\Models\User;
6
use App\Containers\User\Tests\ApiTestCase;
7
8
/**
9
 * Class GetAllUsersTest.
10
 *
11
 * @group user
12
 * @group api
13
 *
14
 * @author  Mahmoud Zalt <[email protected]>
15
 */
16
class GetAllClientsTest extends ApiTestCase
17
{
18
19
    protected $endpoint = '[email protected]/clients';
20
21
    protected $access = [
22
        'roles'       => '',
23
        'permissions' => 'list-users',
24
    ];
25
26
    /**
27
     * @test
28
     */
29 View Code Duplication
    public function testGetAllClientsByAdmin_()
0 ignored issues
show
Duplication introduced by Mahmoud Zalt
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
30
    {
31
        // should be returned
32
        factory(User::class, 3)->states('client')->create();
33
34
        // should not be returned
35
        factory(User::class)->create();
36
37
        // send the HTTP request
38
        $response = $this->makeCall();
39
40
        // assert response status is correct
41
        $response->assertStatus(200);
42
43
        // convert JSON response string to Object
44
        $responseContent = $this->getResponseContentObject();
45
46
        // assert the returned data size is correct
47
        $this->assertCount(3, $responseContent->data);
48
    }
49
50
    /**
51
     * @test
52
     */
53
    public function testGetAllClientsByNonAdmin_()
54
    {
55
        // prepare a user without any roles or permissions
56
        $this->getTestingUserWithoutAccess();
57
58
        // send the HTTP request
59
        $response = $this->makeCall();
60
61
        // assert response status is correct
62
        $response->assertStatus(403);
63
64
        $this->assertResponseContainKeyValue([
65
            'errors' => 'You have no access to this resource!',
66
            'message' => 'This action is unauthorized.',
67
        ]);
68
    }
69
70
}
71