GetAllAdminsTest   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 58
Duplicated Lines 67.24 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 0
Metric Value
wmc 2
lcom 0
cbo 2
dl 39
loc 58
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A testGetAllAdmins_() 21 21 1
A testGetAllAdminsByNonAdmin_() 18 18 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace App\Containers\User\UI\API\Tests\Functional;
4
5
use App\Containers\User\Models\User;
6
use App\Containers\User\Tests\ApiTestCase;
7
8
/**
9
 * Class GetAllUsersTest.
10
 *
11
 * @group user
12
 * @group api
13
 *
14
 * @author  Mahmoud Zalt <[email protected]>
15
 */
16
class GetAllAdminsTest extends ApiTestCase
17
{
18
19
    protected $endpoint = '[email protected]/admins';
20
21
    protected $access = [
22
        'roles'       => '',
23
        'permissions' => 'list-users',
24
    ];
25
26
    /**
27
     * @test
28
     */
29 View Code Duplication
    public function testGetAllAdmins_()
0 ignored issues
show
Duplication introduced by Mahmoud Zalt
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
30
    {
31
        // create some non-admin users
32
        $users = factory(User::class, 2)->create();
0 ignored issues
show
Unused Code introduced by Mahmoud Zalt
$users is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
33
34
        // should not be returned
35
        factory(User::class)->states('client')->create();
36
37
        // send the HTTP request
38
        $response = $this->makeCall();
39
40
        // assert response status is correct
41
        $response->assertStatus(200);
42
43
        // convert JSON response string to Object
44
        $responseContent = $this->getResponseContentObject();
45
46
        // assert the returned data size is correct
47
        $this->assertCount(4,
48
            $responseContent->data); // 2 (fake in this test) + 1 (that is logged in) + 1 (seeded super admin)
49
    }
50
51
    /**
52
     * @test
53
     */
54 View Code Duplication
    public function testGetAllAdminsByNonAdmin_()
0 ignored issues
show
Duplication introduced by Mustafa Elkhalifa
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
55
    {
56
        $this->getTestingUserWithoutAccess();
57
58
        // create some fake users
59
        factory(User::class, 2)->create();
60
61
        // send the HTTP request
62
        $response = $this->makeCall();
63
64
        // assert response status is correct
65
        $response->assertStatus(403);
66
67
        $this->assertResponseContainKeyValue([
68
            'errors' => 'You have no access to this resource!',
69
            'message' => 'This action is unauthorized.',
70
        ]);
71
    }
72
73
}
74