Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | class CheckLocalizationMiddlewareTest extends ApiTestCase |
||
15 | { |
||
16 | |||
17 | // the endpoint to be called within this test (e.g., [email protected]/users) |
||
18 | protected $endpoint = '[email protected]/localizations'; |
||
19 | |||
20 | // fake some access rights |
||
21 | protected $access = [ |
||
22 | 'permissions' => '', |
||
23 | 'roles' => '', |
||
24 | ]; |
||
25 | |||
26 | /** |
||
27 | * @test |
||
28 | */ |
||
29 | View Code Duplication | public function test_if_middleware_sets_default_app_language() |
|
45 | |||
46 | View Code Duplication | public function test_if_middleware_sets_custom_language() |
|
64 | |||
65 | public function test_if_middleware_throws_error_on_wrong_language() |
||
80 | |||
81 | } |
||
82 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.