UnderscoreOperationPathResolver::resolveOperationPath() - Code Metrics - Inspection of "Merge pull request #1245 from soyuka/swagger-subre..." - api-platform/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 131c91...75b368 )

by Kévin

created 2017-07-19 18:05 UTC

resolveOperationPath() A

↳ Parent: UnderscoreOperationPathResolver

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes

Metric	Value
dl	12
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	3

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\PathResolver;

use ApiPlatform\Core\Operation\UnderscorePathSegmentNameGenerator;

/**
 * Generates a path with words separated by underscores.
 *
 * @author Paul Le Corre <[email protected]>
 */
final class UnderscoreOperationPathResolver implements OperationPathResolverInterface

{
    /**
     * {@inheritdoc}
     */
    public function resolveOperationPath(string $resourceShortName, array $operation, $operationType/*, string $operationName = null*/): string
    {
        @trigger_error(sprintf('The use of %s is deprecated since 2.1. Please use PathSegmentNameGenerator instead.', __CLASS__), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        if (func_num_args() >= 4) {
            $operationName = func_get_arg(3);
        } else {
            $operationName = null;
        }

        return (new OperationPathResolver(new UnderscorePathSegmentNameGenerator()))->resolveOperationPath($resourceShortName, $operation, $operationType, $operationName);

    }
}


1		<?php
2
3		/*
4		* This file is part of the API Platform project.
5		*
6		* (c) Kévin Dunglas <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		declare(strict_types=1);
13
14		namespace ApiPlatform\Core\PathResolver;
15
16		use ApiPlatform\Core\Operation\UnderscorePathSegmentNameGenerator;
17
18		/**
19		* Generates a path with words separated by underscores.
20		*
21		* @author Paul Le Corre <[email protected]>
22		*/
23	View Code Duplication	final class UnderscoreOperationPathResolver implements OperationPathResolverInterface
		0 ignored issues – show Duplication introduced 2017-07-12 13:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		{
25		/**
26		* {@inheritdoc}
27		*/
28		public function resolveOperationPath(string $resourceShortName, array $operation, $operationType/, string $operationName = null/): string
29		{
30		@trigger_error(sprintf('The use of %s is deprecated since 2.1. Please use PathSegmentNameGenerator instead.', __CLASS__), E_USER_DEPRECATED);
		0 ignored issues – show Security Best Practice introduced 2017-07-12 13:05 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
31
32		if (func_num_args() >= 4) {
33		$operationName = func_get_arg(3);
34		} else {
35		$operationName = null;
36		}
37
38		return (new OperationPathResolver(new UnderscorePathSegmentNameGenerator()))->resolveOperationPath($resourceShortName, $operation, $operationType, $operationName);
		0 ignored issues – show Unused Code introduced 2017-07-12 13:05 UTC by Report Bug Copy Issue Report The call to `OperationPathResolver::resolveOperationPath()` has too many arguments starting with `$operationName`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
39		}
40		}
41

api-platform / core

Push — master ( 131c91...75b368 )

resolveOperationPath() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like