CommentsController::store() - Code Metrics - angelov/storgman - Measure and Improve Code Quality continuously with Scrutinizer

CommentsController::store() A
last analyzed 2017-02-01 19:30 UTC

↳ Parent: CommentsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	6
nc	1
nop	2

<?php

/**
 * Storgman - Student Organizations Management
 * Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
 *
 * This file is part of Storgman.
 *
 * Storgman is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * Storgman is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with Storgman.  If not, see <http://www.gnu.org/licenses/>.
 *
 * @package Storgman
 * @copyright Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
 * @license https://github.com/angelov/storgman/blob/master/LICENSE
 * @author Dejan Angelov <[email protected]>
 */

namespace Angelov\Storgman\Events\Comments\Http\Controllers;

use Angelov\Storgman\Core\Http\Controllers\BaseController;
use Angelov\Storgman\Events\Comments\Commands\StoreCommentCommand;
use Angelov\Storgman\Events\Comments\Http\Requests\StoreCommentRequest;
use Illuminate\Contracts\Auth\Guard;

class CommentsController extends BaseController
{
    public function store(StoreCommentRequest $request, Guard $auth)
    {
        $eventId = $request->get('event_id');
        $authorId = $auth->user()->getId();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $content = $request->get('content');

        dispatch(new StoreCommentCommand($authorId, $eventId, $content));

        return redirect()->back();
    }
}

1			<?php
2
3			/**
4			* Storgman - Student Organizations Management
5			* Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
6			*
7			* This file is part of Storgman.
8			*
9			* Storgman is free software: you can redistribute it and/or modify
10			* it under the terms of the GNU General Public License as published by
11			* the Free Software Foundation, either version 3 of the License, or
12			* (at your option) any later version.
13			*
14			* Storgman is distributed in the hope that it will be useful,
15			* but WITHOUT ANY WARRANTY; without even the implied warranty of
16			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17			* GNU General Public License for more details.
18			*
19			* You should have received a copy of the GNU General Public License
20			* along with Storgman. If not, see <http://www.gnu.org/licenses/>.
21			*
22			* @package Storgman
23			* @copyright Copyright (C) 2014-2016, Dejan Angelov <[email protected]>
24			* @license https://github.com/angelov/storgman/blob/master/LICENSE
25			* @author Dejan Angelov <[email protected]>
26			*/
27
28			namespace Angelov\Storgman\Events\Comments\Http\Controllers;
29
30			use Angelov\Storgman\Core\Http\Controllers\BaseController;
31			use Angelov\Storgman\Events\Comments\Commands\StoreCommentCommand;
32			use Angelov\Storgman\Events\Comments\Http\Requests\StoreCommentRequest;
33			use Illuminate\Contracts\Auth\Guard;
34
35			class CommentsController extends BaseController
36			{
37			public function store(StoreCommentRequest $request, Guard $auth)
38			{
39			$eventId = $request->get('event_id');
40			$authorId = $auth->user()->getId();
			0 ignored issues – show Bug introduced 2017-02-01 19:30 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `getId()` does only exist in the following implementations of said interface: `Angelov\Storgman\Members\Member`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
41			$content = $request->get('content');
42
43			dispatch(new StoreCommentCommand($authorId, $eventId, $content));
44
45			return redirect()->back();
46			}
47			}

angelov / storgman

CommentsController::store() A last analyzed 2017-02-01 19:30 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

CommentsController::store() A
last analyzed 2017-02-01 19:30 UTC