+global\MatchesTableRestructure::up()

Complexity

Conditions	8
Paths	2

Size

Total Lines	92
Code Lines	64

Duplication

Lines	5
Ratio	5.43 %

Importance

Changes

0

<?php
    public function up()
    {
        $playerParticipationTable = $this->table('match_participation', [
            'id' => false,
            'primary_key' => ['match_id', 'user_id']
        ]);
        $playerParticipationTable
            ->addColumn('match_id', 'integer', [
                'signed' => false,
                'limit' => 10,
                'null' => false,
                'comment' => 'The ID of the match this player participated in',
            ])
            ->addColumn('user_id', 'integer', [
                'signed' => false,
                'limit' => 10,
                'null' => false,
                'comment' => 'The ID of the player who participated in this match',
            ])
            ->addColumn('team_id', 'integer', [
                'signed' => false,
                'limit' => 10,
                'null' => true,
                'comment' => 'The ID of the team this player played for at the time of this match'
            ])
            ->addColumn('callsign', 'string', [
                'null' => true,
                'comment' => 'The callsign used by the player during this match.',
            ])
            ->addColumn('ip_address', 'string', [
                'limit' => 46,
                'null' => true,
                'comment' => 'The IP address used by the player in this match',
            ])
            // Integer operations in SQL are faster than strings; so for team loyalty, we can simplify it to 0 or 1
            ->addColumn('team_loyalty', 'integer', [
                'after' => 'callsign',
                'limit' => 1,
                'null' => false,
                'comment' => 'The team color this player played for: 0 will be for "TEAM A" and 1 will be for "TEAM B"'
            ])
            ->addForeignKey('match_id', 'matches', 'id', ['delete' => 'CASCADE'])
            ->addForeignKey('user_id', 'players', 'id', ['delete' => 'CASCADE'])
            ->addForeignKey('team_id', 'teams', 'id', ['delete' => 'SET_NULL'])
            ->create()
        ;

        $statement = $this->query("SELECT * FROM matches WHERE (team_a_players IS NOT NULL AND team_a_players != '') OR (team_b_players IS NOT NULL AND team_b_players != '')");
        $matches = $statement->fetchAll();

The method fetchAll cannot be called on $statement (of type array).

        $insertData = [];

        foreach ($matches as $match)
        {
            $team_a_players = explode(',', $match['team_a_players']);
            $team_b_players = explode(',', $match['team_b_players']);

            $dataBuilder = function(array $playerIDs, $isTeamA) use (&$insertData, $match) {
                foreach ($playerIDs as $playerID) {
                    if (empty($playerID)) {
                        continue;
                    }

                    $workspace = [
                        'match_id' => $match['id'],
                        'user_id' => $playerID,
                        'team_loyalty' => (int)$isTeamA,
                    ];

                    if ($match['team_a'] !== null && $isTeamA) {

This code seems to be duplicated across your project.

                        $workspace['team_id'] = $match['team_a'];
                    } elseif ($match['team_b'] !== null && !$isTeamA) {
                        $workspace['team_id'] = $match['team_b'];
                    }

                    $insertData[] = $workspace;
                }
            };

            $dataBuilder($team_a_players, true);
            $dataBuilder($team_b_players, false);
        }

        $playerParticipationTable->insert($insertData);
        $playerParticipationTable->saveData();

        $matchesTable = $this->table('matches');
        $matchesTable
            ->removeColumn('team_a_players')
            ->removeColumn('team_b_players')
            ->update()
        ;
    }