ParserFactory - Code Metrics - Inspection of "fix issue #131: allow the usage of .bat, .cmd and..." - alchemy-fr/Zippy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#132)

unknown

created 2021-05-02 13:22 UTC

ParserFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	4
dl	0
loc	41
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setZipDateFormat()	0	4	1
A	create()	0	18	4

<?php

/*
 * This file is part of Zippy.
 *
 * (c) Alchemy <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Alchemy\Zippy\Parser;

use Alchemy\Zippy\Exception\InvalidArgumentException;

class ParserFactory
{

    private static $zipDateFormat = 'Y-m-d H:i';

    /**
     * @param string $format Date format used to parse ZIP file listings
     */
    public static function setZipDateFormat($format)
    {
        self::$zipDateFormat = $format;
    }

    /**
     * Maps the corresponding parser to the selected adapter
     *
     * @param   string $adapterName An adapter name
     *
     * @return ParserInterface
     *
     * @throws InvalidArgumentException In case no parser were found
     */
    public static function create($adapterName)
    {
        switch ($adapterName) {
            case 'gnu-tar':
                return new GNUTarOutputParser();
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'bsd-tar':
                return new BSDTarOutputParser();
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'zip':
                return new ZipOutputParser(self::$zipDateFormat);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                throw new InvalidArgumentException(sprintf('No parser available for %s adapter', $adapterName));
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of Zippy.
5			*
6			* (c) Alchemy <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Alchemy\Zippy\Parser;
13
14			use Alchemy\Zippy\Exception\InvalidArgumentException;
15
16			class ParserFactory
17			{
18
19			private static $zipDateFormat = 'Y-m-d H:i';
20
21			/**
22			* @param string $format Date format used to parse ZIP file listings
23			*/
24			public static function setZipDateFormat($format)
25			{
26			self::$zipDateFormat = $format;
27			}
28
29			/**
30			* Maps the corresponding parser to the selected adapter
31			*
32			* @param string $adapterName An adapter name
33			*
34			* @return ParserInterface
35			*
36			* @throws InvalidArgumentException In case no parser were found
37			*/
38			public static function create($adapterName)
39			{
40			switch ($adapterName) {
41			case 'gnu-tar':
42			return new GNUTarOutputParser();
43			break;
			0 ignored issues – show Unused Code introduced 2016-02-12 10:17 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
44			case 'bsd-tar':
45			return new BSDTarOutputParser();
46			break;
			0 ignored issues – show Unused Code introduced 2016-02-12 10:17 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
47			case 'zip':
48			return new ZipOutputParser(self::$zipDateFormat);
49			break;
			0 ignored issues – show Unused Code introduced 2016-02-12 10:17 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
50
51			default:
52			throw new InvalidArgumentException(sprintf('No parser available for %s adapter', $adapterName));
53			break;
			0 ignored issues – show Unused Code introduced 2016-02-12 10:17 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
54			}
55			}
56			}
57

alchemy-fr / Zippy

Pull Request — master (#132)

ParserFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like