Issues (68)

src/Aimeos/Shop/Controller/AccountController.php (3 issues)

1
<?php
2
3
/**
4
 * @license MIT, http://opensource.org/licenses/MIT
5
 * @copyright Aimeos (aimeos.org), 2015-2016
6
 * @package laravel
7
 * @subpackage Controller
8
 */
9
10
11
namespace Aimeos\Shop\Controller;
12
13
use Aimeos\Shop\Facades\Shop;
14
use Illuminate\Routing\Controller;
15
use Illuminate\Support\Facades\Response;
16
17
18
/**
19
 * Aimeos controller for account related functionality.
20
 *
21
 * @package laravel
22
 * @subpackage Controller
23
 */
24
class AccountController extends Controller
25
{
26
	/**
27
	 * Returns the html for the "My account" page.
28
	 *
29
	 * @return \Illuminate\Http\Response Response object with output and headers
30
	 */
31
	public function indexAction()
32
	{
33
		foreach( app( 'config' )->get( 'shop.page.account-index' ) as $name )
34
		{
35
			$params['aiheader'][$name] = Shop::get( $name )->getHeader();
0 ignored issues
show
The call to Aimeos\Shop\Facades\Shop::get() has too many arguments starting with $name. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

35
			$params['aiheader'][$name] = Shop::/** @scrutinizer ignore-call */ get( $name )->getHeader();

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
36
			$params['aibody'][$name] = Shop::get( $name )->getBody();
37
		}
38
39
		return Response::view('shop::account.index', $params);
0 ignored issues
show
Comprehensibility Best Practice introduced by Andreas
The variable $params seems to be defined by a foreach iteration on line 33. Are you sure the iterator is never empty, otherwise this variable is not defined?
Loading history...
40
	}
41
42
43
	/**
44
	 * Returns the html for the "My account" download page.
45
	 *
46
	 * @return \Illuminate\Contracts\View\View View for rendering the output
47
	 */
48
	public function downloadAction()
49
	{
50
		$response = Shop::get( 'account/download' )->getView()->response();
0 ignored issues
show
The call to Aimeos\Shop\Facades\Shop::get() has too many arguments starting with 'account/download'. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

50
		$response = Shop::/** @scrutinizer ignore-call */ get( 'account/download' )->getView()->response();

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
51
		return Response::make( (string) $response->getBody(), $response->getStatusCode(), $response->getHeaders() );
52
	}
53
}