Aimeos\MW\Process\DiscardFilter

Complexity

Total Complexity

2

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	filter()	0	10	2

<?php

namespace Aimeos\MW\Process;


class PcntlTest extends \PHPUnit\Framework\TestCase
{
	protected function setUp()
	{
		if( function_exists( 'pcntl_fork' ) === false ) {
			$this->markTestSkipped( 'PCNTL extension not available' );
		}
	}


	public function testIsAvailable()
	{
		$object = new \Aimeos\MW\Process\Pcntl();
		$this->assertTrue( $object->isAvailable() );
	}


	public function testRun()
	{
		$object = new \Aimeos\MW\Process\Pcntl();
		$fcn = function() { sleep( 1 ); };

		$start = microtime( true );
		$return = $object->start( $fcn, [] )->start( $fcn, [] )->wait();
		$msec = ( microtime( true ) - $start );

		$this->assertInstanceOf( '\Aimeos\MW\Process\Iface', $return );
		$this->assertGreaterThan( 1, $msec );
		$this->assertLessThan( 2, $msec );
	}


	public function testRunException()
	{
		$fcn = function() { throw new \Exception(); };

		try
		{
			stream_filter_register( "redirect", "\Aimeos\MW\Process\DiscardFilter" );
			$filter = stream_filter_prepend( STDERR, "redirect", STREAM_FILTER_WRITE );

			$object = new \Aimeos\MW\Process\Pcntl();
			$object->start( $fcn, [], true )->wait();

			stream_filter_remove( $filter );
		}
		catch( \Aimeos\MW\Process\Exception $e )
		{
			stream_filter_remove( $filter );

The variable $filter does not seem to be defined for all execution paths leading up to this point.

			return;
		}

		$this->fail( 'Expected exception "\Aimeos\MW\Process\Exception" not thrown' );
	}
}



class DiscardFilter extends \php_user_filter

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
	function filter( $in, $out, &$consumed, $closing )

It is generally recommended to explicitly declare the visibility for methods.

	{
		while( $bucket = stream_bucket_make_writeable( $in ) )
		{
			$bucket->data = '';
			$consumed += $bucket->datalen;
			stream_bucket_append( $out, $bucket );
		}
		return PSFS_PASS_ON;
	}
}