aimeos / aimeos-core

lib/mwlib/src/MW/Process/Pcntl.php

Doc Comments +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
 	 * @param \Closure $fcn Anonymous function to execute
 	 * @param array $data List of parameters that is passed to the closure function
 	 * @param boolean $restart True if the task should be restarted if it fails (only once)
-	 * @return \Aimeos\MW\Process\Iface Self object for method chaining
+	 * @return null|Pcntl Self object for method chaining
 	 * @throws \Aimeos\MW\Process\Exception If starting the new task failed
 	 */
 	public function start( \Closure $fcn, array $data, $restart = false )

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 			};
 
 			if( pcntl_signal( SIGTERM, $handler ) === false ) {
-				throw new Exception( 'Unable to install signal handler: ' . pcntl_strerror( pcntl_get_last_error() ) );
+				throw new Exception( 'Unable to install signal handler: '.pcntl_strerror( pcntl_get_last_error() ) );
 			}
 		}
 	}
@@ -104,7 +104,7 @@ 
 		flush(); // flush all pending output so it's not printed in childs again
 
 		if( ( $pid = pcntl_fork() ) === -1 ) {
-			throw new Exception( 'Unable to fork new process: ' . pcntl_strerror( pcntl_get_last_error() ) );
+			throw new Exception( 'Unable to fork new process: '.pcntl_strerror( pcntl_get_last_error() ) );
 		}
 
 		if( $pid === 0 ) {  // child process
@@ -187,7 +187,7 @@ 
 		$status = -1;
 
 		if( ( $pid = pcntl_wait( $status ) ) === -1 ) {
-			throw new Exception( 'Unable to wait for child process: ' . pcntl_strerror( pcntl_get_last_error() ) );
+			throw new Exception( 'Unable to wait for child process: '.pcntl_strerror( pcntl_get_last_error() ) );
 		}
 
 		list( $fcn, $data, $restart ) = $this->list[$pid];

Braces +5 added lines, -2 removed lines

@@ -166,9 +166,12 @@
 			ob_end_clean(); // avoid printing buffered messages of the parent again
 		}
 
-		try {
+		try
+		{
 			call_user_func_array( $fcn, $data );
-		} catch( \Exception $e ) {
+		}
+		catch( \Exception $e )
+		{
 			return 1;
 		}
 

lib/mshoplib/src/MShop/Context/Item/Iface.php

Indentation +3 added lines, -3 removed lines

@@ -162,7 +162,7 @@ 
 	 * Returns the message queue manager object.
 	 *
 	 * @return \Aimeos\MW\MQueue\Manager\Iface Message queue manager object
-	*/
+	 */
 	public function getMessageQueueManager();
 
 	/**
@@ -186,7 +186,7 @@ 
 	 * Returns the process object.
 	 *
 	 * @return \Aimeos\MW\Process\Iface Process object
-	*/
+	 */
 	public function getProcess();
 
 	/**
@@ -201,7 +201,7 @@ 
 	 * Returns the session object.
 	 *
 	 * @return \Aimeos\MW\Session\Iface Session object
-	*/
+	 */
 	public function getSession();
 
 	/**

lib/mshoplib/src/MShop/Context/Item/Standard.php

Indentation +3 added lines, -3 removed lines

@@ -375,7 +375,7 @@ 
 	 * Returns the message queue manager object.
 	 *
 	 * @return \Aimeos\MW\MQueue\Manager\Iface Message queue manager object
-	*/
+	 */
 	public function getMessageQueueManager()
 	{
 		if( !isset( $this->mqueue ) ) {
@@ -392,7 +392,7 @@ 
 	 * @param string $resource Resource name, e.g. "mq-email"
 	 * @apram string $queue Message queue name, e.g. "order/email/payment"
 	 * @return \Aimeos\MW\Queue\Manager\Iface Message queue object
-	*/
+	 */
 	public function getMessageQueue( $resource, $queue )
 	{
 		if( !isset( $this->mqueue ) ) {
@@ -421,7 +421,7 @@ 
 	 * Returns the process object.
 	 *
 	 * @return \Aimeos\MW\Process\Iface Process object
-	*/
+	 */
 	public function getProcess()
 	{
 		if( !isset( $this->process ) ) {

lib/mwlib/tests/MW/Process/PcntlTest.php

Braces +6 added lines, -2 removed lines

@@ -23,7 +23,9 @@ 
 	public function testRun()
 	{
 		$object = new \Aimeos\MW\Process\Pcntl();
-		$fcn = function() { sleep( 1 ); };
+		$fcn = function()
+		{
+sleep( 1 ); };
 
 		$start = microtime( true );
 		$return = $object->start( $fcn, [] )->start( $fcn, [] )->wait();
@@ -37,7 +39,9 @@ 
 
 	public function testRunException()
 	{
-		$fcn = function() { throw new \Exception(); };
+		$fcn = function()
+		{
+throw new \Exception(); };
 
 		$object = new \Aimeos\MW\Process\Pcntl();
 

lib/mwlib/tests/MW/Process/NoneTest.php

Braces +3 added lines, -1 removed lines

@@ -16,7 +16,9 @@
 	{
 		$object = new \Aimeos\MW\Process\None();
 
-		$this->assertInstanceOf( '\Aimeos\MW\Process\Iface', $object->start( function() {}, [] ) );
+		$this->assertInstanceOf( '\Aimeos\MW\Process\Iface', $object->start( function()
+		{
+}, [] ) );
 	}
 
 

lib/mshoplib/src/MShop/Catalog/Item/Standard.php

Doc Comments +2 added lines, -2 removed lines

@@ -211,7 +211,7 @@ 
 	 * Sets a new URL target specific for that category
 	 *
 	 * @param string $value New URL target specific for that category
-	 * @return \Aimeos\MShop\Product\Item\Iface Product item for chaining method calls
+	 * @return Standard Product item for chaining method calls
 	 */
 	public function setTarget( $value )
 	{
@@ -342,7 +342,7 @@ 
 	/**
 	 * Returns all children of this node.
 	 *
-	 * @return array Numerically indexed list of nodes
+	 * @return Iface[] Numerically indexed list of nodes
 	 */
 	public function getChildren()
 	{

lib/mshoplib/tests/MShop/Product/Manager/Property/Type/StandardTest.php

Spacing +14 added lines, -14 removed lines

@@ -19,13 +19,13 @@ 
 	{
 		$this->editor = \TestHelperMShop::getContext()->getEditor();
 		$manager = \Aimeos\MShop\Product\Manager\Factory::createManager( \TestHelperMShop::getContext() );
-		$this->object = $manager->getSubManager( 'property' )->getSubManager('type');
+		$this->object = $manager->getSubManager( 'property' )->getSubManager( 'type' );
 	}
 
 
 	protected function tearDown()
 	{
-		unset($this->object);
+		unset( $this->object );
 	}
 
 
@@ -68,7 +68,7 @@ 
 
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results) ) === false )
+		if( ( $expected = reset( $results ) ) === false )
 		{
 			throw new \RuntimeException( 'No property type item found.' );
 		}
@@ -90,13 +90,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$search->setConditions( $search->compare( '==', 'product.property.type.editor', $this->editor ) );
-		$results = $this->object->searchItems($search);
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -156,24 +156,24 @@ 
 		$expr[] = $search->compare( '>=', 'product.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'product.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
 
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '=~', 'product.property.type.code', 'package-'),
+			$search->compare( '=~', 'product.property.type.code', 'package-' ),
 			$search->compare( '==', 'product.property.type.editor', $this->editor )
 		);
-		$search->setConditions( $search->combine('&&', $conditions ) );
-		$search->setSlice(0, 1);
-		$items = $this->object->searchItems( $search, [], $total);
+		$search->setConditions( $search->combine( '&&', $conditions ) );
+		$search->setSlice( 0, 1 );
+		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 4, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -181,7 +181,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Product/Manager/Property/StandardTest.php

Spacing +13 added lines, -13 removed lines

@@ -54,11 +54,11 @@ 
 		$search->setConditions( $search->compare( '==', 'product.property.editor', $this->editor ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No property item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setLanguageId( 'en' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -109,13 +109,13 @@ 
 	{
 		$search = $this->object->createSearch();
 		$conditions = array(
-			$search->compare( '~=', 'product.property.value', '25.0'),
+			$search->compare( '~=', 'product.property.value', '25.0' ),
 			$search->compare( '==', 'product.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
 		$results = $this->object->searchItems( $search );
 
-		if( ($expected = reset($results)) === false ) {
+		if( ( $expected = reset( $results ) ) === false ) {
 			throw new \RuntimeException( sprintf( 'No product property item found for value "%1$s".', '25.0' ) );
 		}
 
@@ -166,7 +166,7 @@ 
 		$expr[] = $search->compare( '>=', 'product.property.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'product.property.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
+		$search->setConditions( $search->combine( '&&', $expr ) );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 
@@ -177,13 +177,13 @@ 
 			$search->compare( '==', 'product.property.editor', $this->editor )
 		);
 		$search->setConditions( $search->combine( '&&', $conditions ) );
-		$search->setSlice(0, 1);
+		$search->setSlice( 0, 1 );
 		$items = $this->object->searchItems( $search, [], $total );
 
 		$this->assertEquals( 1, count( $items ) );
 		$this->assertEquals( 8, $total );
 
-		foreach($items as $itemId => $item) {
+		foreach( $items as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -191,17 +191,17 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type') );
-		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager('type', 'Standard') );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type' ) );
+		$this->assertInstanceOf( '\\Aimeos\\MShop\\Common\\Manager\\Iface', $this->object->getSubManager( 'type', 'Standard' ) );
 
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 
 
 	public function testGetSubManagerInvalidName()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('type', 'unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'type', 'unknown' );
 	}
 }

lib/mshoplib/tests/MShop/Supplier/Manager/Lists/Type/StandardTest.php

Spacing +12 added lines, -12 removed lines

@@ -53,10 +53,10 @@ 
 	public function testGetItem()
 	{
 		$search = $this->object->createSearch();
-		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor) );
-		$results = $this->object->searchItems($search);
+		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor ) );
+		$results = $this->object->searchItems( $search );
 
-		if( ( $expected = reset($results) ) === false ) {
+		if( ( $expected = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No attribute list type item found' );
 		}
 
@@ -74,14 +74,14 @@ 
 	public function testSaveUpdateDeleteItem()
 	{
 		$search = $this->object->createSearch();
-		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor) );
-		$results = $this->object->searchItems($search);
+		$search->setConditions( $search->compare( '==', 'supplier.lists.type.editor', $this->editor ) );
+		$results = $this->object->searchItems( $search );
 
-		if( ( $item = reset($results) ) === false ) {
+		if( ( $item = reset( $results ) ) === false ) {
 			throw new \RuntimeException( 'No type item found' );
 		}
 
-		$item->setId(null);
+		$item->setId( null );
 		$item->setCode( 'unitTestSave' );
 		$resultSaved = $this->object->saveItem( $item );
 		$itemSaved = $this->object->getItem( $item->getId() );
@@ -140,13 +140,13 @@ 
 		$expr[] = $search->compare( '>=', 'supplier.lists.type.ctime', '1970-01-01 00:00:00' );
 		$expr[] = $search->compare( '==', 'supplier.lists.type.editor', $this->editor );
 
-		$search->setConditions( $search->combine('&&', $expr) );
-		$search->setSlice(0, 1);
+		$search->setConditions( $search->combine( '&&', $expr ) );
+		$search->setSlice( 0, 1 );
 		$results = $this->object->searchItems( $search, [], $total );
 		$this->assertEquals( 1, count( $results ) );
 		$this->assertEquals( 1, $total );
 
-		foreach($results as $itemId => $item) {
+		foreach( $results as $itemId => $item ) {
 			$this->assertEquals( $itemId, $item->getId() );
 		}
 	}
@@ -154,7 +154,7 @@ 
 
 	public function testGetSubManager()
 	{
-		$this->setExpectedException('\\Aimeos\\MShop\\Exception');
-		$this->object->getSubManager('unknown');
+		$this->setExpectedException( '\\Aimeos\\MShop\\Exception' );
+		$this->object->getSubManager( 'unknown' );
 	}
 }