aimeos / aimeos-core

lib/mshoplib/src/MShop/Common/Item/ListRef/Base.php

Doc Comments +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
 	 * @param string $domain Name of the domain (e.g. media, text, etc.)
 	 * @param \Aimeos\MShop\Common\Item\Lists\Iface $listItem List item referencing the new domain item
 	 * @param \Aimeos\MShop\Common\Item\Iface|null $refItem New item added to the given domain or null if no item should be referenced
-	 * @return \Aimeos\MShop\Common\Item\ListRef\Iface Self object for method chaining
+	 * @return Base Self object for method chaining
 	 */
 	public function addListItem( $domain, \Aimeos\MShop\Common\Item\Lists\Iface $listItem, \Aimeos\MShop\Common\Item\Iface $refItem = null )
 	{
@@ -75,7 +75,7 @@ 
 	 * @param string $domain Name of the domain (e.g. media, text, etc.)
 	 * @param \Aimeos\MShop\Common\Item\Lists\Iface $listItem List item referencing the domain item
 	 * @param \Aimeos\MShop\Common\Item\Iface|null $refItem Existing item removed from the given domain or null if item shouldn't be removed
-	 * @return \Aimeos\MShop\Common\Item\ListRef\Iface Self object for method chaining
+	 * @return Base Self object for method chaining
 	 * @throws \Aimeos\MShop\Exception If given list item isn't found
 	 */
 	public function deleteListItem( $domain, \Aimeos\MShop\Common\Item\Lists\Iface $listItem, \Aimeos\MShop\Common\Item\Iface $refItem = null )
@@ -214,9 +214,9 @@ 
 	 * to the requested domain to get the items. Otherwise, no items will be
 	 * returned by this method.
 	 *
-	 * @param array|string|null $domain Name/Names of the domain (e.g. product, text, etc.) or null for all
+	 * @param string $domain Name/Names of the domain (e.g. product, text, etc.) or null for all
 	 * @param array|string|null $type Name/Names of the item type or null for all
-	 * @param array|string|null $listtype Name/Names of the list item type or null for all
+	 * @param string $listtype Name/Names of the list item type or null for all
 	 * @param boolean $active True to return only active items, false to return all
 	 * @return array List of items implementing \Aimeos\MShop\Common\Item\Iface
 	 */

Spacing +4 added lines, -4 removed lines

@@ -54,12 +54,12 @@ 
 	 */
 	public function addListItem( $domain, \Aimeos\MShop\Common\Item\Lists\Iface $listItem, \Aimeos\MShop\Common\Item\Iface $refItem = null )
 	{
-		$id = $listItem->getId() ?: 'tmp-' . $this->max++;
+		$id = $listItem->getId() ?: 'tmp-'.$this->max++;
 		$this->listItems[$domain][$id] = $listItem->setDomain( $domain )->setRefItem( $refItem );
 
 		if( $refItem !== null )
 		{
-			$id = $refItem->getId() ?: 'tmp-' . $this->max++;
+			$id = $refItem->getId() ?: 'tmp-'.$this->max++;
 			$listItem->setRefId( $id );
 
 			$this->refItems[$domain][$id] = $refItem;
@@ -187,11 +187,11 @@ 
 
 			foreach( $list as $id => $item )
 			{
-				if( $listtype && ( !($item instanceof $iface) || !in_array( $item->getType(), $listTypes ) ) ) {
+				if( $listtype && ( !( $item instanceof $iface ) || !in_array( $item->getType(), $listTypes ) ) ) {
 					continue;
 				}
 
-				if( $type && ( !($item->getRefItem() instanceof $iface) || !in_array( $item->getRefItem()->getType(), $types ) ) ) {
+				if( $type && ( !( $item->getRefItem() instanceof $iface ) || !in_array( $item->getRefItem()->getType(), $types ) ) ) {
 					continue;
 				}
 

lib/mshoplib/src/MShop/Common/Item/PropertyRef/Traits.php

Doc Comments +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
 	 * Adds a new property item or overwrite an existing one
 	 *
 	 * @param \Aimeos\MShop\Common\Item\Property\Iface $item New or existing property item
-	 * @return \Aimeos\MShop\Common\Item\Iface Self object for method chaining
+	 * @return Traits Self object for method chaining
 	 */
 	public function addPropertyItem( \Aimeos\MShop\Common\Item\Property\Iface $item )
 	{
@@ -43,7 +43,7 @@ 
 	 * Removes an existing property item
 	 *
 	 * @param \Aimeos\MShop\Common\Item\Property\Iface $item Existing property item
-	 * @return \Aimeos\MShop\Common\Item\Iface Self object for method chaining
+	 * @return Traits Self object for method chaining
 	 * @throws \Aimeos\MShop\Exception If given property item isn't found
 	 */
 	public function deletePropertyItem( \Aimeos\MShop\Common\Item\Property\Iface $item )
@@ -67,7 +67,7 @@ 
 	 * Removes a list of existing property items
 	 *
 	 * @param \Aimeos\MShop\Common\Item\Property\Iface[] $items Existing property items
-	 * @return \Aimeos\MShop\Common\Item\Iface Self object for method chaining
+	 * @return Traits Self object for method chaining
 	 * @throws \Aimeos\MShop\Exception If an item isn't a property item or isn't found
 	 */
 	public function deletePropertyItems( array $items )

lib/mshoplib/tests/MShop/Common/Item/PropertyRef/TraitsTest.php

Doc Comments +3 added lines

@@ -13,6 +13,9 @@
 {
 	use \Aimeos\MShop\Common\Item\PropertyRef\Traits;
 
+	/**
+	 * @param \Aimeos\MShop\Common\Item\Property\Standard[] $list
+	 */
 	public function setPropertyItems( $list )
 	{
 		$this->propItems = $list;

Spacing +2 added lines, -2 removed lines

@@ -29,8 +29,8 @@
 
 	protected function setUp()
 	{
-		$this->propItem = new \Aimeos\MShop\Common\Item\Property\Standard( 'c.', ['languageid' => 'de', 'c.type' => 'test']);
-		$this->propItem2 = new \Aimeos\MShop\Common\Item\Property\Standard( 'c.', ['languageid' => 'de', 'c.languageid' => 'en', 'c.type' => 'test2']);
+		$this->propItem = new \Aimeos\MShop\Common\Item\Property\Standard( 'c.', ['languageid' => 'de', 'c.type' => 'test'] );
+		$this->propItem2 = new \Aimeos\MShop\Common\Item\Property\Standard( 'c.', ['languageid' => 'de', 'c.languageid' => 'en', 'c.type' => 'test2'] );
 
 		$this->object = new TraitsClass();
 		$this->object->setPropertyItems( [$this->propItem, $this->propItem2] );