View GitHub Repository ramda

Schedule Inspection
Subscribe
Completed
Pull Request — master (#16)
by Siwapun
07:05 queued 05:18
created
Status
Category
Toggle Patches
test/InsertTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,7 @@
 
 block discarded – undo
27 27 
   public function testInsertNth()
28 28 
   {
29 29 
     $array = [1, 2, 3, 4, 5];
30 
-    $expected = [1, 2,  'newItem', 3, 4, 5];
30 
+    $expected = [1, 2, 'newItem', 3, 4, 5];
31 31 
     $actual = insert(2)('newItem')($array);
32 32 
     $this->assertEquals($expected, $actual);
33 33 
   }
Please login to merge, or discard this patch.
src/function.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch 
@@ -7,8 +7,8 @@  discard block
 
 block discarded – undo
7 7 
  */
8 8 
 function always()
9 9 
 {
10 
-  $always = function ($data) {
11 
-    return function () use ($data) {
10 
+  $always = function($data) {
11 
+    return function() use ($data) {
12 12 
       return $data;
13 13 
     };
14 14 
   };
 
@@ -24,7 +24,7 @@  discard block
 
 block discarded – undo
24 24 
  */
25 25 
 function apply()
26 26 
 {
27 
-  $apply = function (callable $fn, array $args) {
27 
+  $apply = function(callable $fn, array $args) {
28 28 
     return call_user_func_array($fn, $args);
29 29 
   };
30 30 
   $arguments = func_get_args();
 
@@ -46,7 +46,7 @@  discard block
 
 block discarded – undo
46 46 
           return __FUNCTION__;
47 47 
     case 1:
48 48 
       $fn = $arguments[0];
49 
-          return function (...$arguments) use ($fn) {
49 
+          return function(...$arguments) use ($fn) {
50 50 
             return call_user_func_array($fn, $arguments);
51 51 
           };
52 52 
     default:
 
@@ -72,8 +72,8 @@  discard block
 
 block discarded – undo
72 72 
  */
73 73 
 function construct()
74 74 
 {
75 
-  $construct = function ($class) {
76 
-    return function () use ($class) {
75 
+  $construct = function($class) {
76 
+    return function() use ($class) {
77 77 
       return new $class();
78 78 
     };
79 79 
   };
 
@@ -89,7 +89,7 @@  discard block
 
 block discarded – undo
89 89 
  */
90 90 
 function curryN(callable $fn, int $numberOfArguments)
91 91 
 {
92 
-  return function () use ($fn, $numberOfArguments) {
92 
+  return function() use ($fn, $numberOfArguments) {
93 93 
     $arguments = func_get_args();
94 94 
     $length = count($arguments);
95 95 
     if ($length > $numberOfArguments) {
 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
       return call_user_func_array($fn, $arguments);
103 103 
     }
104 104 
     // AUTO CURRY
105 
-    $curriedFn = function () use ($fn, $arguments) {
105 
+    $curriedFn = function() use ($fn, $arguments) {
106 106 
       $curriedArguments = func_get_args();
107 107 
       return call_user_func_array($fn, array_merge($arguments, $curriedArguments));
108 108 
     };
 
@@ -116,7 +116,7 @@  discard block
 
 block discarded – undo
116 116 
  */
117 117 
 function identity()
118 118 
 {
119 
-  $identity = function ($value) {
119 
+  $identity = function($value) {
120 120 
     return $value;
121 121 
   };
122 122 
   $arguments = func_get_args();
 
@@ -132,7 +132,7 @@  discard block
 
 block discarded – undo
132 132 
  */
133 133 
 function partial(callable $fn, array $args)
134 134 
 {
135 
-  return function () use ($fn, $args) {
135 
+  return function() use ($fn, $args) {
136 136 
     $arguments = func_get_args();
137 137 
     return call_user_func_array($fn, array_merge($args, $arguments));
138 138 
   };
 
@@ -146,7 +146,7 @@  discard block
 
 block discarded – undo
146 146 
  */
147 147 
 function partialRight(callable $fn, array $args)
148 148 
 {
149 
-  return function () use ($fn, $args) {
149 
+  return function() use ($fn, $args) {
150 150 
     $arguments = func_get_args();
151 151 
     return call_user_func_array($fn, array_merge($arguments, $args));
152 152 
   };
 
@@ -163,10 +163,10 @@  discard block
 
 block discarded – undo
163 163 
   if ($length === 0) {
164 164 
     throw new \Exception("pipe requires at least one argument");
165 165 
   }
166 
-  return function () use ($arguments) {
166 
+  return function() use ($arguments) {
167 167 
     $internalArguments = func_get_args();
168 168 
     $initialValue = call_user_func_array($arguments[0], $internalArguments);
169 
-    $accumulator = function ($acc, $it) {
169 
+    $accumulator = function($acc, $it) {
170 170 
       return call_user_func_array($it, [$acc]);
171 171 
     };
172 172 
     return array_reduce(drop(0, $arguments), $accumulator, $initialValue);
Please login to merge, or discard this patch.
src/list.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@  discard block
 
 block discarded – undo
8 8 
  */
9 9 
 function all()
10 10 
 {
11 
-  $all = function (callable $predicateFunction, array $array): bool {
11 
+  $all = function(callable $predicateFunction, array $array): bool {
12 12 
     if (empty($array)) {
13 13 
       return false;
14 14 
     }
 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31 
  */
32 32 
 function any()
33 33 
 {
34 
-  $any = function (callable $predicateFunction, array $array) {
34 
+  $any = function(callable $predicateFunction, array $array) {
35 35 
     if (empty($array)) {
36 36 
       return false;
37 37 
     }
 
@@ -54,7 +54,7 @@  discard block
 
 block discarded – undo
54 54 
  */
55 55 
 function arrayForEach()
56 56 
 {
57 
-  $arrayForEach = function (callable $fn, array $array) {
57 
+  $arrayForEach = function(callable $fn, array $array) {
58 58 
     foreach ($array as $item) {
59 59 
       $fn($item);
60 60 
     }
 
@@ -72,7 +72,7 @@  discard block
 
 block discarded – undo
72 72 
  */
73 73 
 function append()
74 74 
 {
75 
-  $append = function ($item, array $array) {
75 
+  $append = function($item, array $array) {
76 76 
     return array_merge($array, [$item]);
77 77 
   };
78 78 
   $arguments = func_get_args();
 
@@ -88,7 +88,7 @@  discard block
 
 block discarded – undo
88 88 
  */
89 89 
 function concat()
90 90 
 {
91 
-  $concat = function (array $firstArray, array $secondArray) {
91 
+  $concat = function(array $firstArray, array $secondArray) {
92 92 
     return array_merge($firstArray, $secondArray);
93 93 
   };
94 94 
   $arguments = func_get_args();
 
@@ -117,7 +117,7 @@  discard block
 
 block discarded – undo
117 117 
  */
118 118 
 function drop()
119 119 
 {
120 
-  $drop = function (int $index, array $array) {
120 
+  $drop = function(int $index, array $array) {
121 121 
     return array_merge(array_slice($array, 0, $index), array_slice($array, $index + 1));
122 122 
   };
123 123 
   $arguments = func_get_args();
 
@@ -143,8 +143,8 @@  discard block
 
 block discarded – undo
143 143 
  */
144 144 
 function dropLast()
145 145 
 {
146 
-  $dropLast = function (array $array) {
147 
-    $index = count($array)-1;
146 
+  $dropLast = function(array $array) {
147 
+    $index = count($array) - 1;
148 148 
     return array_merge(array_slice($array, 0, $index), array_slice($array, $index + 1));
149 149 
   };
150 150 
 
@@ -160,7 +160,7 @@  discard block
 
 block discarded – undo
160 160 
  */
161 161 
 function endsWith()
162 162 
 {
163 
-  $endsWith = function ($suffix, $list) {
163 
+  $endsWith = function($suffix, $list) {
164 164 
     if (is_string($suffix) && is_string($list)) {
165 165 
       return $suffix === '' || (($temp = strlen($list) - strlen($suffix)) >= 0 && strpos($list, $suffix) !== false);
166 166 
     }
 
@@ -174,7 +174,7 @@  discard block
 
 block discarded – undo
174 174 
       }
175 175 
       return true;
176 176 
     }
177 
-    throw new \InvalidArgumentException(__FUNCTION__ . 'accepts only string or array as it arguments');
177 
+    throw new \InvalidArgumentException(__FUNCTION__.'accepts only string or array as it arguments');
178 178 
   };
179 179 
   $arguments = func_get_args();
180 180 
   $curried = curryN($endsWith, 2);
 
@@ -188,7 +188,7 @@  discard block
 
 block discarded – undo
188 188 
  */
189 189 
 function filter()
190 190 
 {
191 
-  $filter = function (callable $predicateFunction, array $array) {
191 
+  $filter = function(callable $predicateFunction, array $array) {
192 192 
      return array_values(array_filter($array, $predicateFunction));
193 193 
   };
194 194 
   $arguments = func_get_args();
 
@@ -203,7 +203,7 @@  discard block
 
 block discarded – undo
203 203 
  */
204 204 
 function filterPreserveKey()
205 205 
 {
206 
-  $filter = function (callable $predicateFunction, array $array) {
206 
+  $filter = function(callable $predicateFunction, array $array) {
207 207 
     return array_filter($array, $predicateFunction);
208 208 
   };
209 209 
   $arguments = func_get_args();
 
@@ -218,7 +218,7 @@  discard block
 
 block discarded – undo
218 218 
  */
219 219 
 function find()
220 220 
 {
221 
-  $find = function (callable $predicateFunction, array $list) {
221 
+  $find = function(callable $predicateFunction, array $list) {
222 222 
     foreach ($list as $item) {
223 223 
       if ($predicateFunction($item)) {
224 224 
         return $item;
 
@@ -233,7 +233,7 @@  discard block
 
 block discarded – undo
233 233
234 234 
 function first()
235 235 
 {
236 
-  $first = function (array $array) {
236 
+  $first = function(array $array) {
237 237 
     if (empty($array)) {
238 238 
       return null;
239 239 
     }
 
@@ -251,9 +251,9 @@  discard block
 
 block discarded – undo
251 251 
  */
252 252 
 function groupBy()
253 253 
 {
254 
-  $groupBy = function (callable $keySelector, array $array) {
254 
+  $groupBy = function(callable $keySelector, array $array) {
255 255 
     return reduce(
256 
-      function ($acc, $item) use ($keySelector) {
256 
+      function($acc, $item) use ($keySelector) {
257 257 
         $key = $keySelector($item);
258 258 
         $acc[$key] = array_key_exists($key, $acc) ? array_merge($acc[$key], [$item]) : [$item];
259 259 
         return $acc;
 
@@ -269,7 +269,7 @@  discard block
 
 block discarded – undo
269 269
270 270 
 function head()
271 271 
 {
272 
-  $head = function (array $array) {
272 
+  $head = function(array $array) {
273 273 
     if (empty($array)) {
274 274 
       return null;
275 275 
     }
 
@@ -288,7 +288,7 @@  discard block
 
 block discarded – undo
288 288 
  */
289 289 
 function insert()
290 290 
 {
291 
-  $insert = function (int $index, $element, array $array) {
291 
+  $insert = function(int $index, $element, array $array) {
292 292 
     return array_merge(
293 293 
       array_slice($array, 0, $index),
294 294 
       [$element],
 
@@ -302,7 +302,7 @@  discard block
 
 block discarded – undo
302 302
303 303 
 function last()
304 304 
 {
305 
-  $last = function (array $array) {
305 
+  $last = function(array $array) {
306 306 
     if (empty($array)) {
307 307 
       return null;
308 308 
     }
 
@@ -333,7 +333,7 @@  discard block
 
 block discarded – undo
333 333 
  */
334 334 
 function prepend()
335 335 
 {
336 
-  $prepend = function ($item, array $array) {
336 
+  $prepend = function($item, array $array) {
337 337 
     return array_merge([$item], $array);
338 338 
   };
339 339 
   $arguments = func_get_args();
 
@@ -349,7 +349,7 @@  discard block
 
 block discarded – undo
349 349 
  */
350 350 
 function reduce()
351 351 
 {
352 
-  $reduce = function (callable $accumulator, $initialValue, array $array) {
352 
+  $reduce = function(callable $accumulator, $initialValue, array $array) {
353 353 
     return array_reduce($array, $accumulator, $initialValue);
354 354 
   };
355 355 
   $arguments = func_get_args();
 
@@ -359,7 +359,7 @@  discard block
 
 block discarded – undo
359 359
360 360 
 function tail()
361 361 
 {
362 
-  $tail = function (array $array) {
362 
+  $tail = function(array $array) {
363 363 
     if (empty($array)) {
364 364 
       return null;
365 365 
     }
Please login to merge, or discard this patch.
src/logic.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@  discard block
 
 block discarded – undo
8 8 
  */
9 9 
 function andLogically()
10 10 
 {
11 
-  $and = function (bool $firstValue, bool $secondValue) {
11 
+  $and = function(bool $firstValue, bool $secondValue) {
12 12 
     return $firstValue && $secondValue;
13 13 
   };
14 14 
   $arguments = func_get_args();
 
@@ -18,7 +18,7 @@  discard block
 
 block discarded – undo
18 18
19 19 
 function defaultTo()
20 20 
 {
21 
-  $defaultTo = function ($defaultValue, $value) {
21 
+  $defaultTo = function($defaultValue, $value) {
22 22 
     return $value ? $value : $defaultValue;
23 23 
   };
24 24 
   $arguments = func_get_args();
 
@@ -35,8 +35,8 @@  discard block
 
 block discarded – undo
35 35 
  */
36 36 
 function ifElse()
37 37 
 {
38 
-  $ifElse = function (callable $condition, callable $onTrue, callable $onFalse) {
39 
-    return function () use ($condition, $onTrue, $onFalse) {
38 
+  $ifElse = function(callable $condition, callable $onTrue, callable $onFalse) {
39 
+    return function() use ($condition, $onTrue, $onFalse) {
40 40 
       $arguments = func_get_args();
41 41 
       if (call_user_func_array($condition, $arguments)) {
42 42 
         return call_user_func_array($onTrue, $arguments);
 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
  */
56 56 
 function isEmpty()
57 57 
 {
58 
-  $isEmpty = function ($value) {
58 
+  $isEmpty = function($value) {
59 59 
     return empty($value);
60 60 
   };
61 61 
   $arguments = func_get_args();
 
@@ -70,7 +70,7 @@  discard block
 
 block discarded – undo
70 70 
  */
71 71 
 function orLogically()
72 72 
 {
73 
-  $and = function (bool $firstValue, bool $secondValue) {
73 
+  $and = function(bool $firstValue, bool $secondValue) {
74 74 
     return $firstValue || $secondValue;
75 75 
   };
76 76 
   $arguments = func_get_args();
Please login to merge, or discard this patch.